Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 1895873006: compositor-worker: Initialize CW machinery plumbing to compositor and fire CW rAF callbacks. (Closed)

Created:
4 years, 8 months ago by flackr
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, Eric Willigers, f(malita), gavinp+loader_chromium.org, jam, Nate Chapin, Justin Novosad, kinuko+watch, loading-reviews_chromium.org, majidvp, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

compositor-worker: Initialize CW machinery plumbing to compositor and fire CW rAF callbacks. BUG=430155 TEST=virtual/threaded/fast/compositorworker/request-animation-frame.html CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f54e9b43c06e01f702c97ddf57cfbc0b1cb0547c Cr-Commit-Position: refs/heads/master@{#396829}

Patch Set 1 #

Patch Set 2 : Remove unused STL includes. #

Patch Set 3 : Remove unnecessary scope #

Total comments: 42

Patch Set 4 : Address most eview comments - improve test - CompositorMutator not using oilpan yet. #

Patch Set 5 : Bring up oilpan support during compositor worker creation and oilpan the compositor mutator and pro… #

Total comments: 46

Patch Set 6 : Address review comments, fix CompositorWorkerThreadTest, remove some obsolete code. #

Total comments: 10

Patch Set 7 : Address review comments. #

Patch Set 8 : Only allow setting global scope once. #

Total comments: 2

Patch Set 9 : Rename to StubCompositorMutator. #

Total comments: 14

Patch Set 10 : Move setLayerTreeMutator and comment Mutate call. #

Patch Set 11 : Add big fat TODOs in scheduler code to implement proper idle task scheduling and ensure GC is runni… #

Total comments: 24

Patch Set 12 : Review comments and ensure shutdown of WorkerBackingThread. #

Patch Set 13 : Merge with landed patches and move CompositorMutatorClient construction to be shared by WebViewImpl… #

Patch Set 14 : Make CompositorMutator GarbageCollectorFinalized to avoid Mixin in Impl. Add missing FakeProxy stub. #

Patch Set 15 : Include LayerTreeMutator definition so FakeProxy knows how to destruct one. #

Patch Set 16 : Include WebCompositorMutatorClient from WebLayerTreeView to allow unique_ptr usage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+446 lines, -31 lines) Patch
M cc/animation/layer_tree_mutator.h View 1 chunk +16 lines, -0 lines 0 comments Download
M cc/test/fake_proxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/channel_main.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +8 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +33 lines, -3 lines 0 comments Download
M cc/trees/proxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/proxy_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/proxy_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -0 lines 0 comments Download
M cc/trees/proxy_main.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/proxy_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/remote_channel_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/remote_channel_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/remote_channel_main.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/remote_channel_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +6 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +6 lines, -0 lines 0 comments Download
M cc/trees/threaded_channel.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/threaded_channel.cc View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M components/scheduler/child/compositor_worker_scheduler.h View 1 2 3 4 3 chunks +9 lines, -1 line 0 comments Download
M components/scheduler/child/compositor_worker_scheduler.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +18 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxyClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/CompositorMutator.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h View 1 2 3 4 1 chunk +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +29 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutatorClientTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +10 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/web/CompositorMutatorImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/CompositorMutatorImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +87 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/CompositorProxyClientImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 62 (17 generated)
flackr
Hi Jeremy, This patch adds the plumbing for compositor workers to request animation frames and ...
4 years, 8 months ago (2016-04-19 22:24:14 UTC) #3
haraken
https://codereview.chromium.org/1895873006/diff/40001/third_party/WebKit/Source/web/CompositorMutatorImpl.h File third_party/WebKit/Source/web/CompositorMutatorImpl.h (right): https://codereview.chromium.org/1895873006/diff/40001/third_party/WebKit/Source/web/CompositorMutatorImpl.h#newcode56 third_party/WebKit/Source/web/CompositorMutatorImpl.h:56: using ProxyClients = std::set<CompositorProxyClient*>; Can you make CompositorMutator GarbageCollected? ...
4 years, 8 months ago (2016-04-19 23:35:53 UTC) #5
jbroman
Some initial comments while I work on understanding the rest of it. https://codereview.chromium.org/1895873006/diff/40001/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame.html File third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame.html ...
4 years, 8 months ago (2016-04-20 19:24:52 UTC) #6
jbroman
Some more blink-side comments. At a high level things seem reasonable, but it's not clear ...
4 years, 8 months ago (2016-04-20 21:06:43 UTC) #7
flackr
Still working on getting CompositorMutatorImpl to use oilpan, but I thought I'd upload the resolutions ...
4 years, 7 months ago (2016-04-25 14:06:28 UTC) #8
flackr
In order to oilpan CompositorMutatorImpl and company, we needed to construct it on the right ...
4 years, 7 months ago (2016-04-29 15:50:17 UTC) #9
jbroman
https://codereview.chromium.org/1895873006/diff/80001/cc/trees/remote_channel_main.cc File cc/trees/remote_channel_main.cc (right): https://codereview.chromium.org/1895873006/diff/80001/cc/trees/remote_channel_main.cc#newcode70 cc/trees/remote_channel_main.cc:70: // TODO(vollick): add support for CompositorWorker. nit: Maybe also ...
4 years, 7 months ago (2016-04-29 19:42:23 UTC) #10
flackr
https://codereview.chromium.org/1895873006/diff/80001/cc/trees/remote_channel_main.cc File cc/trees/remote_channel_main.cc (right): https://codereview.chromium.org/1895873006/diff/80001/cc/trees/remote_channel_main.cc#newcode70 cc/trees/remote_channel_main.cc:70: // TODO(vollick): add support for CompositorWorker. On 2016/04/29 at ...
4 years, 7 months ago (2016-05-03 22:24:55 UTC) #11
jbroman
Almost there, I think. Thanks for your persistence. https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h File third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h (right): https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h#newcode22 third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h:22: CompositorMutatorClient(CompositorMutator*, ...
4 years, 7 months ago (2016-05-04 17:59:00 UTC) #12
flackr
https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h File third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h (right): https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h#newcode22 third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h:22: CompositorMutatorClient(CompositorMutator*, CompositorMutationsTarget*); On 2016/05/04 at 17:59:00, jbroman wrote: > ...
4 years, 7 months ago (2016-05-04 21:52:41 UTC) #13
jbroman
core/ and platform/ LGTM Please have someone familiar with workers review the WorkerBackingThread changes, as ...
4 years, 7 months ago (2016-05-04 22:11:06 UTC) #14
Ian Vollick
rbyers@chromium.org: Please review changes in public/platform/ skyostil@chromium.org: Please review changes in components/scheduler/ ajuma@chromium.org: Please review ...
4 years, 7 months ago (2016-05-05 12:08:30 UTC) #16
Rick Byers
public/ LGTM with nit https://codereview.chromium.org/1895873006/diff/160001/third_party/WebKit/public/platform/WebLayerTreeView.h File third_party/WebKit/public/platform/WebLayerTreeView.h (right): https://codereview.chromium.org/1895873006/diff/160001/third_party/WebKit/public/platform/WebLayerTreeView.h#newcode170 third_party/WebKit/public/platform/WebLayerTreeView.h:170: virtual void setMutatorClient(std::unique_ptr<WebCompositorMutatorClient>) {} nit: ...
4 years, 7 months ago (2016-05-05 14:02:22 UTC) #17
flackr
haraken (already on reviewer list), can you review the worker code and stamp Source/web? https://codereview.chromium.org/1895873006/diff/140001/third_party/WebKit/Source/platform/graphics/CompositorMutatorClientTest.cpp ...
4 years, 7 months ago (2016-05-05 14:04:15 UTC) #18
ajuma
cc lgtm https://codereview.chromium.org/1895873006/diff/160001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1895873006/diff/160001/cc/trees/layer_tree_host_impl.cc#newcode2009 cc/trees/layer_tree_host_impl.cc:2009: Mutate(CurrentBeginFrameArgs().frame_time); Is this done here (rather than ...
4 years, 7 months ago (2016-05-05 14:35:45 UTC) #19
Sami
https://codereview.chromium.org/1895873006/diff/160001/components/scheduler/child/compositor_worker_scheduler.cc File components/scheduler/child/compositor_worker_scheduler.cc (right): https://codereview.chromium.org/1895873006/diff/160001/components/scheduler/child/compositor_worker_scheduler.cc#newcode127 components/scheduler/child/compositor_worker_scheduler.cc:127: thread_->task_runner(), thread_->task_runner(), this, This is posting idle tasks as ...
4 years, 7 months ago (2016-05-05 14:56:08 UTC) #20
flackr
https://codereview.chromium.org/1895873006/diff/160001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1895873006/diff/160001/cc/trees/layer_tree_host_impl.cc#newcode2009 cc/trees/layer_tree_host_impl.cc:2009: Mutate(CurrentBeginFrameArgs().frame_time); On 2016/05/05 at 14:35:45, ajuma wrote: > Is ...
4 years, 7 months ago (2016-05-05 15:13:15 UTC) #21
Ian Vollick
https://codereview.chromium.org/1895873006/diff/160001/components/scheduler/child/compositor_worker_scheduler.cc File components/scheduler/child/compositor_worker_scheduler.cc (right): https://codereview.chromium.org/1895873006/diff/160001/components/scheduler/child/compositor_worker_scheduler.cc#newcode127 components/scheduler/child/compositor_worker_scheduler.cc:127: thread_->task_runner(), thread_->task_runner(), this, On 2016/05/05 15:13:15, flackr wrote: > ...
4 years, 7 months ago (2016-05-05 16:09:18 UTC) #22
Sami
interim lgtm for components/scheduler :) https://codereview.chromium.org/1895873006/diff/160001/components/scheduler/child/compositor_worker_scheduler.cc File components/scheduler/child/compositor_worker_scheduler.cc (right): https://codereview.chromium.org/1895873006/diff/160001/components/scheduler/child/compositor_worker_scheduler.cc#newcode127 components/scheduler/child/compositor_worker_scheduler.cc:127: thread_->task_runner(), thread_->task_runner(), this, On ...
4 years, 7 months ago (2016-05-05 16:53:39 UTC) #23
Ian Vollick
On 2016/05/05 16:53:39, Sami wrote: > interim lgtm for components/scheduler :) > > https://codereview.chromium.org/1895873006/diff/160001/components/scheduler/child/compositor_worker_scheduler.cc > ...
4 years, 7 months ago (2016-05-05 17:24:05 UTC) #24
flackr
https://codereview.chromium.org/1895873006/diff/160001/components/scheduler/child/compositor_worker_scheduler.cc File components/scheduler/child/compositor_worker_scheduler.cc (right): https://codereview.chromium.org/1895873006/diff/160001/components/scheduler/child/compositor_worker_scheduler.cc#newcode127 components/scheduler/child/compositor_worker_scheduler.cc:127: thread_->task_runner(), thread_->task_runner(), this, On 2016/05/05 at 16:53:39, Sami wrote: ...
4 years, 7 months ago (2016-05-05 18:36:00 UTC) #25
piman
lgtm
4 years, 7 months ago (2016-05-05 20:55:14 UTC) #26
haraken
I'm a bit afraid that this CL is trying to make too many changes in ...
4 years, 7 months ago (2016-05-06 02:45:51 UTC) #28
yhirano
https://codereview.chromium.org/1895873006/diff/200001/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h File third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h (right): https://codereview.chromium.org/1895873006/diff/200001/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h#newcode27 third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h:27: static void clearSharedBackingThread(); On 2016/05/06 02:45:51, haraken wrote: > ...
4 years, 7 months ago (2016-05-06 05:47:44 UTC) #29
flackr
I'll try to split out the pieces you identified, though CompositorProxyClientImpl can't really have a ...
4 years, 7 months ago (2016-05-06 18:15:08 UTC) #30
haraken
https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutator.h File third_party/WebKit/Source/platform/graphics/CompositorMutator.h (right): https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutator.h#newcode13 third_party/WebKit/Source/platform/graphics/CompositorMutator.h:13: class CompositorMutator : public GarbageCollectedFinalized<CompositorMutator> { On 2016/05/03 22:24:54, ...
4 years, 7 months ago (2016-05-09 01:37:05 UTC) #31
adrianna.komosinska
4 years, 7 months ago (2016-05-09 02:56:13 UTC) #33
yhirano
I introduced WorkerBackingThread's attach and detach for detaching ThreadState and v8::Isolate from the thread when ...
4 years, 7 months ago (2016-05-09 03:15:31 UTC) #35
yhirano
On 2016/05/09 03:15:31, yhirano wrote: > I introduced WorkerBackingThread's attach and detach for detaching ThreadState ...
4 years, 7 months ago (2016-05-09 03:30:15 UTC) #36
jbroman
(apologies for not replying here sooner) https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutator.h File third_party/WebKit/Source/platform/graphics/CompositorMutator.h (right): https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutator.h#newcode13 third_party/WebKit/Source/platform/graphics/CompositorMutator.h:13: class CompositorMutator : ...
4 years, 7 months ago (2016-05-19 18:50:05 UTC) #37
haraken
https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutator.h File third_party/WebKit/Source/platform/graphics/CompositorMutator.h (right): https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutator.h#newcode13 third_party/WebKit/Source/platform/graphics/CompositorMutator.h:13: class CompositorMutator : public GarbageCollectedFinalized<CompositorMutator> { On 2016/05/19 18:50:05, ...
4 years, 7 months ago (2016-05-19 23:55:52 UTC) #38
jbroman
https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutator.h File third_party/WebKit/Source/platform/graphics/CompositorMutator.h (right): https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutator.h#newcode13 third_party/WebKit/Source/platform/graphics/CompositorMutator.h:13: class CompositorMutator : public GarbageCollectedFinalized<CompositorMutator> { On 2016/05/19 at ...
4 years, 7 months ago (2016-05-20 00:06:52 UTC) #39
haraken
On 2016/05/20 00:06:52, jbroman wrote: > https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutator.h > File third_party/WebKit/Source/platform/graphics/CompositorMutator.h (right): > > https://codereview.chromium.org/1895873006/diff/80001/third_party/WebKit/Source/platform/graphics/CompositorMutator.h#newcode13 > ...
4 years, 7 months ago (2016-05-20 00:30:53 UTC) #40
jbroman
On 2016/05/20 at 00:30:53, haraken wrote: > In this particular case, I don't know about ...
4 years, 7 months ago (2016-05-20 00:37:49 UTC) #41
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895873006/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895873006/240001
4 years, 6 months ago (2016-05-30 17:31:36 UTC) #43
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/211246)
4 years, 6 months ago (2016-05-30 17:43:05 UTC) #45
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895873006/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895873006/260001
4 years, 6 months ago (2016-05-30 18:18:47 UTC) #47
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/221632)
4 years, 6 months ago (2016-05-30 18:56:32 UTC) #49
flackr
haraken, I've made the change to CompositorMutator to be GarbageCollectedFinalized itself, merged the patches which ...
4 years, 6 months ago (2016-05-30 19:17:45 UTC) #50
haraken
On 2016/05/30 19:17:45, flackr wrote: > haraken, I've made the change to CompositorMutator to be ...
4 years, 6 months ago (2016-05-31 00:20:34 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895873006/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895873006/280001
4 years, 6 months ago (2016-05-31 02:39:04 UTC) #54
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/221726)
4 years, 6 months ago (2016-05-31 03:13:44 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895873006/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895873006/300001
4 years, 6 months ago (2016-05-31 13:24:15 UTC) #59
commit-bot: I haz the power
Committed patchset #16 (id:300001)
4 years, 6 months ago (2016-05-31 15:20:27 UTC) #60
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 15:22:34 UTC) #62
Message was sent while issue was closed.
Patchset 16 (id:??) landed as
https://crrev.com/f54e9b43c06e01f702c97ddf57cfbc0b1cb0547c
Cr-Commit-Position: refs/heads/master@{#396829}

Powered by Google App Engine
This is Rietveld 408576698