third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame.html - Issue 1895873006: compositor-worker: Initialize CW machinery plumbing to compositor and fire CW rAF callbacks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame.html

Issue 1895873006: compositor-worker: Initialize CW machinery plumbing to compositor and fire CW rAF callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bring up oilpan support during compositor worker creation and oilpan the compositor mutator and pro… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« cc/trees/remote_channel_main.cc ('K') | « content/renderer/gpu/render_widget_compositor.cc ('k') | third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame-expected.txt » ('j') | third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../../resources/js-test.js"></script>

	3 <script>

	4 var jsTestIsAsync = true;

	5 description('Tests that requestAnimationFrame is invoked with correct timestamp on CompositorWorker.');

	6 if (window.internals)

	7 internals.settings.setCompositorWorkerEnabled(true);

	8

	9 var cw = new CompositorWorker('resources/request-animation-frame.js');

	10 var startTime = performance.now();

	11 var rafTime;

	12 var endTime;

	13 cw.postMessage('');
	jbroman 2016/04/29 19:42:22 you can remove this postMessage, now that the work you can remove this postMessage, now that the worker no longer listens for the message flackr 2016/05/03 22:24:54 Oops, forgot to remove it, thanks. Removed. Show quoted text On 2016/04/29 at 19:42:22, jbroman wrote: > you can remove this postMessage, now that the worker no longer listens for the message Oops, forgot to remove it, thanks. Removed.
	14 cw.onmessage = function(e) {

	15 rafTime = e.data;

	16 endTime = performance.now();

	17 shouldBe('startTime <= rafTime', 'true');
	jbroman 2016/04/29 19:42:22 nit: shouldBeGreaterThanOrEqual('rafTime', 'startT nit: shouldBeGreaterThanOrEqual('rafTime', 'startTime'); shouldBeGreaterThanOrEqual('endTime', 'rafTime'); gives slightly nicer failure messages flackr 2016/05/03 22:24:54 Done. Show quoted text On 2016/04/29 at 19:42:22, jbroman wrote: > nit: > shouldBeGreaterThanOrEqual('rafTime', 'startTime'); > shouldBeGreaterThanOrEqual('endTime', 'rafTime'); > > gives slightly nicer failure messages Done.
	18 shouldBe('rafTime <= endTime', 'true');

	19 testPassed('Received reply from CompositorWorker.');

	20 finishJSTest();

	21 }

	22 </script>

OLD	NEW