third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame.html - Issue 1895873006: compositor-worker: Initialize CW machinery plumbing to compositor and fire CW rAF callbacks.

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame.html

Issue 1895873006: compositor-worker: Initialize CW machinery plumbing to compositor and fire CW rAF callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary scope Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/renderer/gpu/render_widget_compositor.cc ('k') | third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame-expected.txt » ('j') | third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/request-animation-frame.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <!--

	3 Tests that requestAnimationFrame runs on the compositor worker.

	4 -->

	5 <script>

	6 window.jsTestIsAsync = true;
	jbroman 2016/04/20 19:24:51 This needn't be in a script tag above js-test.js. This needn't be in a script tag above js-test.js. flackr 2016/04/25 14:06:27 Done, thanks for the test pointers - it looks much Show quoted text On 2016/04/20 at 19:24:51, jbroman wrote: > This needn't be in a script tag above js-test.js. Done, thanks for the test pointers - it looks much cleaner now.
	7 </script>

	8 <script src="../../../../resources/js-test.js"></script>

	9 <script>

	10 if (window.testRunner)

	11 testRunner.dumpAsText(true);

	12 if (window.internals) {

	13 internals.settings.setCompositorWorkerEnabled(true);

	14 }

	15

	16 var cw;

	17 onload = function() {
	jbroman 2016/04/20 19:24:50 Do you need to wait for onload? If so, why? Do you need to wait for onload? If so, why? flackr 2016/04/25 14:06:27 No, removed. Show quoted text On 2016/04/20 at 19:24:50, jbroman wrote: > Do you need to wait for onload? If so, why? No, removed.
	18 cw = new CompositorWorker('resources/request-animation-frame.js');

	19 cw.onmessage = finishTest;

	20 cw.postMessage('');

	21 }

	22

	23 function finishTest(e) {

	24 document.getElementById('result').textContent = e.data;

	25 if (window.testRunner)
	jbroman 2016/04/20 19:24:50 It's weird to use the js-test way of marking the t It's weird to use the js-test way of marking the test async, but the direct internals way of marking it done. Since you're using it anyways, I'd suggest writing to the usual js-test.js conventions. <script src="../../../../resources/js-test.js"></script> <script> jsTestIsAsync = true; description('Tests that requestAnimationFrame is invoked in CompositorWorker'); if (window.internals) internals.settings.setCompositorWorkerEnabled(true); var cw = new CompositorWorker('resources/request-animation-frame.js'); cw.onmessage = function(e) { testPassed('Received reply from CompositorWorker.'); finishJSTest(); }; </script> flackr 2016/04/25 14:06:27 Done. I also made it record the time before raf wa Show quoted text On 2016/04/20 at 19:24:50, jbroman wrote: > It's weird to use the js-test way of marking the test async, but the direct internals way of marking it done. Since you're using it anyways, I'd suggest writing to the usual js-test.js conventions. > > <script src="../../../../resources/js-test.js"></script> > <script> > jsTestIsAsync = true; > description('Tests that requestAnimationFrame is invoked in CompositorWorker'); > if (window.internals) > internals.settings.setCompositorWorkerEnabled(true); > var cw = new CompositorWorker('resources/request-animation-frame.js'); > cw.onmessage = function(e) { > testPassed('Received reply from CompositorWorker.'); > finishJSTest(); > }; > </script> Done. I also made it record the time before raf was called, and the time after raf was called to ensure that the time passed to raf is in the correct time base.
	26 testRunner.notifyDone();

	27 }

	28 </script>

	29 <div id="result"></div>

OLD	NEW