Removed implementation of CHROMIUM_subscribe_uniform

Removed implementation of CHROMIUM_subscribe_uniform

BUG=604531
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d
Cr-Commit-Position: refs/heads/master@{#389044}

[bajones, 2016-04-18 22:27:29]

Description was changed from

==========
Removed implementation of CHROMIUM_subscribe_uniform

BUG=604531
==========

to

==========
Removed implementation of CHROMIUM_subscribe_uniform

BUG=604531
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[bajones, 2016-04-18 22:27:30]

Description was changed from

==========
Removed implementation of CHROMIUM_subscribe_uniform

BUG=604531
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Removed implementation of CHROMIUM_subscribe_uniform

BUG=604531
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[bajones, 2016-04-18 22:30:18]

bajones@chromium.org changed reviewers:
+ kbr@chromium.org, piman@chromium.org, zmo@chromium.org

[bajones, 2016-04-18 22:30:19]

Apologies for the large patch, fortunately it's all code removal. Kind of
amazing how much code this extension touched.

[Ken Russell (switch to Gerrit), 2016-04-18 22:36:10]

lgtm for the WebKit side and anything else I'm an OWNER of.

Sorry to all involved who invested time in this. Unfortunately it turned out to
be difficult to work with, and there wasn't going to be a customer putting it to
use. Going forward, effort will be best spent just reducing the latency of
Chrome's rendering pipeline.

[Zhenyao Mo, 2016-04-18 23:08:39]

gpu/command_buffer lgtm

[bajones, 2016-04-18 23:17:10]

bajones@chromium.org changed reviewers:
+ mkwst@chromium.org, rockot@chromium.org

[bajones, 2016-04-18 23:17:10]

Adding rockot@ for mojo/public/ review and mkwst@ for gpu_host_message.h review

[Ken Rockot(use gerrit already), 2016-04-18 23:22:20]

lgtm

[haraken, 2016-04-19 00:02:31]

modules/ LGTM

[piman, 2016-04-19 00:31:50]

LGTM. Thanks for the thorough clean up.

[bajones, 2016-04-19 00:59:47]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2016-04-19 01:00:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894313002/1

[commit-bot: I haz the power, 2016-04-19 01:03:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 01:03:29]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[bajones, 2016-04-19 17:09:44]

bajones@chromium.org changed reviewers:
+ dcheng@chromium.org

[bajones, 2016-04-19 17:09:44]

Fixing patch conflicts now.

+dcheng@ to rubber stamp gpu_host_messages.h removals since is seems mkwst@ has
limited availability.

[dcheng, 2016-04-19 17:13:29]

dcheng@chromium.org changed reviewers:
+ haraken@chromium.org

[dcheng, 2016-04-19 17:13:30]

rs lgtm for ipc removals.

yay for code deletions

[bajones, 2016-04-19 17:31:44]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-04-19 17:31:45]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
rockot@chromium.org, dcheng@chromium.org, piman@chromium.org, zmo@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1894313002/#ps20001
(title: "Merge conflict resolution")

[commit-bot: I haz the power, 2016-04-19 17:32:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894313002/20001

[commit-bot: I haz the power, 2016-04-19 17:38:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 17:38:29]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[bajones, 2016-04-19 17:47:29]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-04-19 17:47:30]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
rockot@chromium.org, dcheng@chromium.org, piman@chromium.org, zmo@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1894313002/#ps40001
(title: "Fixing GN issues.")

[commit-bot: I haz the power, 2016-04-19 17:48:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894313002/40001

[commit-bot: I haz the power, 2016-04-19 18:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 18:00:55]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[bajones, 2016-04-19 19:41:01]

The CQ bit was checked by bajones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 19:41:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894313002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894313002/60001

[commit-bot: I haz the power, 2016-04-19 20:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 20:00:26]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[bajones, 2016-04-19 20:23:51]

The CQ bit was checked by bajones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 20:24:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894313002/80001

[commit-bot: I haz the power, 2016-04-19 21:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 21:05:47]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[bajones, 2016-04-19 21:29:57]

Okay, looking like I've caught the rest of the references to this extension that
I've missed now, primarily mus/gles2/ (+rjkroege@ for review)

linux_android_rel_ng failure seems unrelated.

[bajones, 2016-04-19 22:58:43]

bajones@chromium.org changed reviewers:
+ rjkroege@chromium.org

[bajones, 2016-04-19 22:58:44]

Actually +rjkroege@ for mus/gles2/ review this time.

[bajones, 2016-04-21 22:21:23]

bajones@chromium.org changed reviewers:
+ fsamuel@chromium.org

[bajones, 2016-04-21 22:21:24]

Ping rjkroege@ or fsamuel@ for mus/gles2 review?

[Fady Samuel, 2016-04-22 04:53:54]

mus lgtm

[bajones, 2016-04-22 05:14:53]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-04-22 05:14:54]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
rockot@chromium.org, dcheng@chromium.org, piman@chromium.org, zmo@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1894313002/#ps80001
(title: "Missed a couple more mus/ references")

[commit-bot: I haz the power, 2016-04-22 05:15:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894313002/80001

[commit-bot: I haz the power, 2016-04-22 06:28:59]

Committed patchset #5 (id:80001)

[Nico, 2016-04-22 13:52:00]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-04-22 13:52:02]

I think this breaks enable_ipc_fuzzer=1 builds (to repro, set that in your
GYP_DEFINES).

Example:

https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan/builds/3422/step...
..\..\tools\ipc_fuzzer\fuzzer\fuzzer.cc(1256,24):  error: no member named
'ValueState' in namespace 'gpu'
struct FuzzTraits<gpu::ValueState> {
                  ~~~~~^


Please take a look.

[bajones, 2016-04-22 15:22:17]

On 2016/04/22 13:52:02, Nico wrote:
> I think this breaks enable_ipc_fuzzer=1 builds (to repro, set that in your
> GYP_DEFINES).
> 
> Example:
> 
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan/builds/3422/step...
> ..\..\tools\ipc_fuzzer\fuzzer\fuzzer.cc(1256,24):  error: no member named
> 'ValueState' in namespace 'gpu'
> struct FuzzTraits<gpu::ValueState> {
>                   ~~~~~^
> 
> 
> Please take a look.

That's definitely related. I'll fix it ASAP.

[commit-bot: I haz the power, 2016-04-22 19:44:59]

Description was changed from

==========
Removed implementation of CHROMIUM_subscribe_uniform

BUG=604531
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Removed implementation of CHROMIUM_subscribe_uniform

BUG=604531
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d
Cr-Commit-Position: refs/heads/master@{#389044}
==========

[commit-bot: I haz the power, 2016-04-22 19:45:01]

Patchset 5 (id:??) landed as
https://crrev.com/fa5e16c558164eeb7430be1f9846abdf8580ff2d
Cr-Commit-Position: refs/heads/master@{#389044}