Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1893973002: Outline SkImageFilter Make methods (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -111 lines) Patch
M include/effects/SkBlurImageFilter.h View 1 chunk +3 lines, -7 lines 0 comments Download
M include/effects/SkComposeImageFilter.h View 1 chunk +2 lines, -10 lines 0 comments Download
M include/effects/SkDropShadowImageFilter.h View 1 chunk +1 line, -6 lines 0 comments Download
M include/effects/SkImageSource.h View 1 chunk +2 lines, -16 lines 0 comments Download
M include/effects/SkMergeImageFilter.h View 1 chunk +2 lines, -9 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 2 chunks +2 lines, -16 lines 0 comments Download
M include/effects/SkOffsetImageFilter.h View 1 chunk +1 line, -7 lines 0 comments Download
M include/effects/SkPaintImageFilter.h View 1 chunk +1 line, -3 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 2 chunks +3 lines, -15 lines 0 comments Download
M include/effects/SkTestImageFilters.h View 1 chunk +1 line, -10 lines 0 comments Download
M src/core/SkLocalMatrixImageFilter.h View 1 chunk +1 line, -12 lines 0 comments Download
M src/core/SkLocalMatrixImageFilter.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/effects/SkComposeImageFilter.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M src/effects/SkImageSource.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/effects/SkPaintImageFilter.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M src/effects/SkTestImageFilters.cpp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
robertphillips
4 years, 8 months ago (2016-04-17 19:26:56 UTC) #4
reed1
lgtm
4 years, 8 months ago (2016-04-17 19:43:36 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893973002/20001
4 years, 8 months ago (2016-04-17 21:04:39 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-17 21:23:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893973002/20001
4 years, 8 months ago (2016-04-17 21:26:23 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-17 21:27:09 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/225db4441e0cb887d52c906e8bb39df506304b3e

Powered by Google App Engine
This is Rietveld 408576698