Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: include/effects/SkTestImageFilters.h

Issue 1893973002: Outline SkImageFilter Make methods (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: update to ToT Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/effects/SkPictureImageFilter.h ('k') | src/core/SkLocalMatrixImageFilter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/effects/SkTestImageFilters.h
diff --git a/include/effects/SkTestImageFilters.h b/include/effects/SkTestImageFilters.h
index 0f89759c1c8dd141d059945b5097046f52c45230..4aa30083ddaef8dd631ca147697bccdc70c4f144 100644
--- a/include/effects/SkTestImageFilters.h
+++ b/include/effects/SkTestImageFilters.h
@@ -14,16 +14,7 @@
// Fun mode that scales down (only) and then scales back up to look pixelated
class SK_API SkDownSampleImageFilter : public SkImageFilter {
public:
- static sk_sp<SkImageFilter> Make(SkScalar scale, sk_sp<SkImageFilter> input) {
- if (!SkScalarIsFinite(scale)) {
- return nullptr;
- }
- // we don't support scale in this range
- if (scale > SK_Scalar1 || scale <= 0) {
- return nullptr;
- }
- return sk_sp<SkImageFilter>(new SkDownSampleImageFilter(scale, std::move(input)));
- }
+ static sk_sp<SkImageFilter> Make(SkScalar scale, sk_sp<SkImageFilter> input);
SK_TO_STRING_OVERRIDE()
SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkDownSampleImageFilter)
« no previous file with comments | « include/effects/SkPictureImageFilter.h ('k') | src/core/SkLocalMatrixImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698