Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: include/effects/SkImageSource.h

Issue 1893973002: Outline SkImageFilter Make methods (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: update to ToT Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/effects/SkDropShadowImageFilter.h ('k') | include/effects/SkMergeImageFilter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/effects/SkImageSource.h
diff --git a/include/effects/SkImageSource.h b/include/effects/SkImageSource.h
index 0b4fecd776e365f6889ae2b4078a972afa24bf4d..4ceff95668ee635ec4148352947f93c5930ecd37 100644
--- a/include/effects/SkImageSource.h
+++ b/include/effects/SkImageSource.h
@@ -13,25 +13,11 @@
class SK_API SkImageSource : public SkImageFilter {
public:
- static sk_sp<SkImageFilter> Make(sk_sp<SkImage> image) {
- if (!image) {
- return nullptr;
- }
-
- return sk_sp<SkImageFilter>(new SkImageSource(std::move(image)));
- }
+ static sk_sp<SkImageFilter> Make(sk_sp<SkImage> image);
static sk_sp<SkImageFilter> Make(sk_sp<SkImage> image,
const SkRect& srcRect,
const SkRect& dstRect,
- SkFilterQuality filterQuality) {
- if (!image) {
- return nullptr;
- }
-
- return sk_sp<SkImageFilter>(new SkImageSource(std::move(image),
- srcRect, dstRect,
- filterQuality));
- }
+ SkFilterQuality filterQuality);
SkRect computeFastBounds(const SkRect& src) const override;
« no previous file with comments | « include/effects/SkDropShadowImageFilter.h ('k') | include/effects/SkMergeImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698