Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: include/effects/SkMorphologyImageFilter.h

Issue 1893973002: Outline SkImageFilter Make methods (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: update to ToT Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/effects/SkMergeImageFilter.h ('k') | include/effects/SkOffsetImageFilter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/effects/SkMorphologyImageFilter.h
diff --git a/include/effects/SkMorphologyImageFilter.h b/include/effects/SkMorphologyImageFilter.h
index 27608ecd07f8d727e0e91a81400312b7af75a508..fbbbe207ab0285fd8ae06d9789972c2bfc47e90e 100644
--- a/include/effects/SkMorphologyImageFilter.h
+++ b/include/effects/SkMorphologyImageFilter.h
@@ -57,14 +57,7 @@ class SK_API SkDilateImageFilter : public SkMorphologyImageFilter {
public:
static sk_sp<SkImageFilter> Make(int radiusX, int radiusY,
sk_sp<SkImageFilter> input,
- const CropRect* cropRect = nullptr) {
- if (radiusX < 0 || radiusY < 0) {
- return nullptr;
- }
- return sk_sp<SkImageFilter>(new SkDilateImageFilter(radiusX, radiusY,
- std::move(input),
- cropRect));
- }
+ const CropRect* cropRect = nullptr);
SK_TO_STRING_OVERRIDE()
SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkDilateImageFilter)
@@ -96,14 +89,7 @@ class SK_API SkErodeImageFilter : public SkMorphologyImageFilter {
public:
static sk_sp<SkImageFilter> Make(int radiusX, int radiusY,
sk_sp<SkImageFilter> input,
- const CropRect* cropRect = nullptr) {
- if (radiusX < 0 || radiusY < 0) {
- return nullptr;
- }
- return sk_sp<SkImageFilter>(new SkErodeImageFilter(radiusX, radiusY,
- std::move(input),
- cropRect));
- }
+ const CropRect* cropRect = nullptr);
SK_TO_STRING_OVERRIDE()
SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkErodeImageFilter)
« no previous file with comments | « include/effects/SkMergeImageFilter.h ('k') | include/effects/SkOffsetImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698