Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: include/effects/SkOffsetImageFilter.h

Issue 1893973002: Outline SkImageFilter Make methods (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: update to ToT Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/effects/SkMorphologyImageFilter.h ('k') | include/effects/SkPaintImageFilter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/effects/SkOffsetImageFilter.h
diff --git a/include/effects/SkOffsetImageFilter.h b/include/effects/SkOffsetImageFilter.h
index cf2ff96ada5369f9f90c36c2d213225b2ae3a3fd..c1005ef78081797340b39010d8eb3bb359e3da36 100644
--- a/include/effects/SkOffsetImageFilter.h
+++ b/include/effects/SkOffsetImageFilter.h
@@ -15,13 +15,7 @@ class SK_API SkOffsetImageFilter : public SkImageFilter {
public:
static sk_sp<SkImageFilter> Make(SkScalar dx, SkScalar dy,
sk_sp<SkImageFilter> input,
- const CropRect* cropRect = nullptr) {
- if (!SkScalarIsFinite(dx) || !SkScalarIsFinite(dy)) {
- return nullptr;
- }
-
- return sk_sp<SkImageFilter>(new SkOffsetImageFilter(dx, dy, std::move(input), cropRect));
- }
+ const CropRect* cropRect = nullptr);
SkRect computeFastBounds(const SkRect& src) const override;
« no previous file with comments | « include/effects/SkMorphologyImageFilter.h ('k') | include/effects/SkPaintImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698