DevTools: Attach all Service Workers except for old redundant ones.

DevTools: Attach all Service Workers except for old redundant workers.

DevTools will attach all SWs in best mathcing scopes.
But redundant workers will be detached when new worker is installed.

BUG=601263
Committed: https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b
Cr-Commit-Position: refs/heads/master@{#388987}

[horo, 2016-04-21 06:21:24]

Patchset #2 (id:20001) has been deleted

[horo, 2016-04-21 06:21:29]

Patchset #1 (id:1) has been deleted

[horo, 2016-04-21 06:52:12]

Patchset #1 (id:40001) has been deleted

[horo, 2016-04-21 06:59:07]

Description was changed from

==========
active

BUG=
==========

to

==========
DevTools: Attach all Service Workers except for old redundant workers.

DevTools will attach all SWs in the scope.
But redundant workers will be detached when new worker is installed.

BUG=601263
==========

[horo, 2016-04-21 07:02:25]

Patchset #1 (id:60001) has been deleted

[horo, 2016-04-21 08:50:40]

Description was changed from

==========
DevTools: Attach all Service Workers except for old redundant workers.

DevTools will attach all SWs in the scope.
But redundant workers will be detached when new worker is installed.

BUG=601263
==========

to

==========
DevTools: Attach all Service Workers except for old redundant workers.

DevTools will attach all SWs in best mathcing scopes.
But redundant workers will be detached when new worker is installed.

BUG=601263
==========

[horo, 2016-04-21 08:51:05]

Patchset #1 (id:80001) has been deleted

[horo, 2016-04-21 10:32:34]

Patchset #1 (id:100001) has been deleted

[horo, 2016-04-21 10:33:39]

horo@chromium.org changed reviewers:
+ pfeldman@chromium.org

[horo, 2016-04-21 10:33:39]

pfeldman@
Could you please review this?

[pfeldman, 2016-04-21 21:13:20]

lgtm

https://codereview.chromium.org/1893313007/diff/120001/content/browser/devtoo...
File content/browser/devtools/protocol/service_worker_handler.cc (right):

https://codereview.chromium.org/1893313007/diff/120001/content/browser/devtoo...
content/browser/devtools/protocol/service_worker_handler.cc:143: void
GetHostnameMatchingScopeAgentsMap(
GetHostname seems to be a bad prefix - you don't return hostname...
GetMatchingHostsByScopeMap?

https://codereview.chromium.org/1893313007/diff/120001/content/browser/devtoo...
content/browser/devtools/protocol/service_worker_handler.cc:172: const bool
scope_matched = ServiceWorkerUtils::ScopeMatches(it.first, url);
Is there a reason to proceed with the hosts that did not match scope at all?

[horo, 2016-04-21 23:11:21]

Thank you!

https://codereview.chromium.org/1893313007/diff/120001/content/browser/devtoo...
File content/browser/devtools/protocol/service_worker_handler.cc (right):

https://codereview.chromium.org/1893313007/diff/120001/content/browser/devtoo...
content/browser/devtools/protocol/service_worker_handler.cc:143: void
GetHostnameMatchingScopeAgentsMap(
On 2016/04/21 21:13:20, pfeldman wrote:
> GetHostname seems to be a bad prefix - you don't return hostname...
> GetMatchingHostsByScopeMap?

Done.

https://codereview.chromium.org/1893313007/diff/120001/content/browser/devtoo...
content/browser/devtools/protocol/service_worker_handler.cc:172: const bool
scope_matched = ServiceWorkerUtils::ScopeMatches(it.first, url);
On 2016/04/21 21:13:20, pfeldman wrote:
> Is there a reason to proceed with the hosts that did not match scope at all?

Done.

[horo, 2016-04-21 23:11:35]

The CQ bit was checked by horo@chromium.org

[horo, 2016-04-21 23:11:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1893313007/#ps140001
(title: "incorporated pfeldman's comment")

[commit-bot: I haz the power, 2016-04-21 23:11:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893313007/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893313007/140001

[commit-bot: I haz the power, 2016-04-22 01:00:09]

Description was changed from

==========
DevTools: Attach all Service Workers except for old redundant workers.

DevTools will attach all SWs in best mathcing scopes.
But redundant workers will be detached when new worker is installed.

BUG=601263
==========

to

==========
DevTools: Attach all Service Workers except for old redundant workers.

DevTools will attach all SWs in best mathcing scopes.
But redundant workers will be detached when new worker is installed.

BUG=601263
==========

[commit-bot: I haz the power, 2016-04-22 01:00:11]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2016-04-22 19:42:54]

Description was changed from

==========
DevTools: Attach all Service Workers except for old redundant workers.

DevTools will attach all SWs in best mathcing scopes.
But redundant workers will be detached when new worker is installed.

BUG=601263
==========

to

==========
DevTools: Attach all Service Workers except for old redundant workers.

DevTools will attach all SWs in best mathcing scopes.
But redundant workers will be detached when new worker is installed.

BUG=601263

Committed: https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b
Cr-Commit-Position: refs/heads/master@{#388987}
==========

[commit-bot: I haz the power, 2016-04-22 19:42:55]

Patchset 2 (id:??) landed as
https://crrev.com/3afce45806e538c59e51fe46bf392477a044414b
Cr-Commit-Position: refs/heads/master@{#388987}