Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: content/browser/devtools/service_worker_devtools_manager.cc

Issue 1893313007: DevTools: Attach all Service Workers except for old redundant ones. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated pfeldman's comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/service_worker_devtools_manager.cc
diff --git a/content/browser/devtools/service_worker_devtools_manager.cc b/content/browser/devtools/service_worker_devtools_manager.cc
index 6796b71db69fbbdeb9f7ea9b4618b367127d2d0f..2afa2ca11c83cb508a3d09cee20b583d8cf16c56 100644
--- a/content/browser/devtools/service_worker_devtools_manager.cc
+++ b/content/browser/devtools/service_worker_devtools_manager.cc
@@ -78,14 +78,15 @@ void ServiceWorkerDevToolsManager::AddAllAgentHostsForBrowserContext(
bool ServiceWorkerDevToolsManager::WorkerCreated(
int worker_process_id,
int worker_route_id,
- const ServiceWorkerIdentifier& service_worker_id) {
+ const ServiceWorkerIdentifier& service_worker_id,
+ bool is_installed_version) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
const WorkerId id(worker_process_id, worker_route_id);
AgentHostMap::iterator it = FindExistingWorkerAgentHost(service_worker_id);
if (it == workers_.end()) {
scoped_refptr<ServiceWorkerDevToolsAgentHost> host =
- new ServiceWorkerDevToolsAgentHost(
- id, service_worker_id);
+ new ServiceWorkerDevToolsAgentHost(id, service_worker_id,
+ is_installed_version);
workers_[id] = host.get();
FOR_EACH_OBSERVER(Observer, observer_list_, WorkerCreated(host.get()));
if (debug_service_worker_on_start_)
@@ -122,6 +123,31 @@ void ServiceWorkerDevToolsManager::WorkerReadyForInspection(
}
}
+void ServiceWorkerDevToolsManager::WorkerVersionInstalled(int worker_process_id,
+ int worker_route_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ const WorkerId id(worker_process_id, worker_route_id);
+ AgentHostMap::iterator it = workers_.find(id);
+ if (it == workers_.end())
+ return;
+ scoped_refptr<ServiceWorkerDevToolsAgentHost> host = it->second;
+ host->WorkerVersionInstalled();
+ FOR_EACH_OBSERVER(Observer, observer_list_,
+ WorkerVersionInstalled(host.get()));
+}
+
+void ServiceWorkerDevToolsManager::WorkerVersionDoomed(int worker_process_id,
+ int worker_route_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ const WorkerId id(worker_process_id, worker_route_id);
+ AgentHostMap::iterator it = workers_.find(id);
+ if (it == workers_.end())
+ return;
+ scoped_refptr<ServiceWorkerDevToolsAgentHost> host = it->second;
+ host->WorkerVersionDoomed();
+ FOR_EACH_OBSERVER(Observer, observer_list_, WorkerVersionDoomed(host.get()));
+}
+
void ServiceWorkerDevToolsManager::WorkerStopIgnored(int worker_process_id,
int worker_route_id) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
« no previous file with comments | « content/browser/devtools/service_worker_devtools_manager.h ('k') | content/browser/service_worker/embedded_worker_instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698