content/browser/devtools/service_worker_devtools_manager.h - Issue 1893313007: DevTools: Attach all Service Workers except for old redundant ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/service_worker_devtools_manager.h

Issue 1893313007: DevTools: Attach all Service Workers except for old redundant ones. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated pfeldman's comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/service_worker_devtools_agent_host.cc ('k') | content/browser/devtools/service_worker_devtools_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/service_worker_devtools_manager.h

diff --git a/content/browser/devtools/service_worker_devtools_manager.h b/content/browser/devtools/service_worker_devtools_manager.h

index c2cd08e11cc5e932882f0479f6f376abc4a8e040..000c7de219d4ee44f65702b8818272fa74395779 100644

--- a/content/browser/devtools/service_worker_devtools_manager.h

+++ b/content/browser/devtools/service_worker_devtools_manager.h

@@ -34,6 +34,8 @@ class CONTENT_EXPORT ServiceWorkerDevToolsManager {

virtual void WorkerCreated(ServiceWorkerDevToolsAgentHost* host) {}

virtual void WorkerReadyForInspection(

ServiceWorkerDevToolsAgentHost* host) {}

+ virtual void WorkerVersionInstalled(ServiceWorkerDevToolsAgentHost* host) {}

+ virtual void WorkerVersionDoomed(ServiceWorkerDevToolsAgentHost* host) {}

virtual void WorkerDestroyed(ServiceWorkerDevToolsAgentHost* host) {}

protected:

@@ -85,8 +87,11 @@ class CONTENT_EXPORT ServiceWorkerDevToolsManager {

// debug-on-start is enabled in chrome://serviceworker-internals.

bool WorkerCreated(int worker_process_id,

int worker_route_id,

- const ServiceWorkerIdentifier& service_worker_id);

+ const ServiceWorkerIdentifier& service_worker_id,

+ bool is_installed_version);

void WorkerReadyForInspection(int worker_process_id, int worker_route_id);

+ void WorkerVersionInstalled(int worker_process_id, int worker_route_id);

+ void WorkerVersionDoomed(int worker_process_id, int worker_route_id);

void WorkerStopIgnored(int worker_process_id, int worker_route_id);

void WorkerDestroyed(int worker_process_id, int worker_route_id);

void RemoveInspectedWorkerData(WorkerId id);