Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: content/browser/devtools/service_worker_devtools_agent_host.h

Issue 1893313007: DevTools: Attach all Service Workers except for old redundant ones. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated pfeldman's comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/service_worker_devtools_agent_host.h
diff --git a/content/browser/devtools/service_worker_devtools_agent_host.h b/content/browser/devtools/service_worker_devtools_agent_host.h
index a758a043e083a0d04d5b91fae0be58cfdd2f1ed9..9ff92960d0a38a8e816e90e4d7e5281cf4c5a062 100644
--- a/content/browser/devtools/service_worker_devtools_agent_host.h
+++ b/content/browser/devtools/service_worker_devtools_agent_host.h
@@ -10,6 +10,7 @@
#include <map>
#include "base/macros.h"
+#include "base/time/time.h"
#include "content/browser/devtools/protocol/network_handler.h"
#include "content/browser/devtools/service_worker_devtools_manager.h"
#include "content/browser/devtools/worker_devtools_agent_host.h"
@@ -25,7 +26,8 @@ class ServiceWorkerDevToolsAgentHost : public WorkerDevToolsAgentHost {
ServiceWorkerDevToolsManager::ServiceWorkerIdentifier;
ServiceWorkerDevToolsAgentHost(WorkerId worker_id,
- const ServiceWorkerIdentifier& service_worker);
+ const ServiceWorkerIdentifier& service_worker,
+ bool is_installed_version);
void UnregisterWorker();
@@ -39,15 +41,28 @@ class ServiceWorkerDevToolsAgentHost : public WorkerDevToolsAgentHost {
// WorkerDevToolsAgentHost overrides.
void OnAttachedStateChanged(bool attached) override;
+ void WorkerVersionInstalled();
+ void WorkerVersionDoomed();
+
int64_t service_worker_version_id() const;
GURL scope() const;
+ // If the ServiceWorker has been installed before the worker instance started,
+ // it returns the time when the instance started. Otherwise returns the time
+ // when the ServiceWorker was installed.
+ base::Time version_installed_time() const { return version_installed_time_; }
+
+ // Returns the time when the ServiceWorker was doomed.
+ base::Time version_doomed_time() const { return version_doomed_time_; }
+
bool Matches(const ServiceWorkerIdentifier& other);
private:
~ServiceWorkerDevToolsAgentHost() override;
std::unique_ptr<ServiceWorkerIdentifier> service_worker_;
std::unique_ptr<devtools::network::NetworkHandler> network_handler_;
+ base::Time version_installed_time_;
+ base::Time version_doomed_time_;
DISALLOW_COPY_AND_ASSIGN(ServiceWorkerDevToolsAgentHost);
};

Powered by Google App Engine
This is Rietveld 408576698