Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: content/browser/devtools/service_worker_devtools_agent_host.cc

Issue 1893313007: DevTools: Attach all Service Workers except for old redundant ones. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated pfeldman's comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/service_worker_devtools_agent_host.cc
diff --git a/content/browser/devtools/service_worker_devtools_agent_host.cc b/content/browser/devtools/service_worker_devtools_agent_host.cc
index 33293d52e5bd9c2465b0648a00a60c33dc9c1f06..d44ea7e1e70ba0eaeeb87b7bf0c94ced22edb672 100644
--- a/content/browser/devtools/service_worker_devtools_agent_host.cc
+++ b/content/browser/devtools/service_worker_devtools_agent_host.cc
@@ -54,10 +54,13 @@ void SetDevToolsAttachedOnIO(
ServiceWorkerDevToolsAgentHost::ServiceWorkerDevToolsAgentHost(
WorkerId worker_id,
- const ServiceWorkerIdentifier& service_worker)
+ const ServiceWorkerIdentifier& service_worker,
+ bool is_installed_version)
: WorkerDevToolsAgentHost(worker_id),
service_worker_(new ServiceWorkerIdentifier(service_worker)),
- network_handler_(new devtools::network::NetworkHandler()) {
+ network_handler_(new devtools::network::NetworkHandler()),
+ version_installed_time_(is_installed_version ? base::Time::Now()
+ : base::Time()) {
DevToolsProtocolDispatcher* dispatcher = protocol_handler()->dispatcher();
dispatcher->SetNetworkHandler(network_handler_.get());
}
@@ -105,6 +108,14 @@ void ServiceWorkerDevToolsAgentHost::OnAttachedStateChanged(bool attached) {
attached));
}
+void ServiceWorkerDevToolsAgentHost::WorkerVersionInstalled() {
+ version_installed_time_ = base::Time::Now();
+}
+
+void ServiceWorkerDevToolsAgentHost::WorkerVersionDoomed() {
+ version_doomed_time_ = base::Time::Now();
+}
+
int64_t ServiceWorkerDevToolsAgentHost::service_worker_version_id() const {
return service_worker_->version_id();
}

Powered by Google App Engine
This is Rietveld 408576698