Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1892323002: Change scoped_ptr to std::unique_ptr in //net/socket. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
Reviewers:
eroman, gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng, eroman, piman, agl
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change scoped_ptr to std::unique_ptr in //net/socket. R=gavinp@chromium.org BUG=554298 Committed: https://crrev.com/655b66c64362dbea1b7e27207545234f7b908106 Cr-Commit-Position: refs/heads/master@{#387770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+623 lines, -599 lines) Patch
M net/socket/client_socket_factory.h View 2 chunks +6 lines, -6 lines 0 comments Download
M net/socket/client_socket_factory.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M net/socket/client_socket_handle.h View 5 chunks +5 lines, -5 lines 0 comments Download
M net/socket/client_socket_handle.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/client_socket_pool.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 22 chunks +26 lines, -24 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 23 chunks +37 lines, -40 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 12 chunks +27 lines, -34 lines 0 comments Download
M net/socket/client_socket_pool_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_manager_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/socket/mock_client_socket_pool_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/mock_client_socket_pool_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/socket/nss_ssl_util.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/server_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/socket_net_log_params.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M net/socket/socket_posix.h View 5 chunks +6 lines, -5 lines 0 comments Download
M net/socket/socket_posix.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/socket_test_util.h View 11 chunks +20 lines, -17 lines 0 comments Download
M net/socket/socket_test_util.cc View 10 chunks +22 lines, -20 lines 0 comments Download
M net/socket/socks5_client_socket.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/socks5_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks5_client_socket_fuzzer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/socket/socks5_client_socket_unittest.cc View 3 chunks +15 lines, -14 lines 0 comments Download
M net/socket/socks_client_socket.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/socks_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket_fuzzer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/socket/socks_client_socket_pool.h View 5 chunks +6 lines, -6 lines 0 comments Download
M net/socket/socks_client_socket_pool.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M net/socket/socks_client_socket_pool_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/socket/socks_client_socket_unittest.cc View 7 chunks +18 lines, -16 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 4 chunks +4 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.h View 6 chunks +6 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 5 chunks +6 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 46 chunks +85 lines, -84 lines 0 comments Download
M net/socket/ssl_server_socket.h View 3 chunks +5 lines, -4 lines 0 comments Download
M net/socket/ssl_server_socket_nss.h View 3 chunks +5 lines, -4 lines 0 comments Download
M net/socket/ssl_server_socket_nss.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M net/socket/ssl_server_socket_openssl.h View 3 chunks +5 lines, -4 lines 0 comments Download
M net/socket/ssl_server_socket_openssl.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 4 chunks +18 lines, -15 lines 0 comments Download
M net/socket/tcp_client_socket.h View 3 chunks +6 lines, -5 lines 0 comments Download
M net/socket/tcp_client_socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/tcp_client_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/tcp_server_socket.h View 3 chunks +8 lines, -6 lines 0 comments Download
M net/socket/tcp_server_socket.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/socket/tcp_server_socket_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/socket/tcp_socket_posix.h View 6 chunks +12 lines, -11 lines 0 comments Download
M net/socket/tcp_socket_posix.cc View 4 chunks +12 lines, -10 lines 0 comments Download
M net/socket/tcp_socket_unittest.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M net/socket/tcp_socket_win.h View 6 chunks +11 lines, -9 lines 0 comments Download
M net/socket/tcp_socket_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/socket/transport_client_socket_pool.h View 5 chunks +7 lines, -7 lines 0 comments Download
M net/socket/transport_client_socket_pool.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M net/socket/transport_client_socket_pool_test_util.h View 2 chunks +7 lines, -6 lines 0 comments Download
M net/socket/transport_client_socket_pool_test_util.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M net/socket/transport_client_socket_pool_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/transport_client_socket_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/socket/unix_domain_client_socket_posix.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/unix_domain_client_socket_posix.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/socket/unix_domain_client_socket_posix_unittest.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M net/socket/unix_domain_server_socket_posix.h View 4 chunks +5 lines, -5 lines 0 comments Download
M net/socket/unix_domain_server_socket_posix.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/socket/unix_domain_server_socket_posix_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/websocket_endpoint_lock_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/websocket_transport_client_socket_pool.h View 5 chunks +7 lines, -7 lines 0 comments Download
M net/socket/websocket_transport_client_socket_pool.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M net/socket/websocket_transport_client_socket_pool_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/websocket_transport_connect_sub_job.h View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
danakj
4 years, 8 months ago (2016-04-15 22:43:49 UTC) #2
eroman
lgtm
4 years, 8 months ago (2016-04-15 22:46:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892323002/1
4 years, 8 months ago (2016-04-15 22:48:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/173158)
4 years, 8 months ago (2016-04-15 23:11:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892323002/1
4 years, 8 months ago (2016-04-15 23:15:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 00:51:53 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 00:53:55 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/655b66c64362dbea1b7e27207545234f7b908106
Cr-Commit-Position: refs/heads/master@{#387770}

Powered by Google App Engine
This is Rietveld 408576698