Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: net/socket/socket_test_util.cc

Issue 1892323002: Change scoped_ptr to std::unique_ptr in //net/socket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/socket_test_util.h ('k') | net/socket/socks5_client_socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.cc
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index 9c99cef509dde339f209af5b257fafd7f73d3f11..8068a11daa9c836fd12620eb46d826d62bbd6b25 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -13,6 +13,7 @@
#include "base/compiler_specific.h"
#include "base/location.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
#include "base/thread_task_runner_handle.h"
@@ -710,14 +711,14 @@ void MockClientSocketFactory::ResetNextMockIndexes() {
mock_ssl_data_.ResetNextIndex();
}
-scoped_ptr<DatagramClientSocket>
+std::unique_ptr<DatagramClientSocket>
MockClientSocketFactory::CreateDatagramClientSocket(
DatagramSocket::BindType bind_type,
const RandIntCallback& rand_int_cb,
NetLog* net_log,
const NetLog::Source& source) {
SocketDataProvider* data_provider = mock_data_.GetNext();
- scoped_ptr<MockUDPClientSocket> socket(
+ std::unique_ptr<MockUDPClientSocket> socket(
new MockUDPClientSocket(data_provider, net_log));
if (bind_type == DatagramSocket::RANDOM_BIND)
socket->set_source_port(
@@ -726,19 +727,20 @@ MockClientSocketFactory::CreateDatagramClientSocket(
return std::move(socket);
}
-scoped_ptr<StreamSocket> MockClientSocketFactory::CreateTransportClientSocket(
+std::unique_ptr<StreamSocket>
+MockClientSocketFactory::CreateTransportClientSocket(
const AddressList& addresses,
- scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher,
+ std::unique_ptr<SocketPerformanceWatcher> socket_performance_watcher,
NetLog* net_log,
const NetLog::Source& source) {
SocketDataProvider* data_provider = mock_data_.GetNext();
- scoped_ptr<MockTCPClientSocket> socket(
+ std::unique_ptr<MockTCPClientSocket> socket(
new MockTCPClientSocket(addresses, net_log, data_provider));
return std::move(socket);
}
-scoped_ptr<SSLClientSocket> MockClientSocketFactory::CreateSSLClientSocket(
- scoped_ptr<ClientSocketHandle> transport_socket,
+std::unique_ptr<SSLClientSocket> MockClientSocketFactory::CreateSSLClientSocket(
+ std::unique_ptr<ClientSocketHandle> transport_socket,
const HostPortPair& host_and_port,
const SSLConfig& ssl_config,
const SSLClientSocketContext& context) {
@@ -751,7 +753,7 @@ scoped_ptr<SSLClientSocket> MockClientSocketFactory::CreateSSLClientSocket(
next_ssl_data->next_protos_expected_in_ssl_config.end(),
ssl_config.alpn_protos.begin()));
}
- return scoped_ptr<SSLClientSocket>(new MockSSLClientSocket(
+ return std::unique_ptr<SSLClientSocket>(new MockSSLClientSocket(
std::move(transport_socket), host_and_port, ssl_config, next_ssl_data));
}
@@ -1138,15 +1140,14 @@ void MockSSLClientSocket::ConnectCallback(
}
MockSSLClientSocket::MockSSLClientSocket(
- scoped_ptr<ClientSocketHandle> transport_socket,
+ std::unique_ptr<ClientSocketHandle> transport_socket,
const HostPortPair& host_port_pair,
const SSLConfig& ssl_config,
SSLSocketDataProvider* data)
: MockClientSocket(
// Have to use the right BoundNetLog for LoadTimingInfo regression
// tests.
- transport_socket->socket()
- ->NetLog()),
+ transport_socket->socket()->NetLog()),
transport_(std::move(transport_socket)),
data_(data) {
DCHECK(data_);
@@ -1525,7 +1526,7 @@ int ClientSocketPoolTest::GetOrderOfRequest(size_t index) const {
}
bool ClientSocketPoolTest::ReleaseOneConnection(KeepAlive keep_alive) {
- for (scoped_ptr<TestSocketRequest>& it : requests_) {
+ for (std::unique_ptr<TestSocketRequest>& it : requests_) {
if (it->handle()->is_initialized()) {
if (keep_alive == NO_KEEP_ALIVE)
it->handle()->socket()->Disconnect();
@@ -1545,7 +1546,7 @@ void ClientSocketPoolTest::ReleaseAllConnections(KeepAlive keep_alive) {
}
MockTransportClientSocketPool::MockConnectJob::MockConnectJob(
- scoped_ptr<StreamSocket> socket,
+ std::unique_ptr<StreamSocket> socket,
ClientSocketHandle* handle,
const CompletionCallback& callback)
: socket_(std::move(socket)), handle_(handle), user_callback_(callback) {}
@@ -1631,18 +1632,18 @@ int MockTransportClientSocketPool::RequestSocket(
const CompletionCallback& callback,
const BoundNetLog& net_log) {
last_request_priority_ = priority;
- scoped_ptr<StreamSocket> socket =
+ std::unique_ptr<StreamSocket> socket =
client_socket_factory_->CreateTransportClientSocket(
AddressList(), NULL, net_log.net_log(), NetLog::Source());
MockConnectJob* job = new MockConnectJob(std::move(socket), handle, callback);
- job_list_.push_back(make_scoped_ptr(job));
+ job_list_.push_back(base::WrapUnique(job));
handle->set_pool_id(1);
return job->Connect();
}
void MockTransportClientSocketPool::CancelRequest(const std::string& group_name,
ClientSocketHandle* handle) {
- for (scoped_ptr<MockConnectJob>& it : job_list_) {
+ for (std::unique_ptr<MockConnectJob>& it : job_list_) {
if (it->CancelHandle(handle)) {
cancel_count_++;
break;
@@ -1652,7 +1653,7 @@ void MockTransportClientSocketPool::CancelRequest(const std::string& group_name,
void MockTransportClientSocketPool::ReleaseSocket(
const std::string& group_name,
- scoped_ptr<StreamSocket> socket,
+ std::unique_ptr<StreamSocket> socket,
int id) {
EXPECT_EQ(1, id);
release_count_++;
@@ -1690,9 +1691,10 @@ void MockSOCKSClientSocketPool::CancelRequest(
return transport_pool_->CancelRequest(group_name, handle);
}
-void MockSOCKSClientSocketPool::ReleaseSocket(const std::string& group_name,
- scoped_ptr<StreamSocket> socket,
- int id) {
+void MockSOCKSClientSocketPool::ReleaseSocket(
+ const std::string& group_name,
+ std::unique_ptr<StreamSocket> socket,
+ int id) {
return transport_pool_->ReleaseSocket(group_name, std::move(socket), id);
}
« no previous file with comments | « net/socket/socket_test_util.h ('k') | net/socket/socks5_client_socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698