Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: net/socket/tcp_server_socket_unittest.cc

Issue 1892323002: Change scoped_ptr to std::unique_ptr in //net/socket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/socket/tcp_server_socket.cc ('k') | net/socket/tcp_socket_posix.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/tcp_server_socket.h" 5 #include "net/socket/tcp_server_socket.h"
6 6
7 #include <memory>
7 #include <string> 8 #include <string>
8 #include <vector> 9 #include <vector>
9 10
10 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
11 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
12 #include "base/memory/scoped_ptr.h"
13 #include "net/base/address_list.h" 13 #include "net/base/address_list.h"
14 #include "net/base/io_buffer.h" 14 #include "net/base/io_buffer.h"
15 #include "net/base/ip_address.h" 15 #include "net/base/ip_address.h"
16 #include "net/base/ip_endpoint.h" 16 #include "net/base/ip_endpoint.h"
17 #include "net/base/net_errors.h" 17 #include "net/base/net_errors.h"
18 #include "net/base/test_completion_callback.h" 18 #include "net/base/test_completion_callback.h"
19 #include "net/socket/tcp_client_socket.h" 19 #include "net/socket/tcp_client_socket.h"
20 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
21 #include "testing/platform_test.h" 21 #include "testing/platform_test.h"
22 22
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 65
66 TEST_F(TCPServerSocketTest, Accept) { 66 TEST_F(TCPServerSocketTest, Accept) {
67 ASSERT_NO_FATAL_FAILURE(SetUpIPv4()); 67 ASSERT_NO_FATAL_FAILURE(SetUpIPv4());
68 68
69 TestCompletionCallback connect_callback; 69 TestCompletionCallback connect_callback;
70 TCPClientSocket connecting_socket(local_address_list(), NULL, NULL, 70 TCPClientSocket connecting_socket(local_address_list(), NULL, NULL,
71 NetLog::Source()); 71 NetLog::Source());
72 connecting_socket.Connect(connect_callback.callback()); 72 connecting_socket.Connect(connect_callback.callback());
73 73
74 TestCompletionCallback accept_callback; 74 TestCompletionCallback accept_callback;
75 scoped_ptr<StreamSocket> accepted_socket; 75 std::unique_ptr<StreamSocket> accepted_socket;
76 int result = socket_.Accept(&accepted_socket, accept_callback.callback()); 76 int result = socket_.Accept(&accepted_socket, accept_callback.callback());
77 if (result == ERR_IO_PENDING) 77 if (result == ERR_IO_PENDING)
78 result = accept_callback.WaitForResult(); 78 result = accept_callback.WaitForResult();
79 ASSERT_EQ(OK, result); 79 ASSERT_EQ(OK, result);
80 80
81 ASSERT_TRUE(accepted_socket.get() != NULL); 81 ASSERT_TRUE(accepted_socket.get() != NULL);
82 82
83 // Both sockets should be on the loopback network interface. 83 // Both sockets should be on the loopback network interface.
84 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), 84 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(),
85 local_address_.address()); 85 local_address_.address());
86 86
87 EXPECT_EQ(OK, connect_callback.WaitForResult()); 87 EXPECT_EQ(OK, connect_callback.WaitForResult());
88 } 88 }
89 89
90 // Test Accept() callback. 90 // Test Accept() callback.
91 TEST_F(TCPServerSocketTest, AcceptAsync) { 91 TEST_F(TCPServerSocketTest, AcceptAsync) {
92 ASSERT_NO_FATAL_FAILURE(SetUpIPv4()); 92 ASSERT_NO_FATAL_FAILURE(SetUpIPv4());
93 93
94 TestCompletionCallback accept_callback; 94 TestCompletionCallback accept_callback;
95 scoped_ptr<StreamSocket> accepted_socket; 95 std::unique_ptr<StreamSocket> accepted_socket;
96 96
97 ASSERT_EQ(ERR_IO_PENDING, 97 ASSERT_EQ(ERR_IO_PENDING,
98 socket_.Accept(&accepted_socket, accept_callback.callback())); 98 socket_.Accept(&accepted_socket, accept_callback.callback()));
99 99
100 TestCompletionCallback connect_callback; 100 TestCompletionCallback connect_callback;
101 TCPClientSocket connecting_socket(local_address_list(), NULL, NULL, 101 TCPClientSocket connecting_socket(local_address_list(), NULL, NULL,
102 NetLog::Source()); 102 NetLog::Source());
103 connecting_socket.Connect(connect_callback.callback()); 103 connecting_socket.Connect(connect_callback.callback());
104 104
105 EXPECT_EQ(OK, connect_callback.WaitForResult()); 105 EXPECT_EQ(OK, connect_callback.WaitForResult());
106 EXPECT_EQ(OK, accept_callback.WaitForResult()); 106 EXPECT_EQ(OK, accept_callback.WaitForResult());
107 107
108 EXPECT_TRUE(accepted_socket != NULL); 108 EXPECT_TRUE(accepted_socket != NULL);
109 109
110 // Both sockets should be on the loopback network interface. 110 // Both sockets should be on the loopback network interface.
111 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), 111 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(),
112 local_address_.address()); 112 local_address_.address());
113 } 113 }
114 114
115 // Accept two connections simultaneously. 115 // Accept two connections simultaneously.
116 TEST_F(TCPServerSocketTest, Accept2Connections) { 116 TEST_F(TCPServerSocketTest, Accept2Connections) {
117 ASSERT_NO_FATAL_FAILURE(SetUpIPv4()); 117 ASSERT_NO_FATAL_FAILURE(SetUpIPv4());
118 118
119 TestCompletionCallback accept_callback; 119 TestCompletionCallback accept_callback;
120 scoped_ptr<StreamSocket> accepted_socket; 120 std::unique_ptr<StreamSocket> accepted_socket;
121 121
122 ASSERT_EQ(ERR_IO_PENDING, 122 ASSERT_EQ(ERR_IO_PENDING,
123 socket_.Accept(&accepted_socket, accept_callback.callback())); 123 socket_.Accept(&accepted_socket, accept_callback.callback()));
124 124
125 TestCompletionCallback connect_callback; 125 TestCompletionCallback connect_callback;
126 TCPClientSocket connecting_socket(local_address_list(), NULL, NULL, 126 TCPClientSocket connecting_socket(local_address_list(), NULL, NULL,
127 NetLog::Source()); 127 NetLog::Source());
128 connecting_socket.Connect(connect_callback.callback()); 128 connecting_socket.Connect(connect_callback.callback());
129 129
130 TestCompletionCallback connect_callback2; 130 TestCompletionCallback connect_callback2;
131 TCPClientSocket connecting_socket2(local_address_list(), NULL, NULL, 131 TCPClientSocket connecting_socket2(local_address_list(), NULL, NULL,
132 NetLog::Source()); 132 NetLog::Source());
133 connecting_socket2.Connect(connect_callback2.callback()); 133 connecting_socket2.Connect(connect_callback2.callback());
134 134
135 EXPECT_EQ(OK, accept_callback.WaitForResult()); 135 EXPECT_EQ(OK, accept_callback.WaitForResult());
136 136
137 TestCompletionCallback accept_callback2; 137 TestCompletionCallback accept_callback2;
138 scoped_ptr<StreamSocket> accepted_socket2; 138 std::unique_ptr<StreamSocket> accepted_socket2;
139 int result = socket_.Accept(&accepted_socket2, accept_callback2.callback()); 139 int result = socket_.Accept(&accepted_socket2, accept_callback2.callback());
140 if (result == ERR_IO_PENDING) 140 if (result == ERR_IO_PENDING)
141 result = accept_callback2.WaitForResult(); 141 result = accept_callback2.WaitForResult();
142 ASSERT_EQ(OK, result); 142 ASSERT_EQ(OK, result);
143 143
144 EXPECT_EQ(OK, connect_callback.WaitForResult()); 144 EXPECT_EQ(OK, connect_callback.WaitForResult());
145 145
146 EXPECT_TRUE(accepted_socket != NULL); 146 EXPECT_TRUE(accepted_socket != NULL);
147 EXPECT_TRUE(accepted_socket2 != NULL); 147 EXPECT_TRUE(accepted_socket2 != NULL);
148 EXPECT_NE(accepted_socket.get(), accepted_socket2.get()); 148 EXPECT_NE(accepted_socket.get(), accepted_socket2.get());
149 149
150 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), 150 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(),
151 local_address_.address()); 151 local_address_.address());
152 EXPECT_EQ(GetPeerAddress(accepted_socket2.get()).address(), 152 EXPECT_EQ(GetPeerAddress(accepted_socket2.get()).address(),
153 local_address_.address()); 153 local_address_.address());
154 } 154 }
155 155
156 TEST_F(TCPServerSocketTest, AcceptIPv6) { 156 TEST_F(TCPServerSocketTest, AcceptIPv6) {
157 bool initialized = false; 157 bool initialized = false;
158 ASSERT_NO_FATAL_FAILURE(SetUpIPv6(&initialized)); 158 ASSERT_NO_FATAL_FAILURE(SetUpIPv6(&initialized));
159 if (!initialized) 159 if (!initialized)
160 return; 160 return;
161 161
162 TestCompletionCallback connect_callback; 162 TestCompletionCallback connect_callback;
163 TCPClientSocket connecting_socket(local_address_list(), NULL, NULL, 163 TCPClientSocket connecting_socket(local_address_list(), NULL, NULL,
164 NetLog::Source()); 164 NetLog::Source());
165 connecting_socket.Connect(connect_callback.callback()); 165 connecting_socket.Connect(connect_callback.callback());
166 166
167 TestCompletionCallback accept_callback; 167 TestCompletionCallback accept_callback;
168 scoped_ptr<StreamSocket> accepted_socket; 168 std::unique_ptr<StreamSocket> accepted_socket;
169 int result = socket_.Accept(&accepted_socket, accept_callback.callback()); 169 int result = socket_.Accept(&accepted_socket, accept_callback.callback());
170 if (result == ERR_IO_PENDING) 170 if (result == ERR_IO_PENDING)
171 result = accept_callback.WaitForResult(); 171 result = accept_callback.WaitForResult();
172 ASSERT_EQ(OK, result); 172 ASSERT_EQ(OK, result);
173 173
174 ASSERT_TRUE(accepted_socket.get() != NULL); 174 ASSERT_TRUE(accepted_socket.get() != NULL);
175 175
176 // Both sockets should be on the loopback network interface. 176 // Both sockets should be on the loopback network interface.
177 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), 177 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(),
178 local_address_.address()); 178 local_address_.address());
179 179
180 EXPECT_EQ(OK, connect_callback.WaitForResult()); 180 EXPECT_EQ(OK, connect_callback.WaitForResult());
181 } 181 }
182 182
183 TEST_F(TCPServerSocketTest, AcceptIO) { 183 TEST_F(TCPServerSocketTest, AcceptIO) {
184 ASSERT_NO_FATAL_FAILURE(SetUpIPv4()); 184 ASSERT_NO_FATAL_FAILURE(SetUpIPv4());
185 185
186 TestCompletionCallback connect_callback; 186 TestCompletionCallback connect_callback;
187 TCPClientSocket connecting_socket(local_address_list(), NULL, NULL, 187 TCPClientSocket connecting_socket(local_address_list(), NULL, NULL,
188 NetLog::Source()); 188 NetLog::Source());
189 connecting_socket.Connect(connect_callback.callback()); 189 connecting_socket.Connect(connect_callback.callback());
190 190
191 TestCompletionCallback accept_callback; 191 TestCompletionCallback accept_callback;
192 scoped_ptr<StreamSocket> accepted_socket; 192 std::unique_ptr<StreamSocket> accepted_socket;
193 int result = socket_.Accept(&accepted_socket, accept_callback.callback()); 193 int result = socket_.Accept(&accepted_socket, accept_callback.callback());
194 ASSERT_EQ(OK, accept_callback.GetResult(result)); 194 ASSERT_EQ(OK, accept_callback.GetResult(result));
195 195
196 ASSERT_TRUE(accepted_socket.get() != NULL); 196 ASSERT_TRUE(accepted_socket.get() != NULL);
197 197
198 // Both sockets should be on the loopback network interface. 198 // Both sockets should be on the loopback network interface.
199 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(), 199 EXPECT_EQ(GetPeerAddress(accepted_socket.get()).address(),
200 local_address_.address()); 200 local_address_.address());
201 201
202 EXPECT_EQ(OK, connect_callback.WaitForResult()); 202 EXPECT_EQ(OK, connect_callback.WaitForResult());
(...skipping 30 matching lines...) Expand all
233 bytes_read += read_result; 233 bytes_read += read_result;
234 } 234 }
235 235
236 std::string received_message(buffer.begin(), buffer.end()); 236 std::string received_message(buffer.begin(), buffer.end());
237 ASSERT_EQ(message, received_message); 237 ASSERT_EQ(message, received_message);
238 } 238 }
239 239
240 } // namespace 240 } // namespace
241 241
242 } // namespace net 242 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/tcp_server_socket.cc ('k') | net/socket/tcp_socket_posix.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698