Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: net/socket/ssl_client_socket_unittest.cc

Issue 1892323002: Change scoped_ptr to std::unique_ptr in //net/socket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/socket/ssl_server_socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_unittest.cc
diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc
index d95956bfa1a16eb6bacb0dd2f33f4b91f3b3da14..b30889999859b7d15f6be9378dabb5725c490eab 100644
--- a/net/socket/ssl_client_socket_unittest.cc
+++ b/net/socket/ssl_client_socket_unittest.cc
@@ -78,7 +78,7 @@ namespace {
// StreamSocket.
class WrappedStreamSocket : public StreamSocket {
public:
- explicit WrappedStreamSocket(scoped_ptr<StreamSocket> transport)
+ explicit WrappedStreamSocket(std::unique_ptr<StreamSocket> transport)
: transport_(std::move(transport)) {}
~WrappedStreamSocket() override {}
@@ -144,7 +144,7 @@ class WrappedStreamSocket : public StreamSocket {
}
protected:
- scoped_ptr<StreamSocket> transport_;
+ std::unique_ptr<StreamSocket> transport_;
};
// ReadBufferingStreamSocket is a wrapper for an existing StreamSocket that
@@ -155,7 +155,7 @@ class WrappedStreamSocket : public StreamSocket {
// them from the TestServer.
class ReadBufferingStreamSocket : public WrappedStreamSocket {
public:
- explicit ReadBufferingStreamSocket(scoped_ptr<StreamSocket> transport);
+ explicit ReadBufferingStreamSocket(std::unique_ptr<StreamSocket> transport);
~ReadBufferingStreamSocket() override {}
// Socket implementation:
@@ -193,7 +193,7 @@ class ReadBufferingStreamSocket : public WrappedStreamSocket {
};
ReadBufferingStreamSocket::ReadBufferingStreamSocket(
- scoped_ptr<StreamSocket> transport)
+ std::unique_ptr<StreamSocket> transport)
: WrappedStreamSocket(std::move(transport)),
read_buffer_(new GrowableIOBuffer()),
buffer_size_(0) {}
@@ -285,7 +285,8 @@ void ReadBufferingStreamSocket::OnReadCompleted(int result) {
// Simulates synchronously receiving an error during Read() or Write()
class SynchronousErrorStreamSocket : public WrappedStreamSocket {
public:
- explicit SynchronousErrorStreamSocket(scoped_ptr<StreamSocket> transport);
+ explicit SynchronousErrorStreamSocket(
+ std::unique_ptr<StreamSocket> transport);
~SynchronousErrorStreamSocket() override {}
// Socket implementation:
@@ -327,7 +328,7 @@ class SynchronousErrorStreamSocket : public WrappedStreamSocket {
};
SynchronousErrorStreamSocket::SynchronousErrorStreamSocket(
- scoped_ptr<StreamSocket> transport)
+ std::unique_ptr<StreamSocket> transport)
: WrappedStreamSocket(std::move(transport)),
have_read_error_(false),
pending_read_error_(OK),
@@ -356,7 +357,7 @@ int SynchronousErrorStreamSocket::Write(IOBuffer* buf,
// semantics).
class FakeBlockingStreamSocket : public WrappedStreamSocket {
public:
- explicit FakeBlockingStreamSocket(scoped_ptr<StreamSocket> transport);
+ explicit FakeBlockingStreamSocket(std::unique_ptr<StreamSocket> transport);
~FakeBlockingStreamSocket() override {}
// Socket implementation:
@@ -410,7 +411,7 @@ class FakeBlockingStreamSocket : public WrappedStreamSocket {
int pending_read_result_;
// WaitForReadResult() wait loop.
- scoped_ptr<base::RunLoop> read_loop_;
+ std::unique_ptr<base::RunLoop> read_loop_;
// True if write calls are blocked.
bool should_block_write_;
@@ -425,11 +426,11 @@ class FakeBlockingStreamSocket : public WrappedStreamSocket {
int pending_write_len_;
// WaitForWrite() wait loop.
- scoped_ptr<base::RunLoop> write_loop_;
+ std::unique_ptr<base::RunLoop> write_loop_;
};
FakeBlockingStreamSocket::FakeBlockingStreamSocket(
- scoped_ptr<StreamSocket> transport)
+ std::unique_ptr<StreamSocket> transport)
: WrappedStreamSocket(std::move(transport)),
should_block_read_(false),
pending_read_result_(ERR_IO_PENDING),
@@ -577,7 +578,7 @@ void FakeBlockingStreamSocket::OnReadCompleted(int result) {
// reads and writes on the socket.
class CountingStreamSocket : public WrappedStreamSocket {
public:
- explicit CountingStreamSocket(scoped_ptr<StreamSocket> transport)
+ explicit CountingStreamSocket(std::unique_ptr<StreamSocket> transport)
: WrappedStreamSocket(std::move(transport)),
read_count_(0),
write_count_(0) {}
@@ -638,11 +639,11 @@ class DeleteSocketCallback : public TestCompletionCallbackBase {
// channel id.
class FailingChannelIDStore : public ChannelIDStore {
int GetChannelID(const std::string& server_identifier,
- scoped_ptr<crypto::ECPrivateKey>* key_result,
+ std::unique_ptr<crypto::ECPrivateKey>* key_result,
const GetChannelIDCallback& callback) override {
return ERR_UNEXPECTED;
}
- void SetChannelID(scoped_ptr<ChannelID> channel_id) override {}
+ void SetChannelID(std::unique_ptr<ChannelID> channel_id) override {}
void DeleteChannelID(const std::string& server_identifier,
const base::Closure& completion_callback) override {}
void DeleteAllCreatedBetween(
@@ -660,14 +661,14 @@ class FailingChannelIDStore : public ChannelIDStore {
// channel id.
class AsyncFailingChannelIDStore : public ChannelIDStore {
int GetChannelID(const std::string& server_identifier,
- scoped_ptr<crypto::ECPrivateKey>* key_result,
+ std::unique_ptr<crypto::ECPrivateKey>* key_result,
const GetChannelIDCallback& callback) override {
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
base::Bind(callback, ERR_UNEXPECTED, server_identifier, nullptr));
return ERR_IO_PENDING;
}
- void SetChannelID(scoped_ptr<ChannelID> channel_id) override {}
+ void SetChannelID(std::unique_ptr<ChannelID> channel_id) override {}
void DeleteChannelID(const std::string& server_identifier,
const base::Closure& completion_callback) override {}
void DeleteAllCreatedBetween(
@@ -752,11 +753,11 @@ class SSLClientSocketTest : public PlatformTest {
return true;
}
- scoped_ptr<SSLClientSocket> CreateSSLClientSocket(
- scoped_ptr<StreamSocket> transport_socket,
+ std::unique_ptr<SSLClientSocket> CreateSSLClientSocket(
+ std::unique_ptr<StreamSocket> transport_socket,
const HostPortPair& host_and_port,
const SSLConfig& ssl_config) {
- scoped_ptr<ClientSocketHandle> connection(new ClientSocketHandle);
+ std::unique_ptr<ClientSocketHandle> connection(new ClientSocketHandle);
connection->SetSocket(std::move(transport_socket));
return socket_factory_->CreateSSLClientSocket(
std::move(connection), host_and_port, ssl_config, context_);
@@ -772,7 +773,7 @@ class SSLClientSocketTest : public PlatformTest {
// itself was a success.
bool CreateAndConnectSSLClientSocket(const SSLConfig& ssl_config,
int* result) {
- scoped_ptr<StreamSocket> transport(
+ std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr_, NULL, &log_, NetLog::Source()));
int rv = callback_.GetResult(transport->Connect(callback_.callback()));
if (rv != OK) {
@@ -805,14 +806,14 @@ class SSLClientSocketTest : public PlatformTest {
}
ClientSocketFactory* socket_factory_;
- scoped_ptr<MockCertVerifier> cert_verifier_;
- scoped_ptr<TransportSecurityState> transport_security_state_;
+ std::unique_ptr<MockCertVerifier> cert_verifier_;
+ std::unique_ptr<TransportSecurityState> transport_security_state_;
SSLClientSocketContext context_;
- scoped_ptr<SSLClientSocket> sock_;
+ std::unique_ptr<SSLClientSocket> sock_;
TestNetLog log_;
private:
- scoped_ptr<SpawnedTestServer> spawned_test_server_;
+ std::unique_ptr<SpawnedTestServer> spawned_test_server_;
TestCompletionCallback callback_;
AddressList addr_;
};
@@ -835,12 +836,12 @@ class SSLClientSocketCertRequestInfoTest : public SSLClientSocketTest {
TestCompletionCallback callback;
TestNetLog log;
- scoped_ptr<StreamSocket> transport(
+ std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr, NULL, &log, NetLog::Source()));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_EQ(OK, rv);
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server.host_port_pair(),
SSLConfig()));
EXPECT_FALSE(sock->IsConnected());
@@ -878,18 +879,18 @@ class SSLClientSocketFalseStartTest : public SSLClientSocketTest {
const SSLConfig& client_config,
TestCompletionCallback* callback,
FakeBlockingStreamSocket** out_raw_transport,
- scoped_ptr<SSLClientSocket>* out_sock) {
+ std::unique_ptr<SSLClientSocket>* out_sock) {
CHECK(spawned_test_server());
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
- scoped_ptr<FakeBlockingStreamSocket> transport(
+ std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(real_transport)));
int rv = callback->GetResult(transport->Connect(callback->callback()));
EXPECT_EQ(OK, rv);
FakeBlockingStreamSocket* raw_transport = transport.get();
- scoped_ptr<SSLClientSocket> sock = CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock = CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
client_config);
@@ -924,7 +925,7 @@ class SSLClientSocketFalseStartTest : public SSLClientSocketTest {
TestCompletionCallback callback;
FakeBlockingStreamSocket* raw_transport = NULL;
- scoped_ptr<SSLClientSocket> sock;
+ std::unique_ptr<SSLClientSocket> sock;
ASSERT_NO_FATAL_FAILURE(CreateAndConnectUntilServerFinishedReceived(
client_config, &callback, &raw_transport, &sock));
@@ -990,7 +991,7 @@ class SSLClientSocketChannelIDTest : public SSLClientSocketTest {
}
private:
- scoped_ptr<ChannelIDService> channel_id_service_;
+ std::unique_ptr<ChannelIDService> channel_id_service_;
};
} // namespace
@@ -1000,12 +1001,12 @@ TEST_F(SSLClientSocketTest, Connect) {
TestCompletionCallback callback;
TestNetLog log;
- scoped_ptr<StreamSocket> transport(
+ std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr(), NULL, &log, NetLog::Source()));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_EQ(OK, rv);
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
@@ -1146,14 +1147,14 @@ TEST_F(SSLClientSocketTest, Read) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> transport(
+ std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
EXPECT_EQ(0, transport->GetTotalReceivedBytes());
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_EQ(OK, rv);
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
EXPECT_EQ(0, sock->GetTotalReceivedBytes());
@@ -1203,9 +1204,9 @@ TEST_F(SSLClientSocketTest, Connect_WithSynchronousError) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
- scoped_ptr<SynchronousErrorStreamSocket> transport(
+ std::unique_ptr<SynchronousErrorStreamSocket> transport(
new SynchronousErrorStreamSocket(std::move(real_transport)));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_EQ(OK, rv);
@@ -1215,7 +1216,7 @@ TEST_F(SSLClientSocketTest, Connect_WithSynchronousError) {
ssl_config.false_start_enabled = false;
SynchronousErrorStreamSocket* raw_transport = transport.get();
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
@@ -1234,9 +1235,9 @@ TEST_F(SSLClientSocketTest, Read_WithSynchronousError) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
- scoped_ptr<SynchronousErrorStreamSocket> transport(
+ std::unique_ptr<SynchronousErrorStreamSocket> transport(
new SynchronousErrorStreamSocket(std::move(real_transport)));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_EQ(OK, rv);
@@ -1246,7 +1247,7 @@ TEST_F(SSLClientSocketTest, Read_WithSynchronousError) {
ssl_config.false_start_enabled = false;
SynchronousErrorStreamSocket* raw_transport = transport.get();
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
@@ -1284,14 +1285,14 @@ TEST_F(SSLClientSocketTest, Write_WithSynchronousError) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
// Note: |error_socket|'s ownership is handed to |transport|, but a pointer
// is retained in order to configure additional errors.
- scoped_ptr<SynchronousErrorStreamSocket> error_socket(
+ std::unique_ptr<SynchronousErrorStreamSocket> error_socket(
new SynchronousErrorStreamSocket(std::move(real_transport)));
SynchronousErrorStreamSocket* raw_error_socket = error_socket.get();
- scoped_ptr<FakeBlockingStreamSocket> transport(
+ std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(error_socket)));
FakeBlockingStreamSocket* raw_transport = transport.get();
int rv = callback.GetResult(transport->Connect(callback.callback()));
@@ -1301,7 +1302,7 @@ TEST_F(SSLClientSocketTest, Write_WithSynchronousError) {
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
@@ -1351,14 +1352,14 @@ TEST_F(SSLClientSocketTest, Write_WithSynchronousErrorNoRead) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
// Note: intermediate sockets' ownership are handed to |sock|, but a pointer
// is retained in order to query them.
- scoped_ptr<SynchronousErrorStreamSocket> error_socket(
+ std::unique_ptr<SynchronousErrorStreamSocket> error_socket(
new SynchronousErrorStreamSocket(std::move(real_transport)));
SynchronousErrorStreamSocket* raw_error_socket = error_socket.get();
- scoped_ptr<CountingStreamSocket> counting_socket(
+ std::unique_ptr<CountingStreamSocket> counting_socket(
new CountingStreamSocket(std::move(error_socket)));
CountingStreamSocket* raw_counting_socket = counting_socket.get();
int rv = callback.GetResult(counting_socket->Connect(callback.callback()));
@@ -1368,7 +1369,7 @@ TEST_F(SSLClientSocketTest, Write_WithSynchronousErrorNoRead) {
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(counting_socket), spawned_test_server()->host_port_pair(),
ssl_config));
@@ -1451,14 +1452,14 @@ TEST_F(SSLClientSocketTest, Read_DeleteWhilePendingFullDuplex) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
// Note: |error_socket|'s ownership is handed to |transport|, but a pointer
// is retained in order to configure additional errors.
- scoped_ptr<SynchronousErrorStreamSocket> error_socket(
+ std::unique_ptr<SynchronousErrorStreamSocket> error_socket(
new SynchronousErrorStreamSocket(std::move(real_transport)));
SynchronousErrorStreamSocket* raw_error_socket = error_socket.get();
- scoped_ptr<FakeBlockingStreamSocket> transport(
+ std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(error_socket)));
FakeBlockingStreamSocket* raw_transport = transport.get();
@@ -1469,7 +1470,7 @@ TEST_F(SSLClientSocketTest, Read_DeleteWhilePendingFullDuplex) {
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
- scoped_ptr<SSLClientSocket> sock = CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock = CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config);
@@ -1560,14 +1561,14 @@ TEST_F(SSLClientSocketTest, Read_WithWriteError) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
// Note: |error_socket|'s ownership is handed to |transport|, but a pointer
// is retained in order to configure additional errors.
- scoped_ptr<SynchronousErrorStreamSocket> error_socket(
+ std::unique_ptr<SynchronousErrorStreamSocket> error_socket(
new SynchronousErrorStreamSocket(std::move(real_transport)));
SynchronousErrorStreamSocket* raw_error_socket = error_socket.get();
- scoped_ptr<FakeBlockingStreamSocket> transport(
+ std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(error_socket)));
FakeBlockingStreamSocket* raw_transport = transport.get();
@@ -1578,7 +1579,7 @@ TEST_F(SSLClientSocketTest, Read_WithWriteError) {
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
@@ -1657,15 +1658,15 @@ TEST_F(SSLClientSocketTest, Connect_WithZeroReturn) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
- scoped_ptr<SynchronousErrorStreamSocket> transport(
+ std::unique_ptr<SynchronousErrorStreamSocket> transport(
new SynchronousErrorStreamSocket(std::move(real_transport)));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_EQ(OK, rv);
SynchronousErrorStreamSocket* raw_transport = transport.get();
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
@@ -1683,9 +1684,9 @@ TEST_F(SSLClientSocketTest, Read_WithZeroReturn) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
- scoped_ptr<SynchronousErrorStreamSocket> transport(
+ std::unique_ptr<SynchronousErrorStreamSocket> transport(
new SynchronousErrorStreamSocket(std::move(real_transport)));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_EQ(OK, rv);
@@ -1695,7 +1696,7 @@ TEST_F(SSLClientSocketTest, Read_WithZeroReturn) {
ssl_config.false_start_enabled = false;
SynchronousErrorStreamSocket* raw_transport = transport.get();
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
@@ -1716,12 +1717,12 @@ TEST_F(SSLClientSocketTest, Read_WithAsyncZeroReturn) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
- scoped_ptr<SynchronousErrorStreamSocket> error_socket(
+ std::unique_ptr<SynchronousErrorStreamSocket> error_socket(
new SynchronousErrorStreamSocket(std::move(real_transport)));
SynchronousErrorStreamSocket* raw_error_socket = error_socket.get();
- scoped_ptr<FakeBlockingStreamSocket> transport(
+ std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(error_socket)));
FakeBlockingStreamSocket* raw_transport = transport.get();
int rv = callback.GetResult(transport->Connect(callback.callback()));
@@ -1731,7 +1732,7 @@ TEST_F(SSLClientSocketTest, Read_WithAsyncZeroReturn) {
SSLConfig ssl_config;
ssl_config.false_start_enabled = false;
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
ssl_config));
@@ -1797,15 +1798,15 @@ TEST_F(SSLClientSocketTest, Read_ManySmallRecords) {
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
- scoped_ptr<ReadBufferingStreamSocket> transport(
+ std::unique_ptr<ReadBufferingStreamSocket> transport(
new ReadBufferingStreamSocket(std::move(real_transport)));
ReadBufferingStreamSocket* raw_transport = transport.get();
int rv = callback.GetResult(transport->Connect(callback.callback()));
ASSERT_EQ(OK, rv);
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
@@ -1868,12 +1869,12 @@ TEST_F(SSLClientSocketTest, Read_FullLogging) {
TestCompletionCallback callback;
TestNetLog log;
log.SetCaptureMode(NetLogCaptureMode::IncludeSocketBytes());
- scoped_ptr<StreamSocket> transport(
+ std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr(), NULL, &log, NetLog::Source()));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_EQ(OK, rv);
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
@@ -1937,12 +1938,12 @@ TEST_F(SSLClientSocketTest, PrematureApplicationData) {
StaticSocketDataProvider data(data_reads, arraysize(data_reads), NULL, 0);
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> transport(
+ std::unique_ptr<StreamSocket> transport(
new MockTCPClientSocket(addr(), NULL, &data));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_EQ(OK, rv);
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
@@ -1982,15 +1983,15 @@ TEST_F(SSLClientSocketTest, ClientSocketHandleNotFromPool) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> transport(
+ std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
int rv = callback.GetResult(transport->Connect(callback.callback()));
EXPECT_EQ(OK, rv);
- scoped_ptr<ClientSocketHandle> socket_handle(new ClientSocketHandle());
+ std::unique_ptr<ClientSocketHandle> socket_handle(new ClientSocketHandle());
socket_handle->SetSocket(std::move(transport));
- scoped_ptr<SSLClientSocket> sock(socket_factory_->CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(socket_factory_->CreateSSLClientSocket(
std::move(socket_handle), spawned_test_server()->host_port_pair(),
SSLConfig(), context_));
@@ -2511,14 +2512,14 @@ TEST_F(SSLClientSocketTest, ReusableAfterWrite) {
ASSERT_TRUE(StartTestServer(SpawnedTestServer::SSLOptions()));
TestCompletionCallback callback;
- scoped_ptr<StreamSocket> real_transport(
+ std::unique_ptr<StreamSocket> real_transport(
new TCPClientSocket(addr(), NULL, NULL, NetLog::Source()));
- scoped_ptr<FakeBlockingStreamSocket> transport(
+ std::unique_ptr<FakeBlockingStreamSocket> transport(
new FakeBlockingStreamSocket(std::move(real_transport)));
FakeBlockingStreamSocket* raw_transport = transport.get();
ASSERT_EQ(OK, callback.GetResult(transport->Connect(callback.callback())));
- scoped_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock(CreateSSLClientSocket(
std::move(transport), spawned_test_server()->host_port_pair(),
SSLConfig()));
ASSERT_EQ(OK, callback.GetResult(sock->Connect(callback.callback())));
@@ -2567,11 +2568,11 @@ TEST_F(SSLClientSocketTest, SessionResumption) {
sock_.reset();
// Using a different HostPortPair uses a different session cache key.
- scoped_ptr<StreamSocket> transport(
+ std::unique_ptr<StreamSocket> transport(
new TCPClientSocket(addr(), NULL, &log_, NetLog::Source()));
TestCompletionCallback callback;
ASSERT_EQ(OK, callback.GetResult(transport->Connect(callback.callback())));
- scoped_ptr<SSLClientSocket> sock = CreateSSLClientSocket(
+ std::unique_ptr<SSLClientSocket> sock = CreateSSLClientSocket(
std::move(transport), HostPortPair("example.com", 443), ssl_config);
ASSERT_EQ(OK, callback.GetResult(sock->Connect(callback.callback())));
ASSERT_TRUE(sock->GetSSLInfo(&ssl_info));
@@ -2962,7 +2963,7 @@ TEST_F(SSLClientSocketFalseStartTest, NoSessionResumptionBeforeFinished) {
// Start a handshake up to the server Finished message.
TestCompletionCallback callback;
FakeBlockingStreamSocket* raw_transport1 = NULL;
- scoped_ptr<SSLClientSocket> sock1;
+ std::unique_ptr<SSLClientSocket> sock1;
ASSERT_NO_FATAL_FAILURE(CreateAndConnectUntilServerFinishedReceived(
client_config, &callback, &raw_transport1, &sock1));
// Although raw_transport1 has the server Finished blocked, the handshake
@@ -3019,7 +3020,7 @@ TEST_F(SSLClientSocketFalseStartTest, NoSessionResumptionBadFinished) {
// Start a handshake up to the server Finished message.
TestCompletionCallback callback;
FakeBlockingStreamSocket* raw_transport1 = NULL;
- scoped_ptr<SSLClientSocket> sock1;
+ std::unique_ptr<SSLClientSocket> sock1;
ASSERT_NO_FATAL_FAILURE(CreateAndConnectUntilServerFinishedReceived(
client_config, &callback, &raw_transport1, &sock1));
// Although raw_transport1 has the server Finished blocked, the handshake
« no previous file with comments | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/socket/ssl_server_socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698