Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: net/socket/websocket_transport_client_socket_pool.cc

Issue 1892323002: Change scoped_ptr to std::unique_ptr in //net/socket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/websocket_transport_client_socket_pool.cc
diff --git a/net/socket/websocket_transport_client_socket_pool.cc b/net/socket/websocket_transport_client_socket_pool.cc
index 6ca72b39a9da2e5e47ae7db54a660abadfe445ac..412a63a14d6877ccbfd0ce94c88dd44dc944f8a6 100644
--- a/net/socket/websocket_transport_client_socket_pool.cc
+++ b/net/socket/websocket_transport_client_socket_pool.cc
@@ -310,7 +310,7 @@ int WebSocketTransportClientSocketPool::RequestSocket(
return ERR_IO_PENDING;
}
- scoped_ptr<WebSocketTransportConnectJob> connect_job(
+ std::unique_ptr<WebSocketTransportConnectJob> connect_job(
new WebSocketTransportConnectJob(
group_name, priority, respect_limits, casted_params,
ConnectionTimeout(), callback, client_socket_factory_, host_resolver_,
@@ -333,7 +333,7 @@ int WebSocketTransportClientSocketPool::RequestSocket(
// TODO(ricea): Implement backup job timer?
AddJob(handle, std::move(connect_job));
} else {
- scoped_ptr<StreamSocket> error_socket;
+ std::unique_ptr<StreamSocket> error_socket;
connect_job->GetAdditionalErrorState(handle);
error_socket = connect_job->PassSocket();
if (error_socket) {
@@ -363,7 +363,7 @@ void WebSocketTransportClientSocketPool::CancelRequest(
DCHECK(!handle->is_initialized());
if (DeleteStalledRequest(handle))
return;
- scoped_ptr<StreamSocket> socket = handle->PassSocket();
+ std::unique_ptr<StreamSocket> socket = handle->PassSocket();
if (socket)
ReleaseSocket(handle->group_name(), std::move(socket), handle->id());
if (!DeleteJob(handle))
@@ -374,7 +374,7 @@ void WebSocketTransportClientSocketPool::CancelRequest(
void WebSocketTransportClientSocketPool::ReleaseSocket(
const std::string& group_name,
- scoped_ptr<StreamSocket> socket,
+ std::unique_ptr<StreamSocket> socket,
int id) {
WebSocketEndpointLockManager::GetInstance()->UnlockSocket(socket.get());
CHECK_GT(handed_out_socket_count_, 0);
@@ -432,12 +432,12 @@ LoadState WebSocketTransportClientSocketPool::GetLoadState(
return LookupConnectJob(handle)->GetLoadState();
}
-scoped_ptr<base::DictionaryValue>
- WebSocketTransportClientSocketPool::GetInfoAsValue(
- const std::string& name,
- const std::string& type,
- bool include_nested_pools) const {
- scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
+std::unique_ptr<base::DictionaryValue>
+WebSocketTransportClientSocketPool::GetInfoAsValue(
+ const std::string& name,
+ const std::string& type,
+ bool include_nested_pools) const {
+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetString("name", name);
dict->SetString("type", type);
dict->SetInteger("handed_out_socket_count", handed_out_socket_count_);
@@ -462,7 +462,7 @@ void WebSocketTransportClientSocketPool::OnConnectJobComplete(
WebSocketTransportConnectJob* job) {
DCHECK_NE(ERR_IO_PENDING, result);
- scoped_ptr<StreamSocket> socket = job->PassSocket();
+ std::unique_ptr<StreamSocket> socket = job->PassSocket();
// See comment in FlushWithError.
if (flushing_) {
@@ -527,7 +527,7 @@ bool WebSocketTransportClientSocketPool::ReachedMaxSocketsLimit() const {
}
void WebSocketTransportClientSocketPool::HandOutSocket(
- scoped_ptr<StreamSocket> socket,
+ std::unique_ptr<StreamSocket> socket,
const LoadTimingInfo::ConnectTiming& connect_timing,
ClientSocketHandle* handle,
const BoundNetLog& net_log) {
@@ -547,7 +547,7 @@ void WebSocketTransportClientSocketPool::HandOutSocket(
void WebSocketTransportClientSocketPool::AddJob(
ClientSocketHandle* handle,
- scoped_ptr<WebSocketTransportConnectJob> connect_job) {
+ std::unique_ptr<WebSocketTransportConnectJob> connect_job) {
bool inserted =
pending_connects_.insert(PendingConnectsMap::value_type(
handle, connect_job.release())).second;
« no previous file with comments | « net/socket/websocket_transport_client_socket_pool.h ('k') | net/socket/websocket_transport_client_socket_pool_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698