Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr

Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr

BUG=554298
R=isherman@chromium.org

Committed: https://crrev.com/1edb03a4943e4e3de4116adcc031e2dfabbb7805
Cr-Commit-Position: refs/heads/master@{#387347}

[dcheng, 2016-04-13 23:46:11]

Description was changed from

==========
Convert //chrome/browser/spellchecker from scoped_ptr to std::unique_ptr

BUG=554298
R=isherman@chromium.org
==========

to

==========
Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr

BUG=554298
R=isherman@chromium.org
==========

[dcheng, 2016-04-13 23:46:52]

This is largely a search and replace. There's probably some IWYU errors (files
that don't include memory when they should and those that do when they
shouldn't), but fixing those is out-of-scope for this conversion work.

[Ilya Sherman, 2016-04-14 00:59:53]

LGTM, with a couple of questions inline:

https://codereview.chromium.org/1886913002/diff/1/chrome/browser/metrics/exte...
File chrome/browser/metrics/extensions_metrics_provider_unittest.cc (right):

https://codereview.chromium.org/1886913002/diff/1/chrome/browser/metrics/exte...
chrome/browser/metrics/extensions_metrics_provider_unittest.cc:32: return
std::unique_ptr<metrics::ClientInfo>();
nit: Is "return nullptr;" equivalent here?

https://codereview.chromium.org/1886913002/diff/1/chrome/browser/metrics/exte...
chrome/browser/metrics/extensions_metrics_provider_unittest.cc:49:
std::unique_ptr<extensions::ExtensionSet> extensions(
nit: It looks like this code be base::WrapUnique, as could many of the other
call sites.  Is converting over out of scope for this CL?

[dcheng, 2016-04-14 01:05:24]

https://codereview.chromium.org/1886913002/diff/1/chrome/browser/metrics/exte...
File chrome/browser/metrics/extensions_metrics_provider_unittest.cc (right):

https://codereview.chromium.org/1886913002/diff/1/chrome/browser/metrics/exte...
chrome/browser/metrics/extensions_metrics_provider_unittest.cc:32: return
std::unique_ptr<metrics::ClientInfo>();
On 2016/04/14 at 00:59:53, Ilya Sherman wrote:
> nit: Is "return nullptr;" equivalent here?

Yes. But largely out of scope unless someone strongly insists. We have a lot of
code that does this currently, so fixing just the ones people comment on is a
drop in the ocean.

I'm hoping that clang-tidy integration will help us find these and clean them up
on a systemic basis.

https://codereview.chromium.org/1886913002/diff/1/chrome/browser/metrics/exte...
chrome/browser/metrics/extensions_metrics_provider_unittest.cc:49:
std::unique_ptr<extensions::ExtensionSet> extensions(
On 2016/04/14 at 00:59:53, Ilya Sherman wrote:
> nit: It looks like this code be base::WrapUnique, as could many of the other
call sites.  Is converting over out of scope for this CL?

Sometimes: this particular instance is probably better to write the way it's
already written. A potential improvement in the future:

auto extensions = base::MakeUnique<ExtensionSet>();

But that's still in debate, as is allowing the use of auto to elide a smart
pointer type.

[dcheng, 2016-04-14 16:50:33]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-14 16:50:33]

(Going to hit CQ, feel free to uncheck if you have further questions)

[commit-bot: I haz the power, 2016-04-14 16:50:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886913002/1

[commit-bot: I haz the power, 2016-04-14 17:20:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-14 17:22:18]

Description was changed from

==========
Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr

BUG=554298
R=isherman@chromium.org
==========

to

==========
Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr

BUG=554298
R=isherman@chromium.org

Committed: https://crrev.com/1edb03a4943e4e3de4116adcc031e2dfabbb7805
Cr-Commit-Position: refs/heads/master@{#387347}
==========

[commit-bot: I haz the power, 2016-04-14 17:22:19]

Patchset 1 (id:??) landed as
https://crrev.com/1edb03a4943e4e3de4116adcc031e2dfabbb7805
Cr-Commit-Position: refs/heads/master@{#387347}