chrome/browser/metrics/thread_watcher.h - Issue 1886913002: Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/thread_watcher.h

Issue 1886913002: Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/extensions_metrics_provider_unittest.cc ('K') | « chrome/browser/metrics/plugin_metrics_provider_unittest.cc ('k') | chrome/browser/metrics/thread_watcher_android_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/thread_watcher.h

diff --git a/chrome/browser/metrics/thread_watcher.h b/chrome/browser/metrics/thread_watcher.h

index af5ec1fc1516c96a2b8e80bc6659570e3b30b6f7..6bf8d15cd1fccf0abf0abe431b6906861587f506 100644

--- a/chrome/browser/metrics/thread_watcher.h

+++ b/chrome/browser/metrics/thread_watcher.h

@@ -553,7 +553,7 @@ class ThreadWatcherObserver : public content::NotificationObserver {

// Subscription for receiving callbacks that a URL was opened from the

// omnibox.

- scoped_ptr<base::CallbackList<void(OmniboxLog*)>::Subscription>

+ std::unique_ptr<base::CallbackList<void(OmniboxLog*)>::Subscription>

omnibox_url_opened_subscription_;

DISALLOW_COPY_AND_ASSIGN(ThreadWatcherObserver);

@@ -662,7 +662,7 @@ class JankTimeBomb {

private:

// A profiler that periodically samples stack traces. Used to sample jank

// behavior.

- scoped_ptr<base::StackSamplingProfiler> sampling_profiler_;

+ std::unique_ptr<base::StackSamplingProfiler> sampling_profiler_;

// We use this factory during creation and starting timer.

base::WeakPtrFactory<JankTimeBomb> weak_ptr_factory_;