chrome/browser/metrics/metrics_memory_details_browsertest.cc - Issue 1886913002: Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_memory_details_browsertest.cc

Issue 1886913002: Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/extensions_metrics_provider_unittest.cc ('K') | « chrome/browser/metrics/first_web_contents_profiler.h ('k') | chrome/browser/metrics/perf/perf_provider_chromeos.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_memory_details_browsertest.cc

diff --git a/chrome/browser/metrics/metrics_memory_details_browsertest.cc b/chrome/browser/metrics/metrics_memory_details_browsertest.cc

index 792280888ab8579d27ee76e302cd50e17b409318..83b8a4dabc86162f5ebef131dfa4182b02f28415 100644

--- a/chrome/browser/metrics/metrics_memory_details_browsertest.cc

+++ b/chrome/browser/metrics/metrics_memory_details_browsertest.cc

@@ -54,7 +54,7 @@ IN_PROC_BROWSER_TEST_F(MetricsMemoryDetailsBrowserTest, TestMemoryDetails) {

// Memory.Browser histogram should have a single non-0 sample recorded.

histogram_tester.ExpectTotalCount("Memory.Browser", 1);

- scoped_ptr<base::HistogramSamples> samples(

+ std::unique_ptr<base::HistogramSamples> samples(

histogram_tester.GetHistogramSamplesSinceCreation("Memory.Browser"));

ASSERT_TRUE(samples);

EXPECT_NE(0, samples->sum());