Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_services_manager_client.cc

Issue 1886913002: Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_metrics_services_manager_client.h" 5 #include "chrome/browser/metrics/chrome_metrics_services_manager_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/ptr_util.h"
9 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h" 11 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
11 #include "chrome/browser/metrics/chrome_metrics_service_client.h" 12 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
12 #include "chrome/browser/metrics/variations/chrome_variations_service_client.h" 13 #include "chrome/browser/metrics/variations/chrome_variations_service_client.h"
13 #include "chrome/browser/metrics/variations/ui_string_overrider_factory.h" 14 #include "chrome/browser/metrics/variations/ui_string_overrider_factory.h"
14 #include "chrome/browser/ui/browser_otr_state.h" 15 #include "chrome/browser/ui/browser_otr_state.h"
15 #include "chrome/common/chrome_switches.h" 16 #include "chrome/common/chrome_switches.h"
16 #include "chrome/installer/util/google_update_settings.h" 17 #include "chrome/installer/util/google_update_settings.h"
17 #include "components/metrics/metrics_state_manager.h" 18 #include "components/metrics/metrics_state_manager.h"
18 #include "components/prefs/pref_service.h" 19 #include "components/prefs/pref_service.h"
(...skipping 16 matching lines...) Expand all
35 ChromeMetricsServicesManagerClient::ChromeMetricsServicesManagerClient( 36 ChromeMetricsServicesManagerClient::ChromeMetricsServicesManagerClient(
36 PrefService* local_state) 37 PrefService* local_state)
37 : local_state_(local_state) { 38 : local_state_(local_state) {
38 DCHECK(local_state); 39 DCHECK(local_state);
39 40
40 SetupMetricsStateForChromeOS(); 41 SetupMetricsStateForChromeOS();
41 } 42 }
42 43
43 ChromeMetricsServicesManagerClient::~ChromeMetricsServicesManagerClient() {} 44 ChromeMetricsServicesManagerClient::~ChromeMetricsServicesManagerClient() {}
44 45
45 scoped_ptr<rappor::RapporService> 46 std::unique_ptr<rappor::RapporService>
46 ChromeMetricsServicesManagerClient::CreateRapporService() { 47 ChromeMetricsServicesManagerClient::CreateRapporService() {
47 DCHECK(thread_checker_.CalledOnValidThread()); 48 DCHECK(thread_checker_.CalledOnValidThread());
48 return make_scoped_ptr(new rappor::RapporService( 49 return base::WrapUnique(new rappor::RapporService(
49 local_state_, base::Bind(&chrome::IsOffTheRecordSessionActive))); 50 local_state_, base::Bind(&chrome::IsOffTheRecordSessionActive)));
50 } 51 }
51 52
52 scoped_ptr<variations::VariationsService> 53 std::unique_ptr<variations::VariationsService>
53 ChromeMetricsServicesManagerClient::CreateVariationsService() { 54 ChromeMetricsServicesManagerClient::CreateVariationsService() {
54 DCHECK(thread_checker_.CalledOnValidThread()); 55 DCHECK(thread_checker_.CalledOnValidThread());
55 return variations::VariationsService::Create( 56 return variations::VariationsService::Create(
56 make_scoped_ptr(new ChromeVariationsServiceClient()), local_state_, 57 base::WrapUnique(new ChromeVariationsServiceClient()), local_state_,
57 GetMetricsStateManager(), switches::kDisableBackgroundNetworking, 58 GetMetricsStateManager(), switches::kDisableBackgroundNetworking,
58 chrome_variations::CreateUIStringOverrider()); 59 chrome_variations::CreateUIStringOverrider());
59 } 60 }
60 61
61 scoped_ptr<metrics::MetricsServiceClient> 62 std::unique_ptr<metrics::MetricsServiceClient>
62 ChromeMetricsServicesManagerClient::CreateMetricsServiceClient() { 63 ChromeMetricsServicesManagerClient::CreateMetricsServiceClient() {
63 DCHECK(thread_checker_.CalledOnValidThread()); 64 DCHECK(thread_checker_.CalledOnValidThread());
64 return ChromeMetricsServiceClient::Create(GetMetricsStateManager(), 65 return ChromeMetricsServiceClient::Create(GetMetricsStateManager(),
65 local_state_); 66 local_state_);
66 } 67 }
67 68
68 net::URLRequestContextGetter* 69 net::URLRequestContextGetter*
69 ChromeMetricsServicesManagerClient::GetURLRequestContext() { 70 ChromeMetricsServicesManagerClient::GetURLRequestContext() {
70 return g_browser_process->system_request_context(); 71 return g_browser_process->system_request_context();
71 } 72 }
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 if (!metrics_state_manager_) { 106 if (!metrics_state_manager_) {
106 metrics_state_manager_ = metrics::MetricsStateManager::Create( 107 metrics_state_manager_ = metrics::MetricsStateManager::Create(
107 local_state_, 108 local_state_,
108 base::Bind( 109 base::Bind(
109 &ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled), 110 &ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled),
110 base::Bind(&PostStoreMetricsClientInfo), 111 base::Bind(&PostStoreMetricsClientInfo),
111 base::Bind(&GoogleUpdateSettings::LoadMetricsClientInfo)); 112 base::Bind(&GoogleUpdateSettings::LoadMetricsClientInfo));
112 } 113 }
113 return metrics_state_manager_.get(); 114 return metrics_state_manager_.get();
114 } 115 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698