chrome/browser/metrics/plugin_metrics_provider_unittest.cc - Issue 1886913002: Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/plugin_metrics_provider_unittest.cc

Issue 1886913002: Convert //chrome/browser/metrics from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/extensions_metrics_provider_unittest.cc ('K') | « chrome/browser/metrics/perf/perf_provider_chromeos_unittest.cc ('k') | chrome/browser/metrics/thread_watcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/plugin_metrics_provider_unittest.cc

diff --git a/chrome/browser/metrics/plugin_metrics_provider_unittest.cc b/chrome/browser/metrics/plugin_metrics_provider_unittest.cc

index 442373ddee3a81d5632dea61e4565c16ed719c73..0bc4f2341b149fcb05d04b1960eceaa82c681099 100644

--- a/chrome/browser/metrics/plugin_metrics_provider_unittest.cc

+++ b/chrome/browser/metrics/plugin_metrics_provider_unittest.cc

@@ -48,7 +48,7 @@ class PluginMetricsProviderTest : public ::testing::Test {

}

private:

- scoped_ptr<TestingPrefServiceSimple> prefs_;

+ std::unique_ptr<TestingPrefServiceSimple> prefs_;

DISALLOW_COPY_AND_ASSIGN(PluginMetricsProviderTest);

};

@@ -88,7 +88,7 @@ TEST_F(PluginMetricsProviderTest, Plugins) {

EXPECT_TRUE(system_profile.plugin(1).is_pepper());

// Now set some plugin stability stats for p2 and verify they're recorded.

- scoped_ptr<base::DictionaryValue> plugin_dict(new base::DictionaryValue);

+ std::unique_ptr<base::DictionaryValue> plugin_dict(new base::DictionaryValue);

plugin_dict->SetString(prefs::kStabilityPluginName, "p2");

plugin_dict->SetInteger(prefs::kStabilityPluginLaunches, 1);

plugin_dict->SetInteger(prefs::kStabilityPluginCrashes, 2);