Implement Dump-on-DCHECK (via alternate DCHECK and DCHECK_OP macro implementations).

Implement Dump-on-DCHECK (via alternate DCHECK and DCHECK_OP macro implementations).

This patch adds new DCHECK and DCHECK_OP macro implementations which upload a dump without actually crashing, and only
do so on the first DUMP-severity failure. A new DCHECK_IS_DUMP_WITHOUT_CRASHING macro is introduced, to enable the new behaviour in DCHECK_IS_ON()[1] builds.

A new build argument, dump_on_first_dcheck, is set in the GN configuration to enable the DCHECK_IS_DUMP_WITHOUT_CRASHING macro.

All non-DCHECK_IS_ON() behaviours, e.g. CHECK, PCHECK, SECURITY_CHECK, are unchanged and continue to be mapped to the LOG_FATAL severity.

Dump-on-DCHECK will be enabled in one-off Canary builds by temporarily landing this patch, and reverting it as soon as the Canary build has been cut.

BUG=596231
[1] DCHECK_IS_ON() is set in Debug builds, and Release builds with DCHECK_ALWAYS_ON.

[Wez, 2016-04-14 01:17:18]

Description was changed from

==========
Patch to try dump-on-DCHECK.

This patch does two things:

1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.

2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.

All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for
DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows
official builds.

Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.

BUG=596231
==========

to

==========
Patch to try dump-on-DCHECK.

This patch does two things:

1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process. The implementation follows the approach taken for CHECK & CHECK_OP
in official-branded builds, and strips out any log messages associated with the
check.

2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.

All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for
DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows
official builds.

Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.

BUG=596231
==========

[Wez, 2016-04-14 01:17:18]

wez@chromium.org changed reviewers:
+ danakj@chromium.org, scottmg@chromium.org, thakis@chromium.org

[Nico, 2016-04-14 02:22:34]

is this different from the other one? if so, can you upload the original as
patch set 1 somewhere and the tweak as patch set 2?

[danakj, 2016-04-14 18:35:28]

On Wed, Apr 13, 2016 at 7:22 PM, <thakis@chromium.org> wrote:

> is this different from the other one? if so, can you upload the original as
> patch set 1 somewhere and the tweak as patch set 2?
>

+1. Or just use the original CL.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2016-04-14 18:35:29]

On Wed, Apr 13, 2016 at 7:22 PM, <thakis@chromium.org> wrote:

> is this different from the other one? if so, can you upload the original as
> patch set 1 somewhere and the tweak as patch set 2?
>

+1. Or just use the original CL.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ncarter (slow), 2016-04-14 18:41:34]

nick@chromium.org changed reviewers:
+ nick@chromium.org

[ncarter (slow), 2016-04-14 18:41:35]

lgtm

https://codereview.chromium.org/1884023002/diff/1/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/1884023002/diff/1/base/logging.h#newcode717
base/logging.h:717: DCHECK((val1) op (val2))
This looks correct.

[scottmg, 2016-04-14 19:40:07]

I did a quick test on an official build of base_unittests and DCHECK_EQ seems to
do the correct thing now afaics, so lgtm.

[Wez, 2016-04-14 19:54:39]

This is what happens if you start reviewing before I've hit Publish+Mail
Comments. ;)

Have uploaded the original dump-on-DCHECK and re-uploaded the tweaked version,
so the diff is obvious.

Note that this version can't land until I've tidied up
https://bugs.chromium.org/p/chromium/issues/detail?id=596277 since DCHECK_<op>()
doesn't normally trigger tautologous-comparison warnings by the compiler,
whereas this version does.

This version also fails to reference operator<<(ostream, T) for the
DCHECK_<op>'s parameters, which leads to at least one build error; I may simply
tag the logging on the end of the DCHECK() in the new impl, so the compiler sees
them referenced but will then optimize them out.

https://codereview.chromium.org/1884023002/diff/1/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/1884023002/diff/1/base/logging.h#newcode717
base/logging.h:717: DCHECK((val1) op (val2))
On 2016/04/14 18:41:34, ncarter wrote:
> This looks correct.

Unfortunately, though, there is an operator<<(ostream, enum class) in the
TouchHandle code that becomes an "unused function" with this version, so I need
to fix that first.

[Wez, 2016-04-15 00:19:43]

To work-around the operator<<() I've added logging of the values in the DCHECK,
so that the compiler sees the operator<<() for the logged types being used - my
understanding is that EAT_STREAM_PARAMETERS is sufficiently inline/simple that
the compiler will optimize that out in the actual build.  Scott, does that sound
right to you? :P

[scottmg, 2016-04-15 16:32:09]

On 2016/04/15 00:19:43, Wez wrote:
> To work-around the operator<<() I've added logging of the values in the
DCHECK,
> so that the compiler sees the operator<<() for the logged types being used -
my
> understanding is that EAT_STREAM_PARAMETERS is sufficiently inline/simple that
> the compiler will optimize that out in the actual build.  Scott, does that
sound
> right to you? :P

Other than failing to compile on all platforms, that seems reasonable. :)

I checked Win official, and the << args seems to disappear as expected in normal
use, and I don't get unused variable warnings.

I did notice if I put e.g. a base::debug::Alias() call in the << chain it'll
still get evaluated. I suspect it gets maintained because that function is
non-optimized and extern. I doubt this behaviour would cause a problem in
practice, but I'm not entirely sure of that.

[Wez, 2016-04-15 23:46:19]

Thanks for checking, Scott. I'm adding logging of the values, so I suppose
it's possible for the operator<< impl for a lot of those to be extern, in
which case this could result in a bigger binary?

On 15 April 2016 at 09:32, <scottmg@chromium.org> wrote:

> On 2016/04/15 00:19:43, Wez wrote:
> > To work-around the operator<<() I've added logging of the values in the
> DCHECK,
> > so that the compiler sees the operator<<() for the logged types being
> used -
> my
> > understanding is that EAT_STREAM_PARAMETERS is sufficiently
> inline/simple that
> > the compiler will optimize that out in the actual build. Scott, does that
> sound
> > right to you? :P
>
> Other than failing to compile on all platforms, that seems reasonable. :)
>
> I checked Win official, and the << args seems to disappear as expected in
> normal
> use, and I don't get unused variable warnings.
>
> I did notice if I put e.g. a base::debug::Alias() call in the << chain
> it'll
> still get evaluated. I suspect it gets maintained because that function is
> non-optimized and extern. I doubt this behaviour would cause a problem in
> practice, but I'm not entirely sure of that.
>
> https://codereview.chromium.org/1884023002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Wez, 2016-04-15 23:46:19]

Thanks for checking, Scott. I'm adding logging of the values, so I suppose
it's possible for the operator<< impl for a lot of those to be extern, in
which case this could result in a bigger binary?

On 15 April 2016 at 09:32, <scottmg@chromium.org> wrote:

> On 2016/04/15 00:19:43, Wez wrote:
> > To work-around the operator<<() I've added logging of the values in the
> DCHECK,
> > so that the compiler sees the operator<<() for the logged types being
> used -
> my
> > understanding is that EAT_STREAM_PARAMETERS is sufficiently
> inline/simple that
> > the compiler will optimize that out in the actual build. Scott, does that
> sound
> > right to you? :P
>
> Other than failing to compile on all platforms, that seems reasonable. :)
>
> I checked Win official, and the << args seems to disappear as expected in
> normal
> use, and I don't get unused variable warnings.
>
> I did notice if I put e.g. a base::debug::Alias() call in the << chain
> it'll
> still get evaluated. I suspect it gets maintained because that function is
> non-optimized and extern. I doubt this behaviour would cause a problem in
> practice, but I'm not entirely sure of that.
>
> https://codereview.chromium.org/1884023002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Wez, 2016-04-15 23:47:11]

P.S. The try-bot failures are due to tautologous DCHECK_OPs in the QUIC code,
which I've made a separate patch for.

[scottmg, 2016-04-15 23:50:25]

On 2016/04/15 23:47:11, Wez wrote:
> P.S. The try-bot failures are due to tautologous DCHECK_OPs in the QUIC code,
> which I've made a separate patch for.

This one looks QUIC related,
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
but this one looks different fwiw
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...
. Dunno.

[scottmg, 2016-04-15 23:52:35]

On 2016/04/15 23:46:19, Wez wrote:
> Thanks for checking, Scott. I'm adding logging of the values, so I suppose
> it's possible for the operator<< impl for a lot of those to be extern, in
> which case this could result in a bigger binary?

Yes, possibly larger which seems not-too-big-a-deal for this use.

It could cause an unwanted side-effect too, but since the dcheck is failing,
presumably it wouldn't do anything too unexpected.

[Wez, 2016-04-15 23:57:27]

On 2016/04/15 23:50:25, scottmg wrote:
> On 2016/04/15 23:47:11, Wez wrote:
> > P.S. The try-bot failures are due to tautologous DCHECK_OPs in the QUIC
code,
> > which I've made a separate patch for.
> 
> This one looks QUIC related,
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
> but this one looks different fwiw
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...
> . Dunno.

I'll look into the TouchHandleOrientation thing; that's the operator that
motivated adding the << logging in the first place...

[Wez, 2016-05-24 22:22:05]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 22:22:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884023002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884023002/100001

[commit-bot: I haz the power, 2016-05-24 23:16:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 23:16:56]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Wez, 2016-05-26 20:28:43]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-26 20:29:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884023002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884023002/100001

[commit-bot: I haz the power, 2016-05-26 21:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 21:38:24]

Dry run: Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Wez, 2016-08-27 01:38:38]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 01:39:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 01:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:57:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Wez, 2016-11-22 23:21:57]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 23:22:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 23:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:45:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Wez, 2017-01-17 22:31:36]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 22:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 23:05:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 23:05:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Wez, 2017-01-18 00:42:03]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 00:42:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 00:59:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:59:53]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Wez, 2017-01-18 21:47:28]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 21:48:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 22:39:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 22:39:30]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Wez, 2017-01-19 01:01:39]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 01:02:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 01:46:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 01:46:21]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Wez, 2017-01-19 20:05:40]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 20:06:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 20:09:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 20:09:03]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Wez, 2017-01-20 03:56:30]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 03:56:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 04:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 04:54:17]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Wez, 2017-01-20 23:46:55]

thakis: This is the alternative dump-on-DCHECK implementation to
https://codereview.chromium.org/2288473002/, avoiding the need for a new
LogSeverity. The main downside of this implementation is that it won't dump from
anything that uses the LOG_DCHECK or LOG_DFATAL severity names (i.e. LOG(DFATAL)
will just log an error, not dump).  WDYT?

[Wez, 2017-01-25 02:16:06]

thakis: PTAL

[Wez, 2017-02-05 00:57:16]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-05 00:57:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-05 01:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-05 01:31:47]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Wez, 2017-02-06 22:38:56]

Description was changed from

==========
Patch to try dump-on-DCHECK.

This patch does two things:

1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process. The implementation follows the approach taken for CHECK & CHECK_OP
in official-branded builds, and strips out any log messages associated with the
check.

2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.

All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for
DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows
official builds.

Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.

BUG=596231
==========

to

==========
Implement Dump-on-DCHECK (via alternate DCHECK and DCHECK_OP macro
implementations).

This patch adds new DCHECK and DCHECK_OP macro implementations which upload a
dump without actually crashing, and only
do so on the first DUMP-severity failure. A new DCHECK_IS_DUMP_WITHOUT_CRASHING
macro is introduced, to enable the new behaviour in DCHECK_IS_ON()[1] builds.

A new build argument, dump_on_first_dcheck, is set in the GN configuration to
enable the DCHECK_IS_DUMP_WITHOUT_CRASHING macro.

All non-DCHECK_IS_ON() behaviours, e.g. CHECK, PCHECK, SECURITY_CHECK, are
unchanged and continue to be mapped to the LOG_FATAL severity.

Dump-on-DCHECK will be enabled in one-off Canary builds by temporarily landing
this patch, and reverting it as soon as the Canary build has been cut.

BUG=596231
[1] DCHECK_IS_ON() is set in Debug builds, and Release builds with
DCHECK_ALWAYS_ON.
==========

[Wez, 2017-02-06 23:45:15]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 23:45:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 01:22:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 01:22:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Wez, 2017-02-11 08:39:37]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 08:39:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2017-02-11 08:41:02]

The CQ bit was unchecked by wez@chromium.org

[Wez, 2017-02-11 08:41:35]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 08:41:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 10:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 10:01:22]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Wez, 2017-02-19 01:55:21]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-19 01:55:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 03:16:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-19 03:16:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Wez, 2017-02-19 04:52:32]

Patchset #5 (id:80001) has been deleted

[Wez, 2017-02-19 04:52:45]

Patchset #9 (id:180001) has been deleted

[Wez, 2017-02-19 04:53:03]

Patchset #12 (id:260001) has been deleted

[Wez, 2017-02-19 04:53:16]

Patchset #15 (id:340001) has been deleted

[Wez, 2017-02-19 04:53:28]

Patchset #12 (id:280001) has been deleted

[Wez, 2017-02-19 04:53:46]

Patchset #12 (id:300001) has been deleted

[Wez, 2017-02-19 04:54:21]

Patchset #13 (id:360001) has been deleted

[Wez, 2017-02-19 05:11:16]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-19 05:11:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 07:07:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-19 07:07:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Wez, 2017-02-19 07:43:07]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-19 07:43:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 10:19:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-19 10:19:30]

Dry run: This issue passed the CQ dry run.

[Wez, 2017-02-23 06:10:29]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 06:10:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2017-02-23 06:26:04]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 06:26:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2017-02-23 06:33:20]

Folks, I've moved out dependent changes to a separate CL, so this should be the
minimal CL we need to land & revert to run the dump-on-DCHECK experiment.

thakis: PTAL & let me know if this looks OK to you - thanks.

[commit-bot: I haz the power, 2017-02-23 09:02:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 09:02:15]

Dry run: This issue passed the CQ dry run.