third_party/WebKit/Source/wtf/AssertionsTest.cpp - Issue 1884023002: Implement Dump-on-DCHECK (via alternate DCHECK and DCHECK_OP macro implementations).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/AssertionsTest.cpp

Issue 1884023002: Implement Dump-on-DCHECK (via alternate DCHECK and DCHECK_OP macro implementations). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on cleanups Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/wtf/AssertionsTest.cpp

diff --git a/third_party/WebKit/Source/wtf/AssertionsTest.cpp b/third_party/WebKit/Source/wtf/AssertionsTest.cpp

index 08a38c4b9c1801b1545bf469e394c245124146bb..bb4a3ee7d2237fdd73f5a942fe53594ad932b0fb 100644

--- a/third_party/WebKit/Source/wtf/AssertionsTest.cpp

+++ b/third_party/WebKit/Source/wtf/AssertionsTest.cpp

@@ -12,7 +12,7 @@ namespace WTF {

TEST(AssertionsTest, Assertions) {

ASSERT(true);

-#if DCHECK_IS_ON()

+#if DCHECK_IS_ON() && !defined(DCHECK_IS_DUMP_WITHOUT_CRASH)

EXPECT_DEATH_IF_SUPPORTED(ASSERT(false), "");

EXPECT_DEATH_IF_SUPPORTED(ASSERT_NOT_REACHED(), "");

EXPECT_DEATH_IF_SUPPORTED(DCHECK_AT(false, __FILE__, __LINE__), "");

« no previous file with comments | « third_party/WebKit/Source/wtf/Assertions.h ('k') | no next file » | no next file with comments »