Implement Dump-on-DCHECK (via alternate DCHECK and DCHECK_OP macro implementations).

base/logging_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/compiler_specific.h"
+#include "base/debug/dump_without_crashing.h"
 #include "base/macros.h"
 
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(OS_POSIX)
 #include <signal.h>
 #include <unistd.h>
 #include "base/posix/eintr_wrapper.h"
 #endif  // OS_POSIX
@@ skipping 77 matching lines @@
   DLOG_IF(INFO, true) << mock_log_source.Log();
   DPLOG(INFO) << mock_log_source.Log();
   DPLOG_IF(INFO, true) << mock_log_source.Log();
   DVLOG(0) << mock_log_source.Log();
   DVLOG_IF(0, true) << mock_log_source.Log();
   DVPLOG(0) << mock_log_source.Log();
   DVPLOG_IF(0, true) << mock_log_source.Log();
 }
 
 TEST_F(LoggingTest, LogIsOn) {
-#if defined(NDEBUG)
+#if defined(NDEBUG) || defined(DCHECK_IS_DUMP_WITHOUT_CRASH)
   const bool kDfatalIsFatal = false;
 #else  // defined(NDEBUG)
   const bool kDfatalIsFatal = true;
 #endif  // defined(NDEBUG)
 
   SetMinLogLevel(LOG_INFO);
   EXPECT_TRUE(LOG_IS_ON(INFO));
   EXPECT_TRUE(LOG_IS_ON(WARNING));
   EXPECT_TRUE(LOG_IS_ON(ERROR));
   EXPECT_TRUE(LOG_IS_ON(FATAL));
@@ skipping 258 matching lines @@
   DCHECK_EQ(0, 0) << mock_log_source.Log();
 #else
   DCHECK(mock_log_source.Log()) << mock_log_source.Log();
   DPCHECK(mock_log_source.Log()) << mock_log_source.Log();
   DCHECK_EQ(0, 0) << mock_log_source.Log();
   DCHECK_EQ(mock_log_source.Log(), static_cast<const char*>(NULL))
       << mock_log_source.Log();
 #endif
 }
 
+#if !defined(DCHECK_IS_DUMP_WITHOUT_CRASH)
 void DcheckEmptyFunction1() {
   // Provide a body so that Release builds do not cause the compiler to
   // optimize DcheckEmptyFunction1 and DcheckEmptyFunction2 as a single
   // function, which breaks the Dcheck tests below.
   LOG(INFO) << "DcheckEmptyFunction1";
 }
 void DcheckEmptyFunction2() {}
 
 TEST_F(LoggingTest, Dcheck) {
 #if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)
@@ skipping 55 matching lines @@
   EXPECT_EQ(0, g_log_sink_call_count);
   DCHECK_EQ(mp1, &MemberFunctions::MemberFunction1);
   EXPECT_EQ(0, g_log_sink_call_count);
   DCHECK_EQ(mp2, &MemberFunctions::MemberFunction2);
   EXPECT_EQ(0, g_log_sink_call_count);
   DCHECK_EQ(fp1, fp2);
   EXPECT_EQ(DCHECK_IS_ON() ? 1 : 0, g_log_sink_call_count);
   DCHECK_EQ(mp2, &MemberFunctions::MemberFunction1);
   EXPECT_EQ(DCHECK_IS_ON() ? 2 : 0, g_log_sink_call_count);
 }
+#endif  // !defined(DCHECK_IS_DUMP_WITHOUT_CRASH)
 
 TEST_F(LoggingTest, DcheckReleaseBehavior) {
   int some_variable = 1;
   // These should still reference |some_variable| so we don't get
   // unused variable warnings.
   DCHECK(some_variable) << "test";
   DPCHECK(some_variable) << "test";
   DCHECK_EQ(some_variable, 1) << "test";
 }
 
@@ skipping 14 matching lines @@
   if (false)
     CHECK_EQ(false, true);           // Unreached.
   else
     CHECK_EQ(true, reached = true);  // Reached, passed.
   ASSERT_TRUE(reached);
 
   if (false)
     CHECK_EQ(false, true);           // Unreached.
 }
 
+#if defined(DCHECK_IS_DUMP_WITHOUT_CRASH)
+namespace {
+
+int g_fake_dump_without_crashing_count = 0;
+void FakeDumpWithoutCrashing() {
+  g_fake_dump_without_crashing_count++;
+}
+
+}  // namespace
+
+TEST_F(LoggingTest, DCheckIsDumpWithoutCrash) {
+  // Replace the dump-without-crashing function, to test.
+  base::debug::SetDumpWithoutCrashingFunction(&FakeDumpWithoutCrashing);
+
+  // Invoke DCHECK(false) twice, and verify that only one dump call is made.
+  DCHECK(false);
+  EXPECT_EQ(1, g_fake_dump_without_crashing_count);
+  DCHECK(false);
+  EXPECT_EQ(1, g_fake_dump_without_crashing_count);
+
+  EXPECT_EQ(LOG_ERROR, LOG_DFATAL);
+
+  base::debug::SetDumpWithoutCrashingFunction(nullptr);
+}
+#endif  // defined(DCHECK_IS_DUMP_WITHOUT_CRASH)
+
 // Test that defining an operator<< for a type in a namespace doesn't prevent
 // other code in that namespace from calling the operator<<(ostream, wstring)
 // defined by logging.h. This can fail if operator<<(ostream, wstring) can't be
 // found by ADL, since defining another operator<< prevents name lookup from
 // looking in the global namespace.
 namespace nested_test {
   class Streamable {};
   ALLOW_UNUSED_TYPE std::ostream& operator<<(std::ostream& out,
                                              const Streamable&) {
     return out << "Streamable";
   }
   TEST_F(LoggingTest, StreamingWstringFindsCorrectOperator) {
     std::wstring wstr = L"Hello World";
     std::ostringstream ostr;
     ostr << wstr;
     EXPECT_EQ("Hello World", ostr.str());
   }
 }  // namespace nested_test
 
 }  // namespace
 
 }  // namespace logging