base/test/gtest_util.h - Issue 1884023002: Implement Dump-on-DCHECK (via alternate DCHECK and DCHECK_OP macro implementations).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/gtest_util.h

Issue 1884023002: Implement Dump-on-DCHECK (via alternate DCHECK and DCHECK_OP macro implementations). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on cleanups Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/test/gtest_util.h

diff --git a/base/test/gtest_util.h b/base/test/gtest_util.h

index 569e39bc4db8258f029396c519526ed1d7f79ff5..4b3151b4b0c73f449ce9a808f53f7b25c91221d3 100644

--- a/base/test/gtest_util.h

+++ b/base/test/gtest_util.h

@@ -21,7 +21,8 @@

// happen and as such executing the statement results in undefined behavior

// (|statement| is compiled in unsupported configurations nonetheless).

// Death tests misbehave on Android.

-#if DCHECK_IS_ON() && defined(GTEST_HAS_DEATH_TEST) && !defined(OS_ANDROID)

+#if DCHECK_IS_ON() && defined(GTEST_HAS_DEATH_TEST) && !defined(OS_ANDROID) && \

+ !defined(DCHECK_IS_DUMP_WITHOUT_CRASH)

// EXPECT/ASSERT_DCHECK_DEATH tests verify that a DCHECK is hit ("Check failed"

// is part of the error message), but intentionally do not expose the gtest

« no previous file with comments | « base/logging_unittest.cc ('k') | build/config/BUILD.gn » ('j') | no next file with comments »