Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1882423004: Move shell service to toplevel shell namespace (Closed)

Created:
4 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-worker-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, horo+watch_chromium.org, jam, jochen+watch_chromium.org, jsbell+serviceworker_chromium.org, jshin+watch_chromium.org, kalyank, kinuko+watch, kinuko+serviceworker, lcwu+watch_chromium.org, mcasas+watch+vc_chromium.org, michaeln, mkwst+moarreviews-shell_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nhiroki, oshima+watch_chromium.org, Peter Beverloo, posciak+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sadrul, serviceworker-reviews, tfarina, tzik, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move shell service to toplevel shell namespace Also scoped_ptr -> unique_ptr in //services/shell since this has to touch all that code anyway. BUG=None R=ben@chromium.org TBR=tsepez@chromium.org for mojom (renaming some things) CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/b00e6460e79343f73cedf548e70cd1a71308f917 Cr-Commit-Position: refs/heads/master@{#387208}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1854 lines, -1918 lines) Patch
M ash/mus/keyboard_ui_mus.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/mus/keyboard_ui_mus.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/mus/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/shelf_delegate_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/sysui_application.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/mus/sysui_application.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/app/mash/mash_runner.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 8 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/chrome_interface_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/chrome_interface_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/test/base/mojo_test_connector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 12 chunks +25 lines, -26 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chromecast/browser/media/cast_mojo_media_application.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chromecast/browser/media/cast_mojo_media_application.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/file_system_app.h View 2 chunks +7 lines, -6 lines 0 comments Download
M components/filesystem/file_system_app.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/filesystem/file_system_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/files_test_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/cpp/prefs/pref_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/cpp/prefs/pref_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/font_service_app.h View 1 chunk +8 lines, -7 lines 0 comments Download
M components/font_service/font_service_app.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/font_service/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/public/cpp/font_loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/font_service/public/cpp/font_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/leveldb_app.h View 1 chunk +6 lines, -6 lines 0 comments Download
M components/leveldb/leveldb_app.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/leveldb/leveldb_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/remote_iterator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/demo/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/demo/mus_demo.h View 3 chunks +6 lines, -6 lines 0 comments Download
M components/mus/demo/mus_demo.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/mus_app.h View 3 chunks +28 lines, -26 lines 0 comments Download
M components/mus/mus_app.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_server_shelltest_base.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_shelltest_base.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/window_tree_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/window_tree_host_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/display.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/mus/ws/platform_display.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/platform_display_init_params.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/user_id_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_manager_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_client_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/resource_provider/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/public/cpp/resource_loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/resource_provider_app.h View 1 chunk +8 lines, -7 lines 0 comments Download
M components/resource_provider/resource_provider_app.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/resource_provider/resource_provider_test_app.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M components/resource_provider/resource_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_context.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/frame_mojo_shell.h View 1 chunk +12 lines, -13 lines 0 comments Download
M content/browser/frame_host/frame_mojo_shell.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/mojo/browser_shell_connection.h View 2 chunks +14 lines, -15 lines 0 comments Download
M content/browser/mojo/browser_shell_connection.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M content/browser/mojo/mojo_app_connection_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_app_connection_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.cc View 5 chunks +17 lines, -21 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 7 chunks +22 lines, -23 lines 0 comments Download
M content/browser/mojo_shell_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/child/mojo/mojo_application.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/process_control_impl.h View 3 chunks +2 lines, -4 lines 0 comments Download
M content/child/process_control_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/application_setup.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/mojo/embedded_application_runner.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/mojo/embedded_application_runner.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 3 chunks +7 lines, -8 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M content/common/mojo/service_registry_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/mojo/service_registry_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/common/mojo/static_loader.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/common/mojo/static_loader.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/process_control.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/common/render_frame_setup.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/service_worker/embedded_worker_setup.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/mojo_shell_connection.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/public/test/test_mojo_app.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/public/test/test_mojo_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/utility/content_utility_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/media_interface_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/media_interface_provider.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.h View 4 chunks +5 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +8 lines, -10 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 6 chunks +12 lines, -13 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_mojo_test_utils_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/utility/shell_content_utility_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/mojo/stash_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.h View 2 chunks +6 lines, -5 lines 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/browser_driver/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/common/mus_views_init.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/example/views_examples/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.h View 1 chunk +5 lines, -4 lines 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mash/example/window_type_launcher/main.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 3 chunks +37 lines, -27 lines 0 comments Download
M mash/init/init.h View 2 chunks +11 lines, -10 lines 0 comments Download
M mash/init/init.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M mash/init/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/login/login.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/login/login.cc View 7 chunks +15 lines, -14 lines 0 comments Download
M mash/login/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/quick_launch/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/quick_launch/quick_launch_application.h View 1 chunk +5 lines, -5 lines 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mash/screenlock/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mash/screenlock/screenlock.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mash/session/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/session/session.h View 3 chunks +10 lines, -10 lines 0 comments Download
M mash/session/session.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mash/task_viewer/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mash/task_viewer/task_viewer.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M mash/wm/accelerator_registrar_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/wm/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/non_client_frame_controller.h View 3 chunks +6 lines, -6 lines 0 comments Download
M mash/wm/non_client_frame_controller.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M mash/wm/root_window_controller.h View 2 chunks +5 lines, -5 lines 0 comments Download
M mash/wm/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_application.h View 3 chunks +11 lines, -10 lines 0 comments Download
M mash/wm/window_manager_application.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mash/wm/window_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/android_mojo_media_client.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/android_mojo_media_client.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/mojo/services/default_mojo_media_client.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/default_mojo_media_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/media_apptest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_cdm_factory.h View 2 chunks +2 lines, -5 lines 0 comments Download
M media/mojo/services/mojo_cdm_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_decoder_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_decoder_factory.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_media_application.h View 2 chunks +10 lines, -10 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_media_application_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_media_application_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_media_client.h View 2 chunks +1 line, -3 lines 0 comments Download
M media/mojo/services/mojo_media_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_factory.h View 3 chunks +2 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/service_factory_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/mojo/services/service_factory_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/test_mojo_media_client.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/test_mojo_media_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M services/catalog/catalog.h View 4 chunks +5 lines, -5 lines 0 comments Download
M services/catalog/catalog.cc View 4 chunks +16 lines, -17 lines 0 comments Download
M services/catalog/entry.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/catalog/entry.cc View 7 chunks +12 lines, -16 lines 0 comments Download
M services/catalog/entry_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/catalog/factory.h View 4 chunks +17 lines, -18 lines 0 comments Download
M services/catalog/factory.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M services/shell/background/background_shell.h View 5 chunks +4 lines, -6 lines 0 comments Download
M services/shell/background/background_shell.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M services/shell/background/background_shell_main.cc View 2 chunks +1 line, -3 lines 0 comments Download
M services/shell/background/tests/background_shell_unittest.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M services/shell/background/tests/test.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/background/tests/test_catalog_store.h View 1 chunk +5 lines, -7 lines 0 comments Download
M services/shell/background/tests/test_catalog_store.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M services/shell/background/tests/test_service.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M services/shell/connect_params.h View 3 chunks +12 lines, -16 lines 0 comments Download
M services/shell/connect_params.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M services/shell/connect_util.h View 2 chunks +8 lines, -11 lines 0 comments Download
M services/shell/connect_util.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M services/shell/loader.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/native_runner.h View 3 chunks +5 lines, -6 lines 0 comments Download
M services/shell/native_runner_delegate.h View 2 chunks +1 line, -3 lines 0 comments Download
M services/shell/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/public/cpp/application_runner.h View 4 chunks +7 lines, -6 lines 0 comments Download
M services/shell/public/cpp/application_test_base.h View 5 chunks +9 lines, -8 lines 0 comments Download
M services/shell/public/cpp/capabilities.h View 2 chunks +17 lines, -9 lines 0 comments Download
M services/shell/public/cpp/connect.h View 1 chunk +6 lines, -6 lines 0 comments Download
M services/shell/public/cpp/connection.h View 7 chunks +10 lines, -10 lines 0 comments Download
M services/shell/public/cpp/connector.h View 4 chunks +18 lines, -15 lines 0 comments Download
M services/shell/public/cpp/identity.h View 2 chunks +10 lines, -5 lines 0 comments Download
M services/shell/public/cpp/initialize_base_and_icu.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/shell/public/cpp/interface_binder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/shell/public/cpp/interface_factory.h View 2 chunks +3 lines, -5 lines 0 comments Download
M services/shell/public/cpp/interface_factory_impl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M services/shell/public/cpp/interface_registry.h View 7 chunks +12 lines, -12 lines 0 comments Download
M services/shell/public/cpp/lib/application_runner.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M services/shell/public/cpp/lib/application_test_base.cc View 6 chunks +21 lines, -22 lines 0 comments Download
M services/shell/public/cpp/lib/application_test_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/lib/capabilities.cc View 4 chunks +20 lines, -17 lines 0 comments Download
M services/shell/public/cpp/lib/connection_impl.h View 4 chunks +5 lines, -5 lines 0 comments Download
M services/shell/public/cpp/lib/connection_impl.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M services/shell/public/cpp/lib/connector_impl.h View 1 chunk +12 lines, -10 lines 0 comments Download
M services/shell/public/cpp/lib/connector_impl.cc View 3 chunks +32 lines, -29 lines 0 comments Download
M services/shell/public/cpp/lib/identity.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M services/shell/public/cpp/lib/init_commandline.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/shell/public/cpp/lib/interface_factory_binder.h View 3 chunks +7 lines, -7 lines 0 comments Download
M services/shell/public/cpp/lib/interface_registry.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M services/shell/public/cpp/lib/message_loop_ref.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M services/shell/public/cpp/lib/names.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/lib/shell_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/lib/shell_connection.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M services/shell/public/cpp/lib/shell_test.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M services/shell/public/cpp/message_loop_ref.h View 4 chunks +6 lines, -5 lines 0 comments Download
M services/shell/public/cpp/names.h View 2 chunks +2 lines, -2 lines 0 comments Download
D services/shell/public/cpp/shell.h View 1 chunk +0 lines, -16 lines 0 comments Download
M services/shell/public/cpp/shell_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/shell_connection.h View 4 chunks +38 lines, -39 lines 0 comments Download
M services/shell/public/cpp/shell_test.h View 6 chunks +12 lines, -11 lines 0 comments Download
M services/shell/public/cpp/tests/interface_registry_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M services/shell/public/interfaces/capabilities.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/interfaces/connector.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/interfaces/interface_provider.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/interfaces/shell.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/interfaces/shell_client.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/interfaces/shell_client_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/interfaces/shell_resolver.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/child/native_apptest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M services/shell/runner/child/native_apptest_target.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M services/shell/runner/child/test_native_main.h View 1 chunk +3 lines, -4 lines 0 comments Download
M services/shell/runner/child/test_native_main.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M services/shell/runner/child/test_native_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/common/client_util.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/runner/common/client_util.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M services/shell/runner/host/child_process.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/shell/runner/host/child_process.cc View 7 chunks +7 lines, -11 lines 0 comments Download
M services/shell/runner/host/child_process_base.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/runner/host/child_process_base.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M services/shell/runner/host/child_process_host.h View 6 chunks +5 lines, -7 lines 0 comments Download
M services/shell/runner/host/child_process_host.cc View 5 chunks +3 lines, -5 lines 0 comments Download
M services/shell/runner/host/child_process_host_unittest.cc View 6 chunks +5 lines, -6 lines 0 comments Download
M services/shell/runner/host/host_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/runner/host/in_process_native_runner.h View 5 chunks +5 lines, -6 lines 0 comments Download
M services/shell/runner/host/in_process_native_runner.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M services/shell/runner/host/in_process_native_runner_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/runner/host/linux_sandbox.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/runner/host/linux_sandbox.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/runner/host/mach_broker.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/runner/host/mach_broker.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/runner/host/native_application_support.h View 2 chunks +1 line, -4 lines 0 comments Download
M services/shell/runner/host/native_application_support.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M services/shell/runner/host/out_of_process_native_runner.h View 4 chunks +3 lines, -5 lines 0 comments Download
M services/shell/runner/host/out_of_process_native_runner.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M services/shell/runner/init.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/runner/init.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/shell.h View 11 chunks +16 lines, -16 lines 0 comments Download
M services/shell/shell.cc View 18 chunks +30 lines, -29 lines 0 comments Download
M services/shell/shell.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/standalone/context.h View 5 chunks +9 lines, -10 lines 0 comments Download
M services/shell/standalone/context.cc View 10 chunks +25 lines, -28 lines 0 comments Download
M services/shell/standalone/desktop/launcher_process.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/shell/standalone/desktop/launcher_process.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/standalone/desktop/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/standalone/desktop/main_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/shell/standalone/desktop/main_helper.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/standalone/tracer.h View 4 chunks +2 lines, -3 lines 0 comments Download
M services/shell/standalone/tracer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/shell/switches.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/switches.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/tests/connect/connect_test.mojom View 3 chunks +4 lines, -4 lines 0 comments Download
M services/shell/tests/connect/connect_test_app.cc View 8 chunks +17 lines, -15 lines 0 comments Download
M services/shell/tests/connect/connect_test_app_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_class_app.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M services/shell/tests/connect/connect_test_class_app_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_driver.cc View 5 chunks +21 lines, -20 lines 0 comments Download
M services/shell/tests/connect/connect_test_exe.cc View 3 chunks +13 lines, -12 lines 0 comments Download
M services/shell/tests/connect/connect_test_package.cc View 8 chunks +17 lines, -16 lines 0 comments Download
M services/shell/tests/connect/connect_test_singleton_app.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M services/shell/tests/connect/connect_unittest.cc View 28 chunks +46 lines, -39 lines 0 comments Download
M services/shell/tests/connect/connect_unittests_manifest.json View 1 chunk +8 lines, -8 lines 0 comments Download
M services/shell/tests/lifecycle/app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/tests/lifecycle/app_client.h View 3 chunks +8 lines, -8 lines 0 comments Download
M services/shell/tests/lifecycle/app_client.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M services/shell/tests/lifecycle/lifecycle_exe.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/shell/tests/lifecycle/lifecycle_unittest.cc View 10 chunks +17 lines, -14 lines 0 comments Download
M services/shell/tests/lifecycle/lifecycle_unittest.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/lifecycle/package.cc View 7 chunks +25 lines, -24 lines 0 comments Download
M services/shell/tests/lifecycle/parent.cc View 5 chunks +17 lines, -15 lines 0 comments Download
M services/shell/tests/lifecycle/parent_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/loader_unittest.cc View 19 chunks +45 lines, -46 lines 0 comments Download
M services/shell/tests/shell/driver.cc View 7 chunks +22 lines, -21 lines 0 comments Download
M services/shell/tests/shell/shell_unittest.cc View 9 chunks +19 lines, -18 lines 0 comments Download
M services/shell/tests/shell/shell_unittest.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/shell/target.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M services/shell/tests/shell/target_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/test.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/util.h View 1 chunk +5 lines, -7 lines 0 comments Download
M services/shell/tests/util.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M services/tracing/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/public/cpp/tracing_impl.h View 2 chunks +8 lines, -6 lines 0 comments Download
M services/tracing/public/cpp/tracing_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/tracing/tracing_app.h View 1 chunk +9 lines, -9 lines 0 comments Download
M services/tracing/tracing_app.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/user/user_service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/user/user_shell_client.h View 2 chunks +11 lines, -10 lines 0 comments Download
M services/user/user_shell_client.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/harness-tests/mojo-helpers.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/aura_init.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/mus/aura_init.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/platform_test_helper_mus.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M ui/views/mus/platform_window_mus.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/screen_mus.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/screen_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/surface_binding.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/mus/surface_binding.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/surface_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.h View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
Ken Rockot(use gerrit already)
4 years, 8 months ago (2016-04-13 23:37:06 UTC) #5
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-13 23:41:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882423004/1
4 years, 8 months ago (2016-04-13 23:43:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882423004/20001
4 years, 8 months ago (2016-04-13 23:54:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882423004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882423004/40001
4 years, 8 months ago (2016-04-14 00:40:06 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-14 02:24:17 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 02:25:19 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b00e6460e79343f73cedf548e70cd1a71308f917
Cr-Commit-Position: refs/heads/master@{#387208}

Powered by Google App Engine
This is Rietveld 408576698