Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1610)

Unified Diff: services/shell/runner/host/child_process.cc

Issue 1882423004: Move shell service to toplevel shell namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shell/runner/host/child_process.h ('k') | services/shell/runner/host/child_process_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/shell/runner/host/child_process.cc
diff --git a/services/shell/runner/host/child_process.cc b/services/shell/runner/host/child_process.cc
index d09292102bc9cad9a92825da80f4050614519143..1cb8ce1e2fb66b70323a2edbf77f25eba9daf996 100644
--- a/services/shell/runner/host/child_process.cc
+++ b/services/shell/runner/host/child_process.cc
@@ -6,6 +6,7 @@
#include <stdint.h>
+#include <memory>
#include <utility>
#include "base/base_switches.h"
@@ -19,7 +20,6 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
-#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/single_thread_task_runner.h"
#include "base/synchronization/waitable_event.h"
@@ -48,13 +48,12 @@
#include "services/shell/runner/host/mach_broker.h"
#endif
-namespace mojo {
namespace shell {
namespace {
#if defined(OS_LINUX) && !defined(OS_ANDROID)
-scoped_ptr<mojo::shell::LinuxSandbox> InitializeSandbox() {
+std::unique_ptr<LinuxSandbox> InitializeSandbox() {
using sandbox::syscall_broker::BrokerFilePermission;
// Warm parts of base in the copy of base in the mojo runner.
base::RandUint64();
@@ -69,8 +68,7 @@ scoped_ptr<mojo::shell::LinuxSandbox> InitializeSandbox() {
std::vector<BrokerFilePermission> permissions;
permissions.push_back(
BrokerFilePermission::ReadWriteCreateUnlinkRecursive("/dev/shm/"));
- scoped_ptr<mojo::shell::LinuxSandbox> sandbox(
- new mojo::shell::LinuxSandbox(permissions));
+ std::unique_ptr<LinuxSandbox> sandbox(new LinuxSandbox(permissions));
sandbox->Warmup();
sandbox->EngageNamespaceSandbox();
sandbox->EngageSeccompSandbox();
@@ -79,9 +77,8 @@ scoped_ptr<mojo::shell::LinuxSandbox> InitializeSandbox() {
}
#endif
-void RunNativeLibrary(
- base::NativeLibrary app_library,
- InterfaceRequest<mojom::ShellClient> shell_client_request) {
+void RunNativeLibrary(base::NativeLibrary app_library,
+ mojom::ShellClientRequest shell_client_request) {
if (!RunNativeApplication(app_library, std::move(shell_client_request))) {
LOG(ERROR) << "Failure to RunNativeApplication()";
}
@@ -95,14 +92,14 @@ int ChildProcessMain() {
*base::CommandLine::ForCurrentProcess();
#if defined(OS_LINUX) && !defined(OS_ANDROID)
- scoped_ptr<mojo::shell::LinuxSandbox> sandbox;
+ std::unique_ptr<LinuxSandbox> sandbox;
#endif
base::NativeLibrary app_library = 0;
// Load the application library before we engage the sandbox.
base::FilePath app_library_path =
command_line.GetSwitchValuePath(switches::kChildProcess);
if (!app_library_path.empty())
- app_library = mojo::shell::LoadNativeApplication(app_library_path);
+ app_library = LoadNativeApplication(app_library_path);
base::i18n::InitializeICU();
if (app_library)
CallLibraryEarlyInitialization(app_library);
@@ -128,4 +125,3 @@ int ChildProcessMain() {
}
} // namespace shell
-} // namespace mojo
« no previous file with comments | « services/shell/runner/host/child_process.h ('k') | services/shell/runner/host/child_process_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698