Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: services/catalog/entry_unittest.cc

Issue 1882423004: Move shell service to toplevel shell namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/catalog/entry.cc ('k') | services/catalog/factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/catalog/entry.h" 5 #include "services/catalog/entry.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/json/json_file_value_serializer.h" 8 #include "base/json/json_file_value_serializer.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 private: 49 private:
50 void SetUp() override {} 50 void SetUp() override {}
51 void TearDown() override {} 51 void TearDown() override {}
52 52
53 DISALLOW_COPY_AND_ASSIGN(EntryTest); 53 DISALLOW_COPY_AND_ASSIGN(EntryTest);
54 }; 54 };
55 55
56 TEST_F(EntryTest, Simple) { 56 TEST_F(EntryTest, Simple) {
57 scoped_ptr<Entry> entry = ReadEntry("simple", nullptr); 57 scoped_ptr<Entry> entry = ReadEntry("simple", nullptr);
58 EXPECT_EQ("mojo:foo", entry->name()); 58 EXPECT_EQ("mojo:foo", entry->name());
59 EXPECT_EQ(mojo::GetNamePath(entry->name()), entry->qualifier()); 59 EXPECT_EQ(shell::GetNamePath(entry->name()), entry->qualifier());
60 EXPECT_EQ("Foo", entry->display_name()); 60 EXPECT_EQ("Foo", entry->display_name());
61 } 61 }
62 62
63 TEST_F(EntryTest, Instance) { 63 TEST_F(EntryTest, Instance) {
64 scoped_ptr<Entry> entry = ReadEntry("instance", nullptr); 64 scoped_ptr<Entry> entry = ReadEntry("instance", nullptr);
65 EXPECT_EQ("mojo:foo", entry->name()); 65 EXPECT_EQ("mojo:foo", entry->name());
66 EXPECT_EQ("bar", entry->qualifier()); 66 EXPECT_EQ("bar", entry->qualifier());
67 EXPECT_EQ("Foo", entry->display_name()); 67 EXPECT_EQ("Foo", entry->display_name());
68 } 68 }
69 69
70 TEST_F(EntryTest, Capabilities) { 70 TEST_F(EntryTest, Capabilities) {
71 scoped_ptr<Entry> entry = ReadEntry("capabilities", nullptr); 71 scoped_ptr<Entry> entry = ReadEntry("capabilities", nullptr);
72 72
73 EXPECT_EQ("mojo:foo", entry->name()); 73 EXPECT_EQ("mojo:foo", entry->name());
74 EXPECT_EQ("bar", entry->qualifier()); 74 EXPECT_EQ("bar", entry->qualifier());
75 EXPECT_EQ("Foo", entry->display_name()); 75 EXPECT_EQ("Foo", entry->display_name());
76 mojo::CapabilitySpec spec; 76 shell::CapabilitySpec spec;
77 mojo::CapabilityRequest request; 77 shell::CapabilityRequest request;
78 request.interfaces.insert("mojo::Bar"); 78 request.interfaces.insert("mojo::Bar");
79 spec.required["mojo:bar"] = request; 79 spec.required["mojo:bar"] = request;
80 EXPECT_EQ(spec, entry->capabilities()); 80 EXPECT_EQ(spec, entry->capabilities());
81 } 81 }
82 82
83 TEST_F(EntryTest, Serialization) { 83 TEST_F(EntryTest, Serialization) {
84 scoped_ptr<base::Value> value; 84 scoped_ptr<base::Value> value;
85 scoped_ptr<Entry> entry = ReadEntry("serialization", &value); 85 scoped_ptr<Entry> entry = ReadEntry("serialization", &value);
86 86
87 scoped_ptr<base::DictionaryValue> serialized(entry->Serialize()); 87 scoped_ptr<base::DictionaryValue> serialized(entry->Serialize());
88 88
89 // We can't just compare values, since during deserialization some of the 89 // We can't just compare values, since during deserialization some of the
90 // lists get converted to std::sets, which are sorted, so Value::Equals will 90 // lists get converted to std::sets, which are sorted, so Value::Equals will
91 // fail. 91 // fail.
92 scoped_ptr<Entry> reconstituted = Entry::Deserialize(*serialized.get()); 92 scoped_ptr<Entry> reconstituted = Entry::Deserialize(*serialized.get());
93 EXPECT_EQ(*entry, *reconstituted); 93 EXPECT_EQ(*entry, *reconstituted);
94 } 94 }
95 95
96 TEST_F(EntryTest, Malformed) { 96 TEST_F(EntryTest, Malformed) {
97 scoped_ptr<base::Value> value = ReadManifest("malformed"); 97 scoped_ptr<base::Value> value = ReadManifest("malformed");
98 EXPECT_FALSE(value.get()); 98 EXPECT_FALSE(value.get());
99 } 99 }
100 100
101 101
102 } // namespace catalog 102 } // namespace catalog
OLDNEW
« no previous file with comments | « services/catalog/entry.cc ('k') | services/catalog/factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698