Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Side by Side Diff: services/shell/runner/host/native_application_support.cc

Issue 1882423004: Move shell service to toplevel shell namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/shell/runner/host/native_application_support.h" 5 #include "services/shell/runner/host/native_application_support.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "base/files/file_util.h" 11 #include "base/files/file_util.h"
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "mojo/platform_handle/platform_handle_private_thunks.h" 13 #include "mojo/platform_handle/platform_handle_private_thunks.h"
14 #include "mojo/public/platform/native/system_thunks.h" 14 #include "mojo/public/platform/native/system_thunks.h"
15 15
16 namespace mojo {
17 namespace shell { 16 namespace shell {
18 17
19 namespace { 18 namespace {
20 19
21 template <typename Thunks> 20 template <typename Thunks>
22 bool SetThunks(Thunks (*make_thunks)(), 21 bool SetThunks(Thunks (*make_thunks)(),
23 const char* function_name, 22 const char* function_name,
24 base::NativeLibrary library) { 23 base::NativeLibrary library) {
25 typedef size_t (*SetThunksFn)(const Thunks* thunks); 24 typedef size_t (*SetThunksFn)(const Thunks* thunks);
26 SetThunksFn set_thunks = reinterpret_cast<SetThunksFn>( 25 SetThunksFn set_thunks = reinterpret_cast<SetThunksFn>(
(...skipping 15 matching lines...) Expand all
42 base::NativeLibrary LoadNativeApplication(const base::FilePath& app_path) { 41 base::NativeLibrary LoadNativeApplication(const base::FilePath& app_path) {
43 DVLOG(2) << "Loading Mojo app in process from library: " << app_path.value(); 42 DVLOG(2) << "Loading Mojo app in process from library: " << app_path.value();
44 43
45 base::NativeLibraryLoadError error; 44 base::NativeLibraryLoadError error;
46 base::NativeLibrary app_library = base::LoadNativeLibrary(app_path, &error); 45 base::NativeLibrary app_library = base::LoadNativeLibrary(app_path, &error);
47 LOG_IF(ERROR, !app_library) 46 LOG_IF(ERROR, !app_library)
48 << "Failed to load app library (path: " << app_path.value() << ")"; 47 << "Failed to load app library (path: " << app_path.value() << ")";
49 return app_library; 48 return app_library;
50 } 49 }
51 50
52 bool RunNativeApplication( 51 bool RunNativeApplication(base::NativeLibrary app_library,
53 base::NativeLibrary app_library, 52 mojom::ShellClientRequest request) {
54 InterfaceRequest<mojom::ShellClient> request) {
55 // Tolerate |app_library| being null, to make life easier for callers. 53 // Tolerate |app_library| being null, to make life easier for callers.
56 if (!app_library) 54 if (!app_library)
57 return false; 55 return false;
58 56
59 // Thunks aren't needed/used in component build, since the thunked methods 57 // Thunks aren't needed/used in component build, since the thunked methods
60 // just live in their own dynamically loaded library. 58 // just live in their own dynamically loaded library.
61 #if !defined(COMPONENT_BUILD) 59 #if !defined(COMPONENT_BUILD)
62 if (!SetThunks(&MojoMakeSystemThunks, "MojoSetSystemThunks", app_library)) { 60 if (!SetThunks(&MojoMakeSystemThunks, "MojoSetSystemThunks", app_library)) {
63 LOG(ERROR) << "MojoSetSystemThunks not found"; 61 LOG(ERROR) << "MojoSetSystemThunks not found";
64 return false; 62 return false;
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 // |MojoMain()| takes ownership of the service handle. 97 // |MojoMain()| takes ownership of the service handle.
100 MojoHandle handle = request.PassMessagePipe().release().value(); 98 MojoHandle handle = request.PassMessagePipe().release().value();
101 MojoResult result = main_function(handle); 99 MojoResult result = main_function(handle);
102 if (result != MOJO_RESULT_OK) { 100 if (result != MOJO_RESULT_OK) {
103 LOG(ERROR) << "MojoMain returned error (result: " << result << ")"; 101 LOG(ERROR) << "MojoMain returned error (result: " << result << ")";
104 } 102 }
105 return true; 103 return true;
106 } 104 }
107 105
108 } // namespace shell 106 } // namespace shell
109 } // namespace mojo
OLDNEW
« no previous file with comments | « services/shell/runner/host/native_application_support.h ('k') | services/shell/runner/host/out_of_process_native_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698