Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1882043004: Remove implicit cast from CFX_WideString to (const wchar_t*) (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove implicit cast from CFX_WideString to (const wchar_t*) BUG= Committed: https://pdfium.googlesource.com/pdfium/+/bd9748d504555f100d34025d76a9e0119986bc3f

Patch Set 1 #

Patch Set 2 : win error #1 #

Patch Set 3 : win error #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -345 lines) Patch
M core/fpdfdoc/doc_formfield.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/fxcrt/extension.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_arabic.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxcrt/include/fx_string.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/public_methods_embeddertest.cpp View 1 chunk +16 lines, -16 lines 0 comments Download
M fpdfsdk/javascript/util.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fde/css/fde_cssstyleselector.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fde/css/fde_cssstylesheet.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fde/tto/fde_textout.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.cpp View 17 chunks +32 lines, -32 lines 0 comments Download
M xfa/fee/fde_txtedtengine.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/font/fgas_fontutils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/localization/fgas_locale.cpp View 72 chunks +90 lines, -115 lines 0 comments Download
M xfa/fgas/localization/fgas_localemgr.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 2 23 chunks +30 lines, -28 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fmparse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_imp.cpp View 3 chunks +11 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 2 21 chunks +45 lines, -36 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_utils_imp.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, for review. Wide version of previous CL.
4 years, 8 months ago (2016-04-13 22:51:22 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-14 04:39:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882043004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882043004/40001
4 years, 8 months ago (2016-04-14 04:39:57 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 04:40:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/bd9748d504555f100d34025d76a9e0119986...

Powered by Google App Engine
This is Rietveld 408576698