fpdfsdk/javascript/PublicMethods.cpp - Issue 1882043004: Remove implicit cast from CFX_WideString to (const wchar_t*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/PublicMethods.cpp

Issue 1882043004: Remove implicit cast from CFX_WideString to (const wchar_t*) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: win error #2 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/javascript/PublicMethods.cpp

diff --git a/fpdfsdk/javascript/PublicMethods.cpp b/fpdfsdk/javascript/PublicMethods.cpp

index d03f67159900a75b6a1ffe69546090b441cf2744..9f7b60f70d62665003f3d8108c49b8d973483b53 100644

--- a/fpdfsdk/javascript/PublicMethods.cpp

+++ b/fpdfsdk/javascript/PublicMethods.cpp

@@ -1654,7 +1654,7 @@ FX_BOOL CJS_PublicMethods::AFMakeNumber(IJS_Context* cc,

}

CFX_WideString ws = params[0].ToCFXWideString();

ws.Replace(L",", L".");

- vRet = ws;

+ vRet = ws.c_str();

vRet.MaybeCoerceToNumber();

if (vRet.GetType() != CJS_Value::VT_number)

vRet = 0;

« no previous file with comments | « fpdfsdk/fsdk_baseform.cpp ('k') | fpdfsdk/javascript/public_methods_embeddertest.cpp » ('j') | no next file with comments »