xfa/fxfa/app/xfa_fftextedit.cpp - Issue 1882043004: Remove implicit cast from CFX_WideString to (const wchar_t*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_fftextedit.cpp

Issue 1882043004: Remove implicit cast from CFX_WideString to (const wchar_t*) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: win error #2 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/app/xfa_fftextedit.cpp

diff --git a/xfa/fxfa/app/xfa_fftextedit.cpp b/xfa/fxfa/app/xfa_fftextedit.cpp

index 982ee00896ee45cfc0b5cb4667997dbaed9225ad..3232dbdac2a5ef409907ad8e3802aae3a47587be 100644

--- a/xfa/fxfa/app/xfa_fftextedit.cpp

+++ b/xfa/fxfa/app/xfa_fftextedit.cpp

@@ -199,8 +199,7 @@ void CXFA_FFTextEdit::ValidateNumberField(const CFX_WideString& wsText) {

pAppProvider->LoadString(XFA_IDS_ValidateNumberError, wsError);

CFX_WideString wsSomField;

pAcc->GetNode()->GetSOMExpression(wsSomField);

- wsMessage.Format(wsError, (const FX_WCHAR*)wsText,

- (const FX_WCHAR*)wsSomField);

+ wsMessage.Format(wsError.c_str(), wsText.c_str(), wsSomField.c_str());

pAppProvider->MsgBox(wsMessage.AsStringC(), wsTitle.AsStringC(),

XFA_MBICON_Error, XFA_MB_OK);

}

« no previous file with comments | « xfa/fxfa/app/xfa_ffimageedit.cpp ('k') | xfa/fxfa/app/xfa_ffwidgetacc.cpp » ('j') | no next file with comments »