xfa/fgas/crt/fgas_stream.cpp - Issue 1882043004: Remove implicit cast from CFX_WideString to (const wchar_t*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fgas/crt/fgas_stream.cpp

Issue 1882043004: Remove implicit cast from CFX_WideString to (const wchar_t*) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: win error #2 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fgas/crt/fgas_stream.cpp

diff --git a/xfa/fgas/crt/fgas_stream.cpp b/xfa/fgas/crt/fgas_stream.cpp

index 1a3b23918472f03f6215a9753e5dc684cd34ae8b..7ee76fa4b43ed41a18c15e1921ea198d0ef1d954 100644

--- a/xfa/fgas/crt/fgas_stream.cpp

+++ b/xfa/fgas/crt/fgas_stream.cpp

@@ -388,7 +388,7 @@ FX_BOOL CFX_FileStreamImp::LoadFile(const FX_WCHAR* pszSrcFileName,

FXSYS_assert(pszSrcFileName != NULL && FXSYS_wcslen(pszSrcFileName) > 0);

#if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_ == _FX_WIN32_MOBILE_ || \

_FX_OS_ == _FX_WIN64_

- CFX_WideString wsMode;

+ const FX_WCHAR* wsMode;

if (dwAccess & FX_STREAMACCESS_Write) {

if (dwAccess & FX_STREAMACCESS_Append) {

wsMode = L"a+b";

« no previous file with comments | « xfa/fee/fde_txtedtengine.cpp ('k') | xfa/fgas/font/fgas_fontutils.cpp » ('j') | no next file with comments »