core/fpdfdoc/doc_formfield.cpp - Issue 1882043004: Remove implicit cast from CFX_WideString to (const wchar_t*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/doc_formfield.cpp

Issue 1882043004: Remove implicit cast from CFX_WideString to (const wchar_t*) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: win error #2 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfdoc/doc_formfield.cpp

diff --git a/core/fpdfdoc/doc_formfield.cpp b/core/fpdfdoc/doc_formfield.cpp

index 957352ecef412e32c546b0db37e84eed66ee46ee..7f0ff8716b054a9b07bf3749f550633f5cd4d767 100644

--- a/core/fpdfdoc/doc_formfield.cpp

+++ b/core/fpdfdoc/doc_formfield.cpp

@@ -724,7 +724,8 @@ int CPDF_FormField::InsertOption(CFX_WideString csOptLabel,

return -1;

}

- CFX_ByteString csStr = PDF_EncodeText(csOptLabel, csOptLabel.GetLength());

+ CFX_ByteString csStr =

+ PDF_EncodeText(csOptLabel.c_str(), csOptLabel.GetLength());

CPDF_Object* pValue = FPDF_GetFieldAttr(m_pDict, "Opt");

CPDF_Array* pOpt = ToArray(pValue);

if (!pOpt) {

« no previous file with comments | « no previous file | core/fxcrt/extension.h » ('j') | no next file with comments »