Rework build/mac/tweak_info_plist.py to not rely on environment variables.

Rework build/mac/tweak_info_plist.py to not rely on environment variables.

Instead, pass the --plist to tweak on the command line. This way the
script can be used in both GYP and GN builds.

There is one behavior change: previously passing --keystone=1 would only
insert the Keystone keys if env['CONFIGURATION']=='Release' and after this
change, the keys will be added regardless of the build configuration if the
flag is passed.

BUG=297668
Committed: https://crrev.com/adf34911dcb45fab4d7e13c4d7ef43e3dea840eb
Cr-Commit-Position: refs/heads/master@{#386854}

[Robert Sesek, 2016-04-12 16:46:18]

rsesek@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-04-12 19:07:04]

lgtm

https://codereview.chromium.org/1881053002/diff/1/build/mac/tweak_info_plist.py
File build/mac/tweak_info_plist.py (right):

https://codereview.chromium.org/1881053002/diff/1/build/mac/tweak_info_plist....
build/mac/tweak_info_plist.py:258: # Only add Keystone in Release builds.
update comment

[Robert Sesek, 2016-04-12 19:30:34]

https://codereview.chromium.org/1881053002/diff/1/build/mac/tweak_info_plist.py
File build/mac/tweak_info_plist.py (right):

https://codereview.chromium.org/1881053002/diff/1/build/mac/tweak_info_plist....
build/mac/tweak_info_plist.py:258: # Only add Keystone in Release builds.
On 2016/04/12 19:07:04, Nico wrote:
> update comment

Done.

[Robert Sesek, 2016-04-12 19:31:53]

rsesek@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Robert Sesek, 2016-04-12 19:31:54]

+rdevlin for //extensions OWNERS

[Robert Sesek, 2016-04-12 19:36:39]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 19:37:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881053002/20001

[commit-bot: I haz the power, 2016-04-12 21:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 21:11:12]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-04-12 23:09:35]

extensions lgtm

note: I'm not gyp expert, so I'm mostly trusting you/Nico.

[Robert Sesek, 2016-04-12 23:10:52]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2016-04-12 23:10:53]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1881053002/#ps20001
(title: "Comment")

[commit-bot: I haz the power, 2016-04-12 23:11:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881053002/20001

[commit-bot: I haz the power, 2016-04-12 23:20:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-12 23:21:28]

Description was changed from

==========
Rework build/mac/tweak_info_plist.py to not rely on environment variables.

Instead, pass the --plist to tweak on the command line. This way the
script can be used in both GYP and GN builds.

There is one behavior change: previously passing --keystone=1 would only
insert the Keystone keys if env['CONFIGURATION']=='Release' and after this
change, the keys will be added regardless of the build configuration if the
flag is passed.

BUG=297668
==========

to

==========
Rework build/mac/tweak_info_plist.py to not rely on environment variables.

Instead, pass the --plist to tweak on the command line. This way the
script can be used in both GYP and GN builds.

There is one behavior change: previously passing --keystone=1 would only
insert the Keystone keys if env['CONFIGURATION']=='Release' and after this
change, the keys will be added regardless of the build configuration if the
flag is passed.

BUG=297668

Committed: https://crrev.com/adf34911dcb45fab4d7e13c4d7ef43e3dea840eb
Cr-Commit-Position: refs/heads/master@{#386854}
==========

[commit-bot: I haz the power, 2016-04-12 23:21:29]

Patchset 2 (id:??) landed as
https://crrev.com/adf34911dcb45fab4d7e13c4d7ef43e3dea840eb
Cr-Commit-Position: refs/heads/master@{#386854}