Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: chrome/chrome_dll_bundle.gypi

Issue 1881053002: Rework build/mac/tweak_info_plist.py to not rely on environment variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains resources for the main Mac chromium bundle. 5 # This file contains resources for the main Mac chromium bundle.
6 { 6 {
7 # The main browser executable's name is <(mac_product_name). 7 # The main browser executable's name is <(mac_product_name).
8 # Certain things will get confused if two modules in the 8 # Certain things will get confused if two modules in the
9 # executable share the same name, so append " Framework" to the 9 # executable share the same name, so append " Framework" to the
10 # product_name used for the framework. This will result in 10 # product_name used for the framework. This will result in
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 { 107 {
108 # Modify the Info.plist as needed. The script explains why 108 # Modify the Info.plist as needed. The script explains why
109 # this is needed. This is also done in the chrome target. 109 # this is needed. This is also done in the chrome target.
110 # The framework needs the Breakpad keys if this feature is 110 # The framework needs the Breakpad keys if this feature is
111 # enabled. It does not need the Keystone keys; these always 111 # enabled. It does not need the Keystone keys; these always
112 # come from the outer application bundle. The framework 112 # come from the outer application bundle. The framework
113 # doesn't currently use the SCM keys for anything, 113 # doesn't currently use the SCM keys for anything,
114 # but this seems like a really good place to store them. 114 # but this seems like a really good place to store them.
115 'postbuild_name': 'Tweak Info.plist', 115 'postbuild_name': 'Tweak Info.plist',
116 'action': ['<(tweak_info_plist_path)', 116 'action': ['<(tweak_info_plist_path)',
117 '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',
117 '--breakpad=<(mac_breakpad_compiled_in)', 118 '--breakpad=<(mac_breakpad_compiled_in)',
118 '--breakpad_uploads=<(mac_breakpad_uploads)', 119 '--breakpad_uploads=<(mac_breakpad_uploads)',
119 '--keystone=0', 120 '--keystone=0',
120 '--scm=1', 121 '--scm=1',
121 '--branding=<(branding)'], 122 '--branding=<(branding)'],
122 }, 123 },
123 ], 124 ],
124 'copies': [ 125 'copies': [
125 { 126 {
126 'destination': '<(PRODUCT_DIR)/$(CONTENTS_FOLDER_PATH)/Helpers', 127 'destination': '<(PRODUCT_DIR)/$(CONTENTS_FOLDER_PATH)/Helpers',
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 ], 275 ],
275 }], 276 }],
276 ['v8_use_external_startup_data==1', { 277 ['v8_use_external_startup_data==1', {
277 'mac_bundle_resources': [ 278 'mac_bundle_resources': [
278 '<(PRODUCT_DIR)/natives_blob.bin', 279 '<(PRODUCT_DIR)/natives_blob.bin',
279 '<(PRODUCT_DIR)/snapshot_blob.bin', 280 '<(PRODUCT_DIR)/snapshot_blob.bin',
280 ], 281 ],
281 }], 282 }],
282 ], # conditions 283 ], # conditions
283 } 284 }
OLDNEW
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698