Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: extensions/shell/app_shell.gyp

Issue 1881053002: Rework build/mac/tweak_info_plist.py to not rely on environment variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/content_shell.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'app_shell.gypi', 7 'app_shell.gypi',
8 ], 8 ],
9 'variables': { 9 'variables': {
10 # Product name is used for Mac bundle. 10 # Product name is used for Mac bundle.
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 'action': [ 165 'action': [
166 '../../build/mac/copy_framework_unversioned.sh', 166 '../../build/mac/copy_framework_unversioned.sh',
167 '${BUILT_PRODUCTS_DIR}/<(app_shell_product_name) Framework.frame work', 167 '${BUILT_PRODUCTS_DIR}/<(app_shell_product_name) Framework.frame work',
168 '${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH}/Frameworks', 168 '${BUILT_PRODUCTS_DIR}/${CONTENTS_FOLDER_PATH}/Frameworks',
169 ], 169 ],
170 }, 170 },
171 { 171 {
172 # Modify the Info.plist as needed. 172 # Modify the Info.plist as needed.
173 'postbuild_name': 'Tweak Info.plist', 173 'postbuild_name': 'Tweak Info.plist',
174 'action': ['../../build/mac/tweak_info_plist.py', 174 'action': ['../../build/mac/tweak_info_plist.py',
175 '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',
175 '--scm=1', 176 '--scm=1',
176 '--version=<(app_shell_version)'], 177 '--version=<(app_shell_version)'],
177 }, 178 },
178 ], 179 ],
179 }], 180 }],
180 ], 181 ],
181 }, 182 },
182 { 183 {
183 'target_name': 'app_shell_unittests', 184 'target_name': 'app_shell_unittests',
184 'type': 'executable', 185 'type': 'executable',
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 { 301 {
301 # Modify the Info.plist as needed. The script explains why 302 # Modify the Info.plist as needed. The script explains why
302 # this is needed. This is also done in the chrome target. 303 # this is needed. This is also done in the chrome target.
303 # The framework needs the Breakpad keys if this feature is 304 # The framework needs the Breakpad keys if this feature is
304 # enabled. It does not need the Keystone keys; these always 305 # enabled. It does not need the Keystone keys; these always
305 # come from the outer application bundle. The framework 306 # come from the outer application bundle. The framework
306 # doesn't currently use the SCM keys for anything, 307 # doesn't currently use the SCM keys for anything,
307 # but this seems like a really good place to store them. 308 # but this seems like a really good place to store them.
308 'postbuild_name': 'Tweak Info.plist', 309 'postbuild_name': 'Tweak Info.plist',
309 'action': ['../../build/mac/tweak_info_plist.py', 310 'action': ['../../build/mac/tweak_info_plist.py',
311 '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',
310 '--breakpad=1', 312 '--breakpad=1',
311 '--keystone=0', 313 '--keystone=0',
312 '--scm=1', 314 '--scm=1',
313 '--version=<(app_shell_version)', 315 '--version=<(app_shell_version)',
314 '--branding=<(app_shell_product_name)'], 316 '--branding=<(app_shell_product_name)'],
315 }, 317 },
316 ], 318 ],
317 'conditions': [ 319 'conditions': [
318 ['icu_use_data_file_flag==1', { 320 ['icu_use_data_file_flag==1', {
319 'mac_bundle_resources': [ 321 'mac_bundle_resources': [
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 ], 374 ],
373 }, 375 },
374 { 376 {
375 # Modify the Info.plist as needed. The script explains why this 377 # Modify the Info.plist as needed. The script explains why this
376 # is needed. This is also done in the chrome and chrome_dll 378 # is needed. This is also done in the chrome and chrome_dll
377 # targets. In this case, --breakpad=0, --keystone=0, and --scm=0 379 # targets. In this case, --breakpad=0, --keystone=0, and --scm=0
378 # are used because Breakpad, Keystone, and SCM keys are 380 # are used because Breakpad, Keystone, and SCM keys are
379 # never placed into the helper. 381 # never placed into the helper.
380 'postbuild_name': 'Tweak Info.plist', 382 'postbuild_name': 'Tweak Info.plist',
381 'action': ['../../build/mac/tweak_info_plist.py', 383 'action': ['../../build/mac/tweak_info_plist.py',
384 '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',
382 '--breakpad=0', 385 '--breakpad=0',
383 '--keystone=0', 386 '--keystone=0',
384 '--scm=0', 387 '--scm=0',
385 '--version=<(app_shell_version)'], 388 '--version=<(app_shell_version)'],
386 }, 389 },
387 ], 390 ],
388 }, # target app_shell_helper 391 }, # target app_shell_helper
389 ], 392 ],
390 }], # OS=="mac" 393 }], # OS=="mac"
391 ['test_isolation_mode != "noop"', { 394 ['test_isolation_mode != "noop"', {
392 'targets': [ 395 'targets': [
393 { 396 {
394 'target_name': 'app_shell_unittests_run', 397 'target_name': 'app_shell_unittests_run',
395 'type': 'none', 398 'type': 'none',
396 'dependencies': [ 399 'dependencies': [
397 'app_shell_unittests', 400 'app_shell_unittests',
398 ], 401 ],
399 'includes': [ 402 'includes': [
400 '../../build/isolate.gypi', 403 '../../build/isolate.gypi',
401 ], 404 ],
402 'sources': [ 405 'sources': [
403 'app_shell_unittests.isolate', 406 'app_shell_unittests.isolate',
404 ], 407 ],
405 }, 408 },
406 ], 409 ],
407 }], 410 }],
408 ], 411 ],
409 } 412 }
OLDNEW
« no previous file with comments | « content/content_shell.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698