content/content_shell.gypi - Issue 1881053002: Rework build/mac/tweak_info_plist.py to not rely on environment variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/content_shell.gypi

Issue 1881053002: Rework build/mac/tweak_info_plist.py to not rely on environment variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/content_shell.gypi

diff --git a/content/content_shell.gypi b/content/content_shell.gypi

index 6d15a673aa38a7e2bc82b10156cbbf084edcf5d9..e1ffca04f7b565bbd1251ca7b2896603bd63c4d1 100644

--- a/content/content_shell.gypi

+++ b/content/content_shell.gypi

@@ -524,6 +524,7 @@

# Modify the Info.plist as needed.

'postbuild_name': 'Tweak Info.plist',

'action': ['../build/mac/tweak_info_plist.py',

+ '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',

'--scm=1',

'--version=<(content_shell_version)'],

@@ -619,6 +620,7 @@

# but this seems like a really good place to store them.

'postbuild_name': 'Tweak Info.plist',

'action': ['../build/mac/tweak_info_plist.py',

+ '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',

'--breakpad=1',

'--keystone=0',

'--scm=1',

@@ -709,6 +711,7 @@

# never placed into the helper.

'postbuild_name': 'Tweak Info.plist',

'action': ['../build/mac/tweak_info_plist.py',

+ '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',

'--breakpad=0',

'--keystone=0',

'--scm=0',

« no previous file with comments | « chrome/chrome_exe.gypi ('k') | extensions/shell/app_shell.gyp » ('j') | no next file with comments »