Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: chrome/app_shim/app_shim.gypi

Issue 1881053002: Rework build/mac/tweak_info_plist.py to not rely on environment variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/mac/tweak_info_plist.py ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # This is the part of the shim process compiled into Chrome. It runs only 8 # This is the part of the shim process compiled into Chrome. It runs only
9 # in the shim process, after the shim finds and loads the Chrome 9 # in the shim process, after the shim finds and loads the Chrome
10 # Framework bundle. 10 # Framework bundle.
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 }, 67 },
68 'postbuilds' : [ 68 'postbuilds' : [
69 { 69 {
70 # Modify the Info.plist as needed. The script explains why this 70 # Modify the Info.plist as needed. The script explains why this
71 # is needed. This is also done in the chrome and chrome_dll 71 # is needed. This is also done in the chrome and chrome_dll
72 # targets. In this case, --breakpad=0, --keystone=0, and --scm=0 72 # targets. In this case, --breakpad=0, --keystone=0, and --scm=0
73 # are used because Breakpad, Keystone, and SCM keys are 73 # are used because Breakpad, Keystone, and SCM keys are
74 # never placed into the app mode loader. 74 # never placed into the app mode loader.
75 'postbuild_name': 'Tweak Info.plist', 75 'postbuild_name': 'Tweak Info.plist',
76 'action': ['<(tweak_info_plist_path)', 76 'action': ['<(tweak_info_plist_path)',
77 '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',
77 '--breakpad=0', 78 '--breakpad=0',
78 '--keystone=0', 79 '--keystone=0',
79 '--scm=0'], 80 '--scm=0'],
80 }, 81 },
81 ], 82 ],
82 }, # target app_mode_app 83 }, # target app_mode_app
83 ], # targets 84 ], # targets
84 } 85 }
OLDNEW
« no previous file with comments | « build/mac/tweak_info_plist.py ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698