Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1880233002: Address Siva's comments from https://codereview.chromium.org/1877973002/ (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : h #

Patch Set 3 : Pass isolate as argument intead of the background compiler task #

Patch Set 4 : Adjust assert: Protect may be called while mutator_thread does not exist" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M runtime/vm/compiler.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/compiler_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/virtual_memory_android.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/virtual_memory_linux.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/virtual_memory_macos.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/virtual_memory_win.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 8 months ago (2016-04-12 19:51:55 UTC) #2
siva
LGTM.
4 years, 8 months ago (2016-04-12 20:01:12 UTC) #3
srdjan
4 years, 8 months ago (2016-04-12 22:45:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
4465fc3492d19405d4bb52a49bfe283ae30cb48c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698