runtime/vm/compiler.h - Issue 1880233002: Address Siva's comments from https://codereview.chromium.org/1877973002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.h

Issue 1880233002: Address Siva's comments from https://codereview.chromium.org/1877973002/ (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Adjust assert: Protect may be called while mutator_thread does not exist" Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.h

diff --git a/runtime/vm/compiler.h b/runtime/vm/compiler.h

index d226ccb92a9255002309e1510925e2e9e3bba77d..2f2eb1c5e64ea94f439428ba77d9959460e31e50 100644

--- a/runtime/vm/compiler.h

+++ b/runtime/vm/compiler.h

@@ -161,7 +161,8 @@ class BackgroundCompiler : public ThreadPool::Task {

static void EnsureInit(Thread* thread);

- static void Stop(BackgroundCompiler* task);

+ // Stops background compiler of the given isolate.

+ static void Stop(Isolate* isolate);

// Call to optimize a function in the background, enters the function in the

// compilation queue.

« no previous file with comments | « no previous file | runtime/vm/compiler.cc » ('j') | no next file with comments »