runtime/vm/compiler_test.cc - Issue 1880233002: Address Siva's comments from https://codereview.chromium.org/1877973002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler_test.cc

Issue 1880233002: Address Siva's comments from https://codereview.chromium.org/1877973002/ (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Adjust assert: Protect may be called while mutator_thread does not exist" Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler_test.cc

diff --git a/runtime/vm/compiler_test.cc b/runtime/vm/compiler_test.cc

index a26031c0ff0f790232451a78ccc301042757d0a2..f2e138cf0f06dc73bf69f101f1c5e2c8fa052ada 100644

--- a/runtime/vm/compiler_test.cc

+++ b/runtime/vm/compiler_test.cc

@@ -109,7 +109,7 @@ VM_TEST_CASE(CompileFunctionOnHelperThread) {

while (!func.HasOptimizedCode()) {

ml.WaitWithSafepointCheck(thread, 1);

}

- BackgroundCompiler::Stop(isolate->background_compiler());

+ BackgroundCompiler::Stop(isolate);

}

« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »