runtime/vm/isolate.h - Issue 1880233002: Address Siva's comments from https://codereview.chromium.org/1877973002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.h

Issue 1880233002: Address Siva's comments from https://codereview.chromium.org/1877973002/ (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Adjust assert: Protect may be called while mutator_thread does not exist" Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/isolate.h

diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h

index 8691dba44e2958aaf4fe00c78503361b714bca5c..3250082caff8c11e5d85df941c4cbf4451be8c01 100644

--- a/runtime/vm/isolate.h

+++ b/runtime/vm/isolate.h

@@ -525,7 +525,8 @@ class Isolate : public BaseIsolate {

// Used by mutator thread to notify background compiler which fields

// triggered code invalidation.

void AddDisablingField(const Field& field);

- // Returns Field::null() if none available in the list.

+ // Returns Field::null() if none available in the list. Can be called

+ // only from background compiler and while mutator thread is at safepoint.

RawField* GetDisablingField();

void ClearDisablingFieldList();

« no previous file with comments | « runtime/vm/compiler_test.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »