Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: runtime/vm/compiler.cc

Issue 1880233002: Address Siva's comments from https://codereview.chromium.org/1877973002/ (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Adjust assert: Protect may be called while mutator_thread does not exist" Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.h ('k') | runtime/vm/compiler_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index bf9aff779924fb9b93059f7fb5951fbd47d2c2d0..fd0e748e4f80e4901031e8993a2fbfc20a1bf229 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -382,7 +382,7 @@ class CompileParsedFunctionHelper : public ValueObject {
loading_invalidation_gen_at_start_(
isolate()->loading_invalidation_gen()) {
if (Compiler::IsBackgroundCompilation()) {
- Isolate::Current()->ClearDisablingFieldList();
+ isolate()->ClearDisablingFieldList();
}
}
@@ -1825,8 +1825,8 @@ void BackgroundCompiler::VisitPointers(ObjectPointerVisitor* visitor) {
}
-void BackgroundCompiler::Stop(BackgroundCompiler* task) {
- ASSERT(Isolate::Current()->background_compiler() == task);
+void BackgroundCompiler::Stop(Isolate* isolate) {
+ BackgroundCompiler* task = isolate->background_compiler();
ASSERT(task != NULL);
BackgroundCompilationQueue* function_queue = task->function_queue();
@@ -1853,7 +1853,7 @@ void BackgroundCompiler::Stop(BackgroundCompiler* task) {
delete done_monitor;
delete queue_monitor;
delete function_queue;
- Isolate::Current()->set_background_compiler(NULL);
+ isolate->set_background_compiler(NULL);
}
@@ -1994,7 +1994,7 @@ void BackgroundCompiler::VisitPointers(ObjectPointerVisitor* visitor) {
}
-void BackgroundCompiler::Stop(BackgroundCompiler* task) {
+void BackgroundCompiler::Stop(Isolate* isolate) {
UNREACHABLE();
}
« no previous file with comments | « runtime/vm/compiler.h ('k') | runtime/vm/compiler_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698