Add clone to Stage. Rename place to mix and PolymorphicUnion to Stage. Cleanup.

Add clone to Stage. Rename place to mix and PolymorphicUnion to Stage. Cleanup.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1877483002

Committed: https://skia.googlesource.com/skia/+/9e0efe57ac29b13d7f7a24ccefc456562acbad6c

[herb_g, 2016-04-08 19:11:16]

Description was changed from

==========
Add clone to Stage. Rename place to mix and PolymorphicUnion to Stage. Cleanup.

BUG=skia:
==========

to

==========
Add clone to Stage. Rename place to mix and PolymorphicUnion to Stage. Cleanup.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-04-08 19:12:15]

Description was changed from

==========
Add clone to Stage. Rename place to mix and PolymorphicUnion to Stage. Cleanup.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add clone to Stage. Rename place to mix and PolymorphicUnion to Stage. Cleanup.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-04-08 19:12:15]

herb@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-04-08 19:30:29]

👍

https://codereview.chromium.org/1877483002/diff/1/src/core/SkBitmapProcShader.h
File src/core/SkBitmapProcShader.h (right):

https://codereview.chromium.org/1877483002/diff/1/src/core/SkBitmapProcShader...
src/core/SkBitmapProcShader.h:58: typedef SkSmallAllocator<3, 2400>
SkTBlitterAllocator;
Think it's good idea to define a constant on SkLinearBitmapPipeline, or in its
.h, so we don't have to keep making sure to update these sites (and that we got
all of them)?

https://codereview.chromium.org/1877483002/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline.h (right):

https://codereview.chromium.org/1877483002/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:43: // Note: There is no cloneSinkTo method
because to code usually places the top part of
to -> the ?

https://codereview.chromium.org/1877483002/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:44: // the pipeline on a new sampler.
Copy this stage to `cloneToStage` with `next` as its next stage (not necessarily
the same as our next, you see),
returning `cloneToStage`.

https://codereview.chromium.org/1877483002/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:69: using MixStage    =
Stage<MixProcessorInterface, 80>;
BlendStage or XferStage?

[herb_g, 2016-04-08 19:51:55]

https://codereview.chromium.org/1877483002/diff/1/src/core/SkBitmapProcShader.h
File src/core/SkBitmapProcShader.h (right):

https://codereview.chromium.org/1877483002/diff/1/src/core/SkBitmapProcShader...
src/core/SkBitmapProcShader.h:58: typedef SkSmallAllocator<3, 2400>
SkTBlitterAllocator;
On 2016/04/08 19:30:29, mtklein wrote:
> Think it's good idea to define a constant on SkLinearBitmapPipeline, or in its
> .h, so we don't have to keep making sure to update these sites (and that we
got
> all of them)?

This is good advice, but I'm going to ignore it for now. I would like to
experiment with a clean way of doing this. C++ should be able to calculate all
these things for us, but we need to get those calculations to work across all
compilers.

https://codereview.chromium.org/1877483002/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline.h (right):

https://codereview.chromium.org/1877483002/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:43: // Note: There is no cloneSinkTo method
because to code usually places the top part of
On 2016/04/08 19:30:29, mtklein wrote:
> to -> the ?

Done.

https://codereview.chromium.org/1877483002/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:44: // the pipeline on a new sampler.
On 2016/04/08 19:30:29, mtklein wrote:
> Copy this stage to `cloneToStage` with `next` as its next stage (not
necessarily
> the same as our next, you see),
> returning `cloneToStage`.

Done.

https://codereview.chromium.org/1877483002/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:69: using MixStage    =
Stage<MixProcessorInterface, 80>;
On 2016/04/08 19:30:29, mtklein wrote:
> BlendStage or XferStage?

Done.

[herb_g, 2016-04-08 19:58:22]

Address review comments.

[herb_g, 2016-04-08 19:58:41]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 19:58:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877483002/20001

[commit-bot: I haz the power, 2016-04-08 20:12:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 20:12:40]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-04-08 20:20:52]

lgtm

[herb_g, 2016-04-08 20:24:18]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2016-04-08 20:24:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877483002/20001

[commit-bot: I haz the power, 2016-04-08 20:25:30]

Description was changed from

==========
Add clone to Stage. Rename place to mix and PolymorphicUnion to Stage. Cleanup.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add clone to Stage. Rename place to mix and PolymorphicUnion to Stage. Cleanup.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/9e0efe57ac29b13d7f7a24ccefc456562acbad6c
==========

[commit-bot: I haz the power, 2016-04-08 20:25:31]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9e0efe57ac29b13d7f7a24ccefc456562acbad6c