Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1877453002: Fix printf formats (Closed)

Created:
4 years, 8 months ago by JF
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix printf formats The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 R= jochen@chromium.org TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org Committed: https://crrev.com/bf505329288e1b75bab0e6800371a9aac40fa5cc Cr-Commit-Position: refs/heads/master@{#35394}

Patch Set 1 #

Patch Set 2 : Fix Mac build #

Patch Set 3 : Another Mac fix, all Mac bots pass except v8_mac_dbg #

Patch Set 4 : Handle ptrdiff_t format, which seems to make MSVC barf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -261 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/simulator-arm64.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/ast/prettyprinter.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/ast/prettyprinter.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/base/compiler-specific.h View 1 chunk +11 lines, -0 lines 0 comments Download
A src/base/format-macros.h View 1 chunk +97 lines, -0 lines 0 comments Download
M src/base/logging.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/base/macros.h View 1 2 3 2 chunks +14 lines, -15 lines 0 comments Download
M src/base/platform/platform.h View 3 chunks +12 lines, -11 lines 0 comments Download
M src/compilation-statistics.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen-range-analysis.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/crankshaft/lithium-allocator.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/crankshaft/lithium-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
M src/global-handles.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/gc-tracer.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/heap/gc-tracer.cc View 3 chunks +29 lines, -29 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +47 lines, -49 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +6 lines, -14 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/log.cc View 9 chunks +12 lines, -14 lines 0 comments Download
M src/log-utils.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/log-utils.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/profiler/allocation-tracker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/profiler/profile-generator.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/profiler/strings-storage.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/snapshot/serializer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/utils.h View 3 chunks +11 lines, -30 lines 0 comments Download
M src/wasm/decoder.h View 4 chunks +8 lines, -5 lines 0 comments Download
M src/wasm/wasm-result.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 5 chunks +5 lines, -6 lines 0 comments Download
M src/x87/disasm-x87.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M test/cctest/test-log.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877453002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877453002/60001
4 years, 8 months ago (2016-04-09 02:03:35 UTC) #2
JF
Looks like the non-default bots which were failing post-commit (v8_win_dbg, v8_win64_dbg, v8_mac_dbg) are now passing. ...
4 years, 8 months ago (2016-04-09 02:04:18 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-09 02:30:50 UTC) #5
JF
PTAL. This looks good to go again, and I think I ran all the extra ...
4 years, 8 months ago (2016-04-09 02:33:42 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-09 23:44:25 UTC) #9
JF
I'm going to assume this is good to commit based on jochen's lgtm and other ...
4 years, 8 months ago (2016-04-11 16:02:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877453002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877453002/60001
4 years, 8 months ago (2016-04-11 16:02:34 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-11 16:26:01 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/bf505329288e1b75bab0e6800371a9aac40fa5cc Cr-Commit-Position: refs/heads/master@{#35394}
4 years, 8 months ago (2016-04-11 16:28:02 UTC) #17
Michael Achenbach
4 years, 8 months ago (2016-04-11 17:27:02 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1877823003/ by machenbach@chromium.org.

The reason for reverting is: Breaks gc mole: 
https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/9421.

Powered by Google App Engine
This is Rietveld 408576698