Fix printf formats

Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done).
 - Fixes a bunch of incorrect formats.

R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org

Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d
Cr-Commit-Position: refs/heads/master@{#35365}

[JF, 2016-04-07 00:35:20]

The CQ bit was checked by jfb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 00:35:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869433004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869433004/1

[commit-bot: I haz the power, 2016-04-07 00:39:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 00:39:19]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[JF, 2016-04-07 01:04:07]

The CQ bit was checked by jfb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 01:04:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869433004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869433004/20001

[JF, 2016-04-07 21:31:26]

Description was changed from

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. Import the PRINTF_FORMAT macro
from Chrome's src/base/compiler-specific.h and use it appropriately.
==========

to

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats:

 - Import PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Use it appropriately.
 - Import Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
==========

[JF, 2016-04-07 21:31:38]

The CQ bit was checked by jfb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 21:31:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869433004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869433004/80001

[commit-bot: I haz the power, 2016-04-07 21:40:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 21:40:52]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/18110)

[JF, 2016-04-08 01:03:14]

The CQ bit was checked by jfb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 01:03:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869433004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869433004/120001

[JF, 2016-04-08 01:08:49]

Description was changed from

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats:

 - Import PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Use it appropriately.
 - Import Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
==========

to

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.
==========

[commit-bot: I haz the power, 2016-04-08 01:12:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 01:12:12]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/5555)
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/5440)

[JF, 2016-04-08 01:26:10]

Description was changed from

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.
==========

to

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.

R=jochen@chromium.org
==========

[JF, 2016-04-08 01:26:10]

jfb@chromium.org changed reviewers:
+ jochen@chromium.org

[JF, 2016-04-08 01:26:52]

jochen: as discussed today, I think this is now good to review (a few bots are
still running, but most seem fine).

[jochen (gone - plz use gerrit), 2016-04-08 01:46:55]

lgtm with comments

https://codereview.chromium.org/1869433004/diff/120001/src/base/format_macros.h
File src/base/format_macros.h (right):

https://codereview.chromium.org/1869433004/diff/120001/src/base/format_macros...
src/base/format_macros.h:1: // Copyright 2016 the V8 project authors. All rights
reserved.
for consistency, can you rename this file to format-macros.h?

also, please add it to the BUILD.gn and v8.gyp files

[JF, 2016-04-08 05:32:21]

https://codereview.chromium.org/1869433004/diff/120001/src/base/format_macros.h
File src/base/format_macros.h (right):

https://codereview.chromium.org/1869433004/diff/120001/src/base/format_macros...
src/base/format_macros.h:1: // Copyright 2016 the V8 project authors. All rights
reserved.
On 2016/04/08 01:46:55, jochen - slow wrote:
> for consistency, can you rename this file to format-macros.h?
> 
> also, please add it to the BUILD.gn and v8.gyp files

Done.

[JF, 2016-04-08 05:32:31]

The CQ bit was checked by jfb@chromium.org

[JF, 2016-04-08 05:32:31]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1869433004/#ps140001
(title: "Address review comments.")

[commit-bot: I haz the power, 2016-04-08 05:32:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869433004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869433004/140001

[commit-bot: I haz the power, 2016-04-08 05:36:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 05:36:07]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13389)

[JF, 2016-04-08 05:40:06]

jfb@chromium.org changed reviewers:
+ ahaas@chromium.org, bmeurer@chromium.org, yangguo@chromium.org

[JF, 2016-04-08 05:40:07]

Looks like I need moar lgtms! Sounds like bmeurer, yangguo, ahaas are a good
minset.

[JF, 2016-04-08 05:41:40]

Description was changed from

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.

R=jochen@chromium.org
==========

to

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.

R=jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org,
ahaas@chromium.org
==========

[JF, 2016-04-08 05:41:52]

Description was changed from

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.

R=jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org,
ahaas@chromium.org
==========

to

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.

R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org,
ahaas@chromium.org
==========

[Benedikt Meurer, 2016-04-08 07:11:00]

LGTM

[Yang, 2016-04-08 08:39:57]

On 2016/04/08 07:11:00, Benedikt Meurer wrote:
> LGTM

lgtm

[Yang, 2016-04-08 08:43:57]

On 2016/04/08 07:11:00, Benedikt Meurer wrote:
> LGTM

lgtm

[ahaas, 2016-04-08 12:07:40]

On 2016/04/08 at 08:43:57, yangguo wrote:
> On 2016/04/08 07:11:00, Benedikt Meurer wrote:
> > LGTM
> 
> lgtm

wasm lgtm

[JF, 2016-04-08 15:13:30]

The CQ bit was checked by jfb@chromium.org

[commit-bot: I haz the power, 2016-04-08 15:13:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869433004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869433004/140001

[commit-bot: I haz the power, 2016-04-08 15:29:50]

Description was changed from

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.

R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org,
ahaas@chromium.org
==========

to

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.

R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org,
ahaas@chromium.org
==========

[commit-bot: I haz the power, 2016-04-08 15:29:52]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-08 15:31:27]

Description was changed from

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.

R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org,
ahaas@chromium.org
==========

to

==========
Fix printf formats

The usage of __attribute__((format(x, y)) was either wrong or missing from
multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further
cleanup could be done).
 - Fixes a bunch of incorrect formats.

R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org,
ahaas@chromium.org

Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d
Cr-Commit-Position: refs/heads/master@{#35365}
==========

[commit-bot: I haz the power, 2016-04-08 15:31:29]

Patchset 8 (id:??) landed as
https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d
Cr-Commit-Position: refs/heads/master@{#35365}

[JF, 2016-04-08 16:10:16]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1867383002/ by jfb@chromium.org.

The reason for reverting is: One small issue easily fixed here:
https://codereview.chromium.org/1867333003/

But it looks like MSVS 2013 doesn't like some of the formats and exists with the
unhelpful:
Stderr:
f:\dd\vctools\crt\crtw32\stdio\output.c(1125) : Assertion failed: ("Incorrect
format specifier", 0)

It's easier to revert for now, I'll dig more into the docs:
https://msdn.microsoft.com/en-us/library/56e442dc(v=vs.120).aspx
https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.120).aspx

And then resubmit, making sure I run these bots..